Bug 279527 - devel/git: portmaster : invalid option -- D
Summary: devel/git: portmaster : invalid option -- D
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Renato Botelho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-04 18:30 UTC by O. Hartmann
Modified: 2024-06-05 15:52 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (garga)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description O. Hartmann 2024-06-04 18:30:26 UTC

    
Comment 1 O. Hartmann 2024-06-04 18:33:15 UTC
Using portmaster -d devel/git results in

[...]
mv gitweb/gitweb.cgi+ gitweb/gitweb.cgi
/usr/bin/env V=1 CURLDIR=/usr/local OPENSSLBASE=/usr OPENSSLDIR=/etc/ssl OPENSSLINC=/usr/include OPENSSLLIB=/usr/lib PERL_USE_UNSAFE_INC=1 XDG_DATA_HOME=/usr/ports/devel/git/work-default  XDG_CONFIG_HOME=/usr/ports/devel/git/work-default  XDG_CACHE_HOME=/usr/ports/devel/git/work-default/.cache  HOME=/usr/ports/devel/git/work-default TMPDIR="/tmp" PATH=/usr/ports/devel/git/work-default/.bin:/bin:/usr/bin:/sbin:/usr/sbin:/usr/local/bin:/usr/local/sbin PKG_CONFIG_LIBDIR=/usr/ports/devel/git/work-default/.pkgconfig:/usr/local/libdata/pkgconfig:/usr/local/share/pkgconfig:/usr/libdata/pkgconfig MK_DEBUG_FILES=no MK_KERNEL_SYMBOLS=no SHELL=/bin/sh NO_LINT=YES DEFAULT_AUTOCONF=2.72 PREFIX=/usr/local  LOCALBASE=/usr/local  CC="cc" CFLAGS="-O2 -pipe  -DLIBICONV_PLUG -fstack-protector-strong -fno-strict-aliasing "  CPP="cpp" CPPFLAGS="-isystem/usr/local/include -DLIBICONV_PLUG"  LDFLAGS=" -L/usr/local/lib  -fstack-protector-strong " LIBS=""  CXX="c++" CXXFLAGS="-O2 -pipe -DLIBICONV_PLUG -fstack-protector-strong -fno-strict-aliasing  -DLIBICONV_PLUG " BSD_INSTALL_PROGRAM="install  -s -m 555"  BSD_INSTALL_LIB="install  -s -m 0644"  BSD_INSTALL_SCRIPT="install  -m 555"  BSD_INSTALL_DATA="install  -m 0644"  BSD_INSTALL_MAN="install  -m 444" gmake -C /usr/ports/devel/git/work-default/git-2.45.2/contrib/diff-highlight
: invalid option -- D
Usage: gmake [options] [target] ...
Options:
  -b, -m                      Ignored for compatibility.
  -B, --always-make           Unconditionally make all targets.
  -C DIRECTORY, --directory=DIRECTORY
                              Change to DIRECTORY before doing anything.
  -d                          Print lots of debugging information.
[...]

The problem is well known and due to 

Changes:
20240229:
AUTHOR: tijl@FreeBSD.org
Comment 2 Chris Hutchinson 2024-06-04 20:57:40 UTC
I've been running into this periodically for the
last week. I finally took the time about 10 minute
ago to see if my suspicion was correct;
I use the likws of: make -DBATCH ... when testing
ports (note the -D here). Removing -DBATCH from the
incantation, removes the error && message. I haven't
chased the anomaly any further. But hope this helps.

--Chris
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-06-05 14:35:21 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bc5cba2753c702214cfd9b7ed51385f6f2b8428f

commit bc5cba2753c702214cfd9b7ed51385f6f2b8428f
Author:     Renato Botelho <garga@FreeBSD.org>
AuthorDate: 2024-06-05 14:32:47 +0000
Commit:     Renato Botelho <garga@FreeBSD.org>
CommitDate: 2024-06-05 14:34:45 +0000

    devel/git: Fix build using SETENVI and WRK_ENV

    Followup needed changes after 572f23616926 and call upstream build
    scripts properly

    PR:             279527
    Reported by:    O. Hartmann <ohartmann@walstatt.org>
    MFH:            2024Q2
    Sponsored by:   Rubicon Communications, LLC ("Netgate")

 devel/git/Makefile | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-06-05 14:35:22 UTC
A commit in branch 2024Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=963f6387bc3ebb5bb671d9a7d960654a5fe62175

commit 963f6387bc3ebb5bb671d9a7d960654a5fe62175
Author:     Renato Botelho <garga@FreeBSD.org>
AuthorDate: 2024-06-05 14:32:47 +0000
Commit:     Renato Botelho <garga@FreeBSD.org>
CommitDate: 2024-06-05 14:35:05 +0000

    devel/git: Fix build using SETENVI and WRK_ENV

    Followup needed changes after 572f23616926 and call upstream build
    scripts properly

    PR:             279527
    Reported by:    O. Hartmann <ohartmann@walstatt.org>
    MFH:            2024Q2
    Sponsored by:   Rubicon Communications, LLC ("Netgate")

    (cherry picked from commit bc5cba2753c702214cfd9b7ed51385f6f2b8428f)

 devel/git/Makefile | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Comment 5 O. Hartmann 2024-06-05 15:52:12 UTC
(In reply to Chris Hutchinson from comment #2)

A temporary workaround is to jump into /usr/ports/category/ports and perform "make all" and subsequent portmaster -C /usr/ports/category/ports. 
There are lots of ports not working the way they should with portmaster. Since I use only a specific subset of ports, I might not find all of them ;-)

Thanks anyway for fixing this issue!

Kind regards.