Bug 279602 - misc/vifm fails to build without DOCS
Summary: misc/vifm fails to build without DOCS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Nicola Vitale
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-09 08:07 UTC by Ivan
Modified: 2024-08-02 15:57 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (nivit)

Attachments
log (24.43 KB, text/plain)
2024-06-09 08:07 UTC, Ivan 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan 2024-06-09 08:07:09 UTC 
Created attachment 251306 [details]
log

With DOCS option not set and vim dependency excluded, make script bails out. Probably, vim should be included regardless DOCS state.
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-08-02 15:35:50 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=caf601941c8570b5c8c6a50778da7dfbf8a90a6b

commit caf601941c8570b5c8c6a50778da7dfbf8a90a6b
Author:     Nicola Vitale <nivit@FreeBSD.org>
AuthorDate: 2024-08-02 15:21:27 +0000
Commit:     Nicola Vitale <nivit@FreeBSD.org>
CommitDate: 2024-08-02 15:34:39 +0000

    misc/vifm: Fix build when DOCS option is off

    - Vim or perl is a requirement to build the program/port, regardless of
      the user's choice to disable docs installation.
      Replace vim with perl5 to reduce the list of (build) dependencies.
    - Pet port(clippy|fmt)
    - Bump PORTREVISION even if it is not strictly necessary.

    PR:             279602
    Reported by:    Ivan <bsd@abinet.ru>

 misc/vifm/Makefile | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)
Comment 2 Nicola Vitale freebsd_committer freebsd_triage 2024-08-02 15:57:04 UTC 
Fixed. Thank you for the PR!