Bug 279749 - audio/libmusicbrainz5: Fails to build with libxml2 2.12.0 and newer
Summary: audio/libmusicbrainz5: Fails to build with libxml2 2.12.0 and newer
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks: 279705
  Show dependency tree / graph
 
Reported: 2024-06-15 05:37 UTC by Daniel Engberg
Modified: 2024-08-25 13:04 UTC (History)
0 users

See Also:
jhale: maintainer-feedback+

Attachments
Patch for libmusicbrainz5 (3.80 KB, patch)
2024-06-25 21:43 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Jason E. Hale freebsd_committer freebsd_triage 2024-06-15 07:56:04 UTC 
If the latest commit works with the current version of libxml2, feel free to update it now. If not, feel free to commit the update alongside the new version of libxml2.
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2024-06-15 12:00:04 UTC 
Any idea if we still need the patch for libkcddb ?
Comment 3 Jason E. Hale freebsd_committer freebsd_triage 2024-06-15 15:21:05 UTC 
(In reply to Daniel Engberg from comment #2)
I would think so. libkcddb still builds with -fvisibility=hidden, so would likely still crash under certain conditions if the exception symbols from libmusicbrainz are hidden.

adridg@ did a pretty good job of explaining why this is needed in the bug report he filed 8 years ago [1], but still no response from upstream.

[1] https://tickets.metabrainz.org/browse/LMB-43
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2024-06-25 21:43:50 UTC 
Created attachment 251698 [details]
Patch for libmusicbrainz5

* Update to latest upstream commit

With libxml2 and libxslt patches
Poudriere testport OK 13.2-RELEASE (amd64)
Poudriere testport OK 14.0-RELEASE (amd64)

Without 
Poudriere testport OK 13.2-RELEASE (amd64)
Poudriere testport OK 14.1-RELEASE (amd64)

Not runtime tested
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2024-07-03 19:48:31 UTC 
Jason, can you give this a try when you have time?
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-08-25 13:03:44 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5938202e494d65dc5d0082127134a6b412629552

commit 5938202e494d65dc5d0082127134a6b412629552
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-08-25 12:59:30 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-08-25 13:02:49 +0000

    audio/libmusicbrainz5: Update to latest commit 2023-10-09

    Fixes build with libxml2 2.12.0 and newer

    PR:             279749
    Reviewed by:    jhale (maintainer)

 audio/libmusicbrainz5/Makefile                       |  9 ++++-----
 audio/libmusicbrainz5/distinfo                       |  6 +++---
 audio/libmusicbrainz5/files/patch-src_CMakeLists.txt | 14 ++------------
 audio/libmusicbrainz5/pkg-plist                      |  8 ++++++--
 4 files changed, 15 insertions(+), 22 deletions(-)
Comment 7 Daniel Engberg freebsd_committer freebsd_triage 2024-08-25 13:04:26 UTC 
Committed, thanks