Bug 279919 - www/librewolf: update to librewolf-127.0.1
Summary: www/librewolf: update to librewolf-127.0.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL: https://www.mozilla.org/en-US/firefox...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-22 22:55 UTC by Martin Filla
Modified: 2024-07-13 07:48 UTC (History)
3 users (show)

See Also:
fernape: maintainer-feedback? (freebsd)


Attachments
0001-www-librewolf-update-to-127 (15.12 KB, patch)
2024-06-22 22:55 UTC, Martin Filla
freebsd: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Filla 2024-06-22 22:55:54 UTC
Created attachment 251628 [details]
0001-www-librewolf-update-to-127

Hi,
this is an update to librewolf 127.0.1
Comment 1 Martin Filla 2024-06-22 22:57:50 UTC
pouriere ok 

Updating database digests format: .......... done
Checking integrity... done (0 conflicting)
Deinstallation has been requested for the following 1 packages (of 0 packages in the universe):

Installed packages to be REMOVED:
	librewolf: 127.0.1

Number of packages to be removed: 1

The operation will free 257 MiB.
[freebsd132x64-default] [1/1] Deinstalling librewolf-127.0.1...
[freebsd132x64-default] [1/1] Deleting files for librewolf-127.0.1: .......... done
==> Running trigger: desktop-file-utils.ucl
Building cache database of MIME types
===========================================================================
=>> Checking for extra files and directories
[09:56:23] Installing from package
[freebsd132x64-default] Installing librewolf-127.0.1...
[freebsd132x64-default] Extracting librewolf-127.0.1: .......... done
==> Running trigger: desktop-file-utils.ucl
Building cache database of MIME types
=====
Message from librewolf-127.0.1:

--
## Missing features

Some features found on Windows, macOS and Linux are not implemented:

- Encrypted Media Extensions (requires Widevine CDM binary)
- Process sandboxing (requires Capsicum backend)
- Reduced memory usage (requires mozjemalloc)
- Crash Reporter (requires Google Breakpad and reproducible builds)
- WebVR (requires open source runtime)
- TCP fast open
- `about:networking` (requires link state notification)

## Audio backend

Currently used audio backend can be inspected on `about:support` page.
Supported backends and default probing order is as follows:
- `pulse-rust` if `pulseaudio` package is installed (PULSEAUDIO option)
- `jack` if `jackit` package is installed (JACK option)
- `sndio` if `sndio` package is installed (SNDIO option)
- `alsa` if `alsa-lib` package is installed (ALSA option)
- `oss` (always available)
To force a specific backend open `about:config` page and create
`media.cubeb.backend` preference.

Microphone selection only works in `oss`, `pulse`, `pulse-rust` backends.
Other backends are limited to `default` which is usually `/dev/dsp`,
so use virtual_oss to reroute microphones from non-default devices.

## Gamepad API

Requires evdev(4) joystick support. On FreeBSD 13.0 enable hgame(4)
while older versions can use sysutils/iichid or multimedia/webcamd.

## smb:// issues
Network group, machine, and share browsing does not work correctly.

## sftp://
Only sftp access using public key authentication works. To easily
setup public key authentication to `remote_host`:

    $ ssh-keygen
    $ cat ~/.ssh/id_rsa.pub | ssh remote_host "cat >> .ssh/authorized_keys"

The SSH server on `remote_host` must allow pub key authentication.
[09:56:28] Cleaning up
===>  Cleaning for librewolf-127.0.1
[10:02:35] Deinstalling package
Updating database digests format: . done
Checking integrity... done (0 conflicting)
Deinstallation has been requested for the following 1 packages (of 0 packages in the universe):

Installed packages to be REMOVED:
	librewolf: 127.0.1

Number of packages to be removed: 1

The operation will free 257 MiB.
[freebsd132x64-default] [1/1] Deinstalling librewolf-127.0.1...
[freebsd132x64-default] [1/1] Deleting files for librewolf-127.0.1: .......... done
==> Running trigger: desktop-file-utils.ucl
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2024-06-24 08:54:11 UTC
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval.
--
Attachment -> Details -> maintainer-approval [+]


Thanks!
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2024-06-25 16:17:49 UTC
Committed,

Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-06-25 16:18:28 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=081f9ff2083f8e0b9384223d69fc7d84f3a1f4a2

commit 081f9ff2083f8e0b9384223d69fc7d84f3a1f4a2
Author:     Martin Filla <freebsd@sysctl.cz>
AuthorDate: 2024-06-24 08:54:41 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2024-06-25 16:17:33 +0000

    www/librewolf: update to librewolf-127.0.1

    PR:             279919
    Reported by:    freebsd@sysctl.cz (maintainer)

 www/librewolf/Makefile                        |   2 +-
 www/librewolf/distinfo                        |   6 +-
 www/librewolf/files/patch-libwebrtc-generated | 221 ++++++++++++++++++++++++--
 3 files changed, 208 insertions(+), 21 deletions(-)
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2024-06-30 16:15:20 UTC
Typo in "MOZ_OPTIONs=", but build fails after fix it.
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2024-07-03 06:50:19 UTC
(In reply to Vladimir Druzenko from comment #5)
That's unfortunate.

It builds fine in 13.2, 14.0 and 14.1 but fails in current with this error:

2 warnings generated.
2 warnings generated.
2 warnings generated.
2 warnings generated.
2 warnings generated.
gmake[3]: Leaving directory '/wrkdirs/usr/ports/www/librewolf/work/.build/dom/ipc'
gmake[2]: Leaving directory '/wrkdirs/usr/ports/www/librewolf/work/.build'
gmake[1]: *** [/wrkdirs/usr/ports/www/librewolf/work/librewolf-127.0-1/config/recurse.mk:34: compile] Error 2
gmake[1]: Leaving directory '/wrkdirs/usr/ports/www/librewolf/work/.build'
gmake: *** [/wrkdirs/usr/ports/www/librewolf/work/librewolf-127.0-1/config/rules.mk:361: all] Error 2
gmake: INTERNAL: Exiting with 6 jobserver tokens available; should be 12!

MAKE_JOBS_UNSAFE=yes workarounds this in current.

I will commit later today.

Thanks!
Comment 7 Fernando Apesteguía freebsd_committer freebsd_triage 2024-07-12 10:31:03 UTC
(In reply to Fernando Apesteguía from comment #6)
I was wrong, the actual error is:
checking for vcs source checkout... no
checking for a shell... /bin/sh
checking for host system type... x86_64-unknown-freebsd14.1
checking for target system type... x86_64-unknown-freebsd14.1
checking whether cross compiling... no
Traceback (most recent call last):
  File "/wrkdirs/usr/ports/www/librewolf/work/librewolf-127.0-1/configure.py", line 351, in <module>
    sys.exit(main(sys.argv))
             ^^^^^^^^^^^^^^
  File "/wrkdirs/usr/ports/www/librewolf/work/librewolf-127.0-1/configure.py", line 141, in main
    sandbox.run()
  File "/wrkdirs/usr/ports/www/librewolf/work/librewolf-127.0-1/python/mozbuild/mozbuild/configure/__init__.py", line 522, in run
    self._value_for(option)
  File "/wrkdirs/usr/ports/www/librewolf/work/librewolf-127.0-1/python/mozbuild/mozbuild/configure/__init__.py", line 627, in _value_for
    return self._value_for_option(obj)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/wrkdirs/usr/ports/www/librewolf/work/librewolf-127.0-1/python/mozbuild/mozbuild/util.py", line 911, in method_call
    cache[args] = self.func(instance, *args)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/wrkdirs/usr/ports/www/librewolf/work/librewolf-127.0-1/python/mozbuild/mozbuild/configure/__init__.py", line 662, in _value_for_option
    value, option_string = self._helper.handle(option)
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/wrkdirs/usr/ports/www/librewolf/work/librewolf-127.0-1/python/mozbuild/mozbuild/configure/options.py", line 594, in handle
    ret = option.get_value(arg, origin)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/wrkdirs/usr/ports/www/librewolf/work/librewolf-127.0-1/python/mozbuild/mozbuild/configure/options.py", line 427, in get_value
    raise InvalidOptionError(
mozbuild.configure.options.InvalidOptionError: MOZ_SERVICES_HEALTHREPORT=0 can not be set by mozconfig. Values are accepted from: implied
===>  Script "configure" failed unexpectedly.
Please report the problem to freebsd@sysctl.cz [maintainer] and attach the
"/wrkdirs/usr/ports/www/librewolf/work/.build/config.log" including the output
of the failure of your make command. Also, it might be a good idea to provide
an overview of all packages installed on your system (e.g. a
/usr/local/sbin/pkg-static info -g -Ea).
*** Error code 1


Martin, could you have a look at it?
Comment 8 Martin Filla 2024-07-12 10:43:37 UTC
(In reply to Fernando Apesteguía from comment #7)
Hi,
this MOZ_SERVICES_HEALTHREPORT was removed in the next version, upgrade it to librewolf 127.0.2
Comment 9 Fernando Apesteguía freebsd_committer freebsd_triage 2024-07-12 12:12:06 UTC
(In reply to Martin Filla from comment #8)
128.0.1 is out already. Can you update to that?
Comment 10 Vladimir Druzenko freebsd_committer freebsd_triage 2024-07-12 12:25:47 UTC
(In reply to Fernando Apesteguía from comment #9)
128.0-1
6 hours ago
https://codeberg.org/librewolf/source/releases/tag/128.0-1
Better create separate PR with patch.

127.0.2-2: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280214
Comment 11 Martin Filla 2024-07-13 07:48:54 UTC
(In reply to Fernando Apesteguía from comment #9)
here is update https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280253