Bug 279996 - lang/gnat12: missing ali files for aarch64
Summary: lang/gnat12: missing ali files for aarch64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mikael Urankar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-26 05:04 UTC by Jonathan Chen
Modified: 2024-12-09 18:35 UTC (History)
4 users (show)

See Also:
thierry: maintainer-feedback+


Attachments
gnat12 aarch ali fix (2.16 KB, patch)
2024-06-26 05:04 UTC, Jonathan Chen
no flags Details | Diff
v0 (407.56 KB, patch)
2024-12-09 18:33 UTC, Mikael Urankar
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Chen 2024-06-26 05:04:41 UTC
Created attachment 251703 [details]
gnat12 aarch ali fix

For ARCH=aarch64, multiple ads (ada specification files) have been installed without corresponding ali (ada library) files. In particular:

/usr/local/gnat12/lib/gcc/aarch64-portbld-freebsd14.1/12.3.0/adainclude/s-imglllb.ads
/usr/local/gnat12/lib/gcc/aarch64-portbld-freebsd14.1/12.3.0/adainclude/s-imgllli.ads
/usr/local/gnat12/lib/gcc/aarch64-portbld-freebsd14.1/12.3.0/adainclude/s-imglllu.ads
/usr/local/gnat12/lib/gcc/aarch64-portbld-freebsd14.1/12.3.0/adainclude/s-imglllw.ads

The attached patch fixes this.

Additionally, this unblocks the build for devel/gprbuild on aarch64 as well.
Comment 1 Jonathan Chen 2024-08-13 04:27:25 UTC
Any chance of reviewing and committing this?
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-11-29 12:36:05 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=33718f6b048fb4f37d4731783b3533c6331f6943

commit 33718f6b048fb4f37d4731783b3533c6331f6943
Author:     Jonathan Chen <jonc@chen.org.nz>
AuthorDate: 2024-11-29 12:34:30 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2024-11-29 12:35:52 +0000

    lang/gnat12: Fix build on aarch64

    PR:             279996
    Approved by:    thierry

 lang/gnat12/Makefile  | 2 +-
 lang/gnat12/pkg-plist | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
Comment 3 Thierry Thomas freebsd_committer freebsd_triage 2024-12-07 18:22:21 UTC
Hello,
It seems that broke the package for i386: see
https://pkg-status.freebsd.org/beefy17/data/main-i386-default/pbec5b03b75e1_sc3c2f0ddd81/logs/gnat12-12.3.0.log

===>  Building packages for gnat12-12.3.0
===>   Building gnat12-12.3.0
pkg-static: Unable to access file
/wrkdirs/usr/ports/lang/gnat12/work/stage/usr/local/gnat12/lib/gcc/i386-portbl
d-freebsd15.0/12.3.0/plugin/include/config/i386/biarch64.h:No such file or
directory
pkg-static: Unable to access file
/wrkdirs/usr/ports/lang/gnat12/work/stage/usr/local/gnat12/lib/gcc/i386-portbl
d-freebsd15.0/12.3.0/plugin/include/config/i386/freebsd64.h:No such file or
directory
pkg-static: Unable to access file
/wrkdirs/usr/ports/lang/gnat12/work/stage/usr/local/gnat12/lib/gcc/i386-portbl
d-freebsd15.0/12.3.0/plugin/include/config/i386/x86-64.h:No such file or
directory
*** Error code 1

Stop.
make: stopped making "package" in /usr/ports/lang/gnat12
Comment 4 Mikael Urankar freebsd_committer freebsd_triage 2024-12-09 18:33:20 UTC
Created attachment 255750 [details]
v0

reopen
Comment 5 Mikael Urankar freebsd_committer freebsd_triage 2024-12-09 18:35:46 UTC
(In reply to Mikael Urankar from comment #4)
The MULTILIB / LIB_DIR_32 is over engineered, I don't have lib32 on my machine and can't test this part.