Created attachment 251861 [details] patch for 20231210a patch for 20231210a update nll to 20240703a: - Buildup of the graphic functions. - Added and modified some functions. - Added some character sets. - Supported the palette of bitmap file. - Modified the new command for the variable. - Added and changed some embedded variables. - Added the support of the loop link. - Enhanced some operators. - Added the argument to the stop command. - Modified the pointer access to the array. - Enable to set the minus value to the line number. - Added the informaion for the version. - Fixed some bugs. link: https://kozos.jp/nlux/download.html Port changes: - no changed
*** Bug 277882 has been marked as a duplicate of this bug. ***
Could you please check "portfmt -D Makefile" (ports-mgmt/portfmt) and update yor patch? And please set "maintainer-approval"-flag. Thanks!
Created attachment 251881 [details] patch for 20231210a I checked "portfmt -D Makefile", updated the patch and set "maintainer-approval"-flag.
(In reply to SAKAI Hiroaki from comment #3) Thanks! I'm checking your Makefile and I've some questions: 1. you've two flavors: default and nosdl. If build default flavor, more options: NOSDL, SDL1 and SDL2. Why do you have NOSDL (in @default flavor)? The @nosdl flavor would be same, right? But I think would be better if you've three flavor: default (sdl2), sdl1 (sdl1) and nosdl. In this case the structure of Makefile would be simple. 2. The SYSCALL, SYSTEM, and NETWORK options. As I see they don't implies plus dependencies. I think can delete these options and they would be default. Or is there any reason to use them as option? 3. NCURSES_MAKE_ARGS=<empty> - Can be USE_CURSES=yes (or similar)? Would be more clear. And I forgot in my comment: should check "portclippy Makefile" too (part of ports-mgmt/portfmt).
Created attachment 251899 [details] patch for 20231210a > 1. you've two flavors: ... I added three flavors: default(sdl2), nosdl, sdl1. Makefile become very simple, thanks! > 2. The SYSCALL, SYSTEM, and NETWORK options... These options are necessary to varidate system/syscall/network functions. (-DUSE_SYSTEM_FUNCTION -DUSE_SYSCALL_FUNCTION -DUSE_NETWORK_FUNCTION are added in pre-processing) > 3. NCURSES_MAKE_ARGS=<empty> - Can be USE_CURSES=yes... Yes, I do it. > And I forgot in my comment: should check "portclippy Makefile" too... I checked "portfmt -D Makefile" and "portclippy Makefile".
Created attachment 251908 [details] patch for 20231210a I modified the bug to erase MAKE_ARGS.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=e005593992bbe078777522f0e053b5dbc651aa6a commit e005593992bbe078777522f0e053b5dbc651aa6a Author: SAKAI Hiroaki <kozos@kozos.jp> AuthorDate: 2024-07-07 06:15:48 +0000 Commit: Zsolt Udvari <uzsolt@FreeBSD.org> CommitDate: 2024-07-07 06:15:48 +0000 lang/nll: update to 20240703a Convert flavor-specific options to flavor: in the default flavor should choose SDL version (1 or 2). Now SDL versions are flavors. Pet portlint, portclippy, portfmt. PR: 280123 Approved by: submitter is maintainer lang/nll/Makefile | 106 +++++++++++++++++++++++++++--------------------------- lang/nll/distinfo | 6 ++-- 2 files changed, 55 insertions(+), 57 deletions(-)
Committed, thanks!