Bug 280127 - www/caddy typo in files/caddy.in
Summary: www/caddy typo in files/caddy.in
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Adam Weinberger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-04 12:20 UTC by Ludovic Hirlimann
Modified: 2024-12-01 00:38 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (adamw)

Attachments
Patch to fix the issue (478 bytes, text/plain)
2024-07-04 12:20 UTC, Ludovic Hirlimann 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ludovic Hirlimann 2024-07-04 12:20:32 UTC 
Created attachment 251864 [details]
Patch to fix the issue

Instructions says to enable caddy by `service enable caddy` instead of `service caddy enable` breaking copy and pasting.
Comment 1 Yonas Yanfa 2024-11-29 16:30:43 UTC 
Can we get this committed?
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-11-30 22:56:54 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=cc1921f1c1a9b7b080f7ef0797b1367ff1b41e64

commit cc1921f1c1a9b7b080f7ef0797b1367ff1b41e64
Author:     Adam Weinberger <adamw@FreeBSD.org>
AuthorDate: 2024-11-30 22:47:33 +0000
Commit:     Adam Weinberger <adamw@FreeBSD.org>
CommitDate: 2024-11-30 22:55:50 +0000

    www/caddy, www/caddy-custom: Fix rc(8) instructions

    I had 'service enable caddy' instead of 'service caddy enable' in
    caddy.in, because I get it wrong so often that I had to write a
    wrapper service() function in my shell.

    Ludovic submitted a patch for this 5 months ago, but it went into
    the same cerebral black hole as the order of service arguments.

    PR:             280127
    Reported by:    Ludovic Hirlimann

 www/caddy-custom/Makefile       | 2 +-
 www/caddy-custom/files/caddy.in | 2 +-
 www/caddy/Makefile              | 2 +-
 www/caddy/files/caddy.in        | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
Comment 3 Adam Weinberger freebsd_committer freebsd_triage 2024-11-30 23:05:31 UTC 
Thanks for submitting this, and for the reminder. $LIFE happened and this totally fell off my radar.
Comment 4 Yonas Yanfa 2024-12-01 00:38:49 UTC 
Thanks Adam!!