Bug 280135 - security/clamav*: fix filename of the rc script to comply to the rc scripting recommendations
Summary: security/clamav*: fix filename of the rc script to comply to the rc scripting...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Yasuhiro Kimura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-05 08:19 UTC by Alexander Leidinger
Modified: 2024-09-12 04:03 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (yasu)

Attachments
rename clamav rc scripts (2.69 KB, patch)
2024-07-05 08:19 UTC, Alexander Leidinger 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Leidinger freebsd_committer freebsd_triage 2024-07-05 08:19:51 UTC 
Created attachment 251878 [details]
rename clamav rc scripts

Hi,

The attached patch fixes some issues with the rc script.

A generic discussion about the rc scripts in the ports collection which contains a lot more background information about the "why" of this patch is at 
    https://lists.freebsd.org/archives/freebsd-ports/2024-July/006342.html

Short:
 - the filename shall be the same as the content of the name variable inside the script
 - (already OK) PROVIDE shall be the same as the content of the name variable inside the script
 - this fixes the use of the script with service jails (new feature in -current)

Additionally to what is discussed there and fixed in the patch, I made the following additional changes:
 - add an UPATING entry (date needs to be adapted, this may conflict at the time when you apply/commit)

You may want to run the following before applying the patch:
  git mv security/clamav-lts/files/clamav-clamd.in security/clamav-lts/files/clamav_clamd.in
  git mv security/clamav-lts/files/clamav-freshclam.in security/clamav-lts/files/clamav_freshclam.in
  git mv security/clamav-lts/files/clamav-milter.in security/clamav-lts/files/clamav_milter.in
  git mv security/clamav/files/clamav-freshclam.in security/clamav/files/clamav_freshclam.in
  git mv security/clamav/files/clamav-clamd.in security/clamav/files/clamav_clamd.in
  git mv security/clamav/files/clamav-milter.in security/clamav/files/clamav_milter.in

This was run-tested with security/clamav (clamd+freshclam) inside service jails.
  
Bye,
Alexander.
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-09-12 04:01:10 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=36e211c572f8b975ec8852ec394e83005cbd6385

commit 36e211c572f8b975ec8852ec394e83005cbd6385
Author:     Alexander Leidinger <netchild@FreeBSD.org>
AuthorDate: 2024-07-05 08:20:03 +0000
Commit:     Yasuhiro Kimura <yasu@FreeBSD.org>
CommitDate: 2024-09-12 03:59:14 +0000

    security/{clamav,clamav-lts}: Fix filename of the rc script to comply to the rc scripting recommendations

    PR:             280135

 UPDATING                                                | 17 +++++++++++++++++
 security/clamav-lts/Makefile                            |  6 +++---
 .../files/{clamav-clamd.in => clamav_clamd.in}          |  0
 .../files/{clamav-freshclam.in => clamav_freshclam.in}  |  0
 .../files/{clamav-milter.in => clamav_milter.in}        |  0
 security/clamav/Makefile                                |  6 +++---
 .../clamav/files/{clamav-clamd.in => clamav_clamd.in}   |  0
 .../files/{clamav-freshclam.in => clamav_freshclam.in}  |  0
 .../clamav/files/{clamav-milter.in => clamav_milter.in} |  0
 9 files changed, 23 insertions(+), 6 deletions(-)
Comment 2 Yasuhiro Kimura freebsd_committer freebsd_triage 2024-09-12 04:03:58 UTC 
Committed with minor change. Thanks!