Bug 280143 - multimedia/kodi: Fix fallout caused by taglib
Summary: multimedia/kodi: Fix fallout caused by taglib
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Bernhard Froehlich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-05 17:47 UTC by yzrh
Modified: 2024-08-06 08:12 UTC (History)
1 user (show)

See Also:

Attachments
Match taglib's data type (1.65 KB, patch)
2024-07-05 17:47 UTC, yzrh 		no flags Details | Diff
testport log (bzip2), on a 64 bit platform (126.63 KB, application/x-bzip)
2024-07-05 17:49 UTC, yzrh 		no flags Details
Fix data type (3.47 KB, patch)
2024-07-20 21:19 UTC, yzrh 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yzrh 2024-07-05 17:47:58 UTC 
Created attachment 251887 [details]
Match taglib's data type

Taglib has changed some data types in 2.0, making some
platform dependent (size_t).  This breaks Kodi on i386
and perhaps other 32 bit platforms.
Comment 1 yzrh 2024-07-05 17:49:58 UTC 
Created attachment 251888 [details]
testport log (bzip2), on a 64 bit platform
Comment 2 Bernhard Froehlich freebsd_committer freebsd_triage 2024-07-06 08:50:19 UTC 
I'll take it
Comment 3 Bernhard Froehlich freebsd_committer freebsd_triage 2024-07-20 06:23:12 UTC 
Build works on amd64 but still fails on i386. Is this expected?

https://ports.bluelife.at/builds/20240719-19:46:31.98948/
Comment 4 yzrh 2024-07-20 21:19:55 UTC 
Created attachment 252196 [details]
Fix data type

Ah, I forgot the other part.  I really need a 32 bit test environment.
I am not confident without some runtime testing.
Comment 5 Bernhard Froehlich freebsd_committer freebsd_triage 2024-08-05 10:46:56 UTC 
The patch builds fine.

https://ports.bluelife.at/builds/20240804-20:10:49.43982/

Is it okay to commit it or do you want to perform some runtime test first?
Comment 6 yzrh 2024-08-05 14:11:44 UTC 
Let's get it in.  It builds and seems to work.  Thanks again.
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-08-06 08:01:44 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8d205087923f2b58fed8801c2681a41f074c4368

commit 8d205087923f2b58fed8801c2681a41f074c4368
Author:     yzrh <yzrh@noema.org>
AuthorDate: 2024-08-06 07:59:40 +0000
Commit:     Bernhard Froehlich <decke@FreeBSD.org>
CommitDate: 2024-08-06 07:59:40 +0000

    multimedia/kodi: Fix fallout caused by recent taglib update

    PR:             280143
    Submitted by:   yzrh@noema.org (maintainer)

 multimedia/kodi/Makefile                           |  2 +-
 ...patch-xbmc_music_tags_TagLibVFSStream.cpp (new) | 47 ++++++++++++++++++++++
 .../patch-xbmc_music_tags_TagLibVFSStream.h (new)  | 41 +++++++++++++++++++
 3 files changed, 89 insertions(+), 1 deletion(-)
Comment 8 Bernhard Froehlich freebsd_committer freebsd_triage 2024-08-06 08:12:35 UTC 
Committed and merged to quarterly branch. Thanks!
Comment 9 commit-hook freebsd_committer freebsd_triage 2024-08-06 08:12:46 UTC 
A commit in branch 2024Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d6df94a68f4185bb5ffb1116988bc0a6d64b83e5

commit d6df94a68f4185bb5ffb1116988bc0a6d64b83e5
Author:     yzrh <yzrh@noema.org>
AuthorDate: 2024-08-06 07:59:40 +0000
Commit:     Bernhard Froehlich <decke@FreeBSD.org>
CommitDate: 2024-08-06 08:11:14 +0000

    multimedia/kodi: Fix fallout caused by recent taglib update

    PR:             280143
    Submitted by:   yzrh@noema.org (maintainer)

    (cherry picked from commit 8d205087923f2b58fed8801c2681a41f074c4368)

 multimedia/kodi/Makefile                           |  2 +-
 ...patch-xbmc_music_tags_TagLibVFSStream.cpp (new) | 47 ++++++++++++++++++++++
 .../patch-xbmc_music_tags_TagLibVFSStream.h (new)  | 41 +++++++++++++++++++
 3 files changed, 89 insertions(+), 1 deletion(-)