Bug 280176 - lang/go-devel: do not install *.bak files
Summary: lang/go-devel: do not install *.bak files
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Golang Team (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-07 14:06 UTC by Ruslan Makhmatkhanov
Modified: 2024-08-18 14:48 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (go)

Attachments
change sed args (494 bytes, patch)
2024-07-07 14:06 UTC, Ruslan Makhmatkhanov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2024-07-07 14:06:59 UTC 
Created attachment 251919 [details]
change sed args

Right now lang/go1xx installs two *.bak files that are created at post-patch stage in lang/go-devel:

[rm@cf ~]% pkg list go122-1.22.5 | grep bak
/usr/local/go122/src/make.bash.bak
/usr/local/go122/src/run.bash.bak

cange sed args to not create them in first place. It may require t raise PORTREVISION since the resulting package would be changed.
Comment 1 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2024-08-13 15:18:47 UTC 
ping
Comment 2 Mikael Urankar freebsd_committer freebsd_triage 2024-08-16 15:08:24 UTC 
(In reply to Ruslan Makhmatkhanov from comment #1)
It's covered by portmgr blanket approval and maintainer timeout.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-08-18 14:47:16 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3f085995815e56e2d3bc3be8435cd0f8bd2c6463

commit 3f085995815e56e2d3bc3be8435cd0f8bd2c6463
Author:     Ruslan Makhmatkhanov <rm@FreeBSD.org>
AuthorDate: 2024-08-18 14:43:54 +0000
Commit:     Ruslan Makhmatkhanov <rm@FreeBSD.org>
CommitDate: 2024-08-18 14:43:54 +0000

    lang/go* ports: do not package back files

    All the go ports installing *.bak files left after sed calls in
    ports Makefile. Tweak sed calls to not create them in first place
    and bump PORTREVISION to reflect package change.

    PR:             280176
    Approved by:    go (maintainer timeout)

 lang/go-devel/Makefile | 2 ++
 lang/go120/Makefile    | 2 +-
 lang/go121/Makefile    | 2 +-
 lang/go122/Makefile    | 1 +
 4 files changed, 5 insertions(+), 2 deletions(-)