Created attachment 252017 [details] update to 4.5.1 take maintainership add LICENSE_FILE OPTIONS modified
The change of port OPTION is misleading given how we define dependencies and/or functionality in the tree in general (enabled/disabled). Just keep it as it is or rename the option. Are patches upstreamed?
(In reply to Daniel Engberg from comment #1) Do you mean rename LIBPCAP to LIBPCAP_PORTS in the patch?
(In reply to Daniel Engberg from comment #1) https://github.com/appneta/tcpreplay/issues/809#issuecomment-2228382291
I didn't see this PR when I committed a97f9d30a7355d1bccbc1b3cc615571aba81427a, sorry. @vvd: Please feel free to pass maintainership to the submitter.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=e2455c7452a3c677008ca89700ccfc60e30620b0 commit e2455c7452a3c677008ca89700ccfc60e30620b0 Author: mew14930xvi <mew14930xvi@inbox.lv> AuthorDate: 2024-07-16 16:04:33 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2024-07-16 16:12:17 +0000 net-mgmt/tcpreplay: take maintainership, add LICENSE_FILE, OPTIONS modified Also: - replace patch for fix build (upstream issue: https://github.com/appneta/tcpreplay/issues/809); - remake patches with makepatch; - remove GNU_CONFIGURE_MANPREFIX. Version 4.5.1 contains many bug fixes: https://github.com/appneta/tcpreplay/releases/tag/v4.5.1 PR: 280260 Approved by: ehaupt (maintainer) MFH: 2024Q3 net-mgmt/tcpreplay/Makefile | 15 +++++---------- net-mgmt/tcpreplay/files/patch-Makefile.in | 12 ++++++------ net-mgmt/tcpreplay/files/patch-lib_queue.h (gone) | 19 ------------------- .../tcpreplay/files/patch-src_fragroute_mod.c (new) | 15 +++++++++++++++ .../tcpreplay/files/patch-src_fragroute_pkt.h (new) | 13 +++++++++++++ 5 files changed, 39 insertions(+), 35 deletions(-)
A commit in branch 2024Q3 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=0b0fa9adaf9413d2c727c5a3711f6c425d37c0d4 commit 0b0fa9adaf9413d2c727c5a3711f6c425d37c0d4 Author: mew14930xvi <mew14930xvi@inbox.lv> AuthorDate: 2024-07-16 16:04:33 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2024-07-16 16:17:37 +0000 net-mgmt/tcpreplay: take maintainership, add LICENSE_FILE, OPTIONS modified Also: - replace patch for fix build (upstream issue: https://github.com/appneta/tcpreplay/issues/809); - remake patches with makepatch; - remove GNU_CONFIGURE_MANPREFIX. Version 4.5.1 contains many bug fixes: https://github.com/appneta/tcpreplay/releases/tag/v4.5.1 PR: 280260 Approved by: ehaupt (maintainer) MFH: 2024Q3 (cherry picked from commit e2455c7452a3c677008ca89700ccfc60e30620b0) net-mgmt/tcpreplay/Makefile | 15 +++++---------- net-mgmt/tcpreplay/files/patch-Makefile.in | 12 ++++++------ net-mgmt/tcpreplay/files/patch-lib_queue.h (gone) | 19 ------------------- .../tcpreplay/files/patch-src_fragroute_mod.c (new) | 15 +++++++++++++++ .../tcpreplay/files/patch-src_fragroute_pkt.h (new) | 13 +++++++++++++ 5 files changed, 39 insertions(+), 35 deletions(-)
Thanks.
I don't mind not being the maintainer. To be honest, the former maintainers would be more suitable. I do not have a github account so I did not report to upstream. Sorry for the hassle.
(In reply to mew14930xvi from comment #8) Emanuel Haupt already have 305 ports: https://portscout.freebsd.org/index-total.html In the future, you will probably be able to devote more time to this port than he did. :-D
(In reply to Vladimir Druzenko from comment #9) ok. thanks.
(In reply to Vladimir Druzenko from comment #2) Yes