Bug 280279 - news/tin: Modernize port
Summary: news/tin: Modernize port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-14 15:43 UTC by Daniel Engberg
Modified: 2024-07-14 20:58 UTC (History)
0 users

See Also:
kbowling: maintainer-feedback+

Attachments
Patch for tin (6.90 KB, patch)
2024-07-14 15:43 UTC, Daniel Engberg 		no flags Details | Diff
Patch for tin v2 (6.90 KB, patch)
2024-07-14 15:44 UTC, Daniel Engberg 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-07-14 15:43:26 UTC 
Created attachment 252048 [details]
Patch for tin

* PORTVERSION --> DISTVERSION
* Clean up MASTER_SITES and use upstream main site as backup
* Switch to xz release tarball
* Use helpers whenever possible and use USES= localbase:ldflags
* Sort OPTIONS
* Rearrange to closer match Porters Handbook

Poudriere testport OK (14.1-RELEASE amd64)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-07-14 15:44:24 UTC 
Created attachment 252049 [details]
Patch for tin v2

Fix typo
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2024-07-14 15:45:40 UTC 
CONFIGURE_ARGS are sorted as they appear running ./configure --help
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-07-14 18:03:52 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d7d7504d0bd63b96c93f9641c9718a0f7b1dcb2f

commit d7d7504d0bd63b96c93f9641c9718a0f7b1dcb2f
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-07-14 17:53:38 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-07-14 18:03:27 +0000

    news/tin: Improve port

    * Switch from PORTVERSION to DISTVERSION
    * Clean up MASTER_SITES and use upstream main site as backup
    * Switch to xz release tarball
    * Use helpers whenever possible and USES= localbase:ldflags
    * Sort CONFIGURE_ARGS as they're listed when executing
      ./configure --help
    * Sort OPTIONS
    * Rearrange Makefile to closer match Porters Handbook

    PR:             280279
    Reviewed by:    kbowling

 news/tin/Makefile | 138 +++++++++++++++++++++++++++---------------------------
 news/tin/distinfo |   6 +--
 2 files changed, 71 insertions(+), 73 deletions(-)
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2024-07-14 20:58:28 UTC 
Committed, thanks!