Bug 280332 - audio/audacity: update to 3.6.0
Summary: audio/audacity: update to 3.6.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL: https://www.audacityteam.org/blog/aud...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-17 14:08 UTC by Vladimir Druzenko
Modified: 2024-07-19 21:36 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (xxjack12xx)


Attachments
v1 (187.35 KB, patch)
2024-07-18 00:00 UTC, Vladimir Druzenko
no flags Details | Diff
v2 (187.75 KB, patch)
2024-07-18 13:18 UTC, Vladimir Druzenko
vvd: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Druzenko freebsd_committer freebsd_triage 2024-07-17 14:08:48 UTC
Maybe I'll find time later and create a patch.
Comment 1 Jack 2024-07-17 19:04:25 UTC
(In reply to Vladimir Druzenko from comment #0)
same
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2024-07-17 19:29:34 UTC
pkg-plist require update for MANUAL files.
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2024-07-17 22:04:22 UTC
Also option MANUAL doesn't work offline - it try to download during build:
help/DownloadManual.cmake:
file(
   DOWNLOAD
   "https://github.com/audacity/audacity-manual/releases/download/v${VERSION}/audacity-manual-${VERSION}.tar.gz"
   "${DESTINATION}/audacity-manual-${VERSION}.tar.gz"
)
We must fix this.
Comment 4 Jack 2024-07-17 23:47:23 UTC
(In reply to Vladimir Druzenko from comment #3)
Or remove manual option and if users want the manual, they can download it manually?
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2024-07-18 00:00:00 UTC
Created attachment 252134 [details]
v1

Fixed build with MANUAL option in poudriere.

I have questions:
Does the DOCS option install a single README.md file?
If so, then why do we need:
DOCS_BUILD_DEPENDS= docbook-to-man:textproc/docbook-to-man \
                    docbook2man:textproc/docbook-utils
?
Comment 6 Jack 2024-07-18 00:12:05 UTC
I think DOCS and MANUAL were installed together before and now they are split so the DOCS_BUILD_DEPENDS are no longer needed.
Comment 7 Vladimir Druzenko freebsd_committer freebsd_triage 2024-07-18 00:46:36 UTC
Maybe then it would be better to combine these 2 options?
With name DOCS.
Comment 8 Vladimir Druzenko freebsd_committer freebsd_triage 2024-07-18 00:48:28 UTC
BTW, what do you think about:
post-configure-DOCS-on:
        @${MV} ${WRKDIR}/help/manual ${WRKDIR}/.build/help/
?
Comment 9 Jack 2024-07-18 01:14:58 UTC
I'm not sure, I think docs are probably just cli stuff where the manual is acessible from the gui help menu so we should keep them split
Comment 10 Vladimir Druzenko freebsd_committer freebsd_triage 2024-07-18 13:18:11 UTC
Created attachment 252142 [details]
v2

Remove:
DOCS_BUILD_DEPENDS=    docbook-to-man:textproc/docbook-to-man \
                       docbook2man:textproc/docbook-utils
Comment 11 Vladimir Druzenko freebsd_committer freebsd_triage 2024-07-18 13:19:12 UTC
(In reply to Jack from comment #9)
You can install with DOSC, get full list of installed files "pkg info -R audacity" then install without DOCS and compare lists. :-o
Comment 12 Vladimir Druzenko freebsd_committer freebsd_triage 2024-07-19 14:36:18 UTC
Can I commit? Or you are testing work?
Comment 13 Jack 2024-07-19 17:29:43 UTC
I haven't had time to test out the docs but other than that, it looks fine to commit
Comment 14 Vladimir Druzenko freebsd_committer freebsd_triage 2024-07-19 19:15:36 UTC
(In reply to Jack from comment #13)
Just tested: diff is only one file /usr/local/share/doc/audacity/README.md
Comment 15 Jack 2024-07-19 20:50:18 UTC
Comment on attachment 252142 [details]
v2

Just tested, looks good.
Comment 16 commit-hook freebsd_committer freebsd_triage 2024-07-19 21:35:54 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1581ddee8c7ef88f15b09a65853499c2a07364fc

commit 1581ddee8c7ef88f15b09a65853499c2a07364fc
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2024-07-19 21:32:23 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-07-19 21:35:02 +0000

    audio/audacity: update 3.5.1 → 3.6.0

    Changelog:
    https://support.audacityteam.org/additional-resources/changelog/audacity-3.6
    https://www.audacityteam.org/blog/audacity-3-6/

    PR:             280332
    Approved by:    Jack <xxjack12xx@gmail.com> (maintainer)

 audio/audacity/Makefile  |   13 +-
 audio/audacity/distinfo  |    8 +-
 audio/audacity/pkg-plist | 2797 +++++++++++++++++++++++-----------------------
 3 files changed, 1401 insertions(+), 1417 deletions(-)