Bug 280369 - net/openmpi: Update to 5.0.4
Summary: net/openmpi: Update to 5.0.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL: https://docs.open-mpi.org/en/v5.0.x/r...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-19 15:12 UTC by Laurent Chardon
Modified: 2024-07-21 13:47 UTC (History)
2 users (show)

See Also:

Attachments
git patch (3.21 KB, patch)
2024-07-19 15:12 UTC, Laurent Chardon 		laurent.chardon: maintainer-approval+
Details | Diff
git patch 2 (4.24 KB, patch)
2024-07-20 11:34 UTC, Laurent Chardon 		laurent.chardon: maintainer-approval+
Details | Diff
git patch 3 (5.21 KB, patch)
2024-07-21 09:11 UTC, Laurent Chardon 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Chardon 2024-07-19 15:12:59 UTC 
Created attachment 252170 [details]
git patch

net/openmpi: Update to 5.0.4

- Update from 5.0.3 to 5.0.4
- Remove slurm from default options
- Add docs to default options

QA:
portlint:  OK
poudriere: OK
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2024-07-19 17:01:21 UTC 
DOCS is default option in ports framework.
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2024-07-19 19:38:43 UTC 
Warning: you might not need LIB_DEPENDS on libze_loader.so
Is it require libze_loader.so:devel/level-zero?
Build fine without it.
Comment 3 Laurent Chardon 2024-07-20 11:34:42 UTC 
Created attachment 252192 [details]
git patch 2
Comment 4 Laurent Chardon 2024-07-20 11:35:40 UTC 
(In reply to Vladimir Druzenko from comment #2)

Good points. 

- Move level-zero support into a non-default option
  See also Bug 278869
- Remove OPTIONS_DEFAULT that's not needed for DOCS + IPV6
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2024-07-20 22:37:21 UTC 
Why did you remove SLURM from default options?
This option looks like it's useful to users.
Comment 6 Laurent Chardon 2024-07-21 01:02:55 UTC 
(In reply to Vladimir Druzenko from comment #5)

Because it's currently broken. See Bug 279777
Comment 7 Vladimir Druzenko freebsd_committer freebsd_triage 2024-07-21 02:26:00 UTC 
configure: WARNING: unrecognized options: --with-ze

And even more: level-zero used in romio, but --disable-io-romio disable romio: https://github.com/open-mpi/ompi/issues/9715
Comment 8 Laurent Chardon 2024-07-21 09:11:02 UTC 
Created attachment 252201 [details]
git patch 3


You're right that romio mpl is the only place where level zero is used. I couldn't pass on a flag to that configure level, so I removed the level zero dependency in a patch. I documented in the patch why level zero is disabled.

With the patch it's possible to compile romio again, so I re-enabled it. It's now a (default) option, so that someone can disable it if they want.

net/openmpi: Update to 5.0.4

- Update from 5.0.3 to 5.0.4
- Remove slurm from default options
- Reinstate romio in default option
- Remove level-zero dependency

portlint:  OK
poudriere: OK
Comment 9 commit-hook freebsd_committer freebsd_triage 2024-07-21 12:48:32 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ba6bf794a87e4c66dde92b57161e1fc6e58f7af9

commit ba6bf794a87e4c66dde92b57161e1fc6e58f7af9
Author:     Laurent Chardon <laurent.chardon@gmail.com>
AuthorDate: 2024-07-21 12:24:19 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-07-21 12:38:47 +0000

    net/openmpi: update 5.0.3 → 5.0.4

    - Remove slurm from default options
    - Reinstate romio in default option
    - Remove level-zero dependency

    Changelog:
    https://docs.open-mpi.org/en/v5.0.x/release-notes/changelog/v5.0.x.html#open-mpi-version-v5-0-4

    PR:     280369

 net/openmpi/Makefile                               | 53 +++++++++-------------
 net/openmpi/distinfo                               |  6 +--
 .../patch-3rd-party_romio341_mpl_configure (new)   | 12 +++++
 net/openmpi/pkg-plist                              | 12 ++---
 4 files changed, 43 insertions(+), 40 deletions(-)
Comment 10 Vladimir Druzenko freebsd_committer freebsd_triage 2024-07-21 12:59:49 UTC 
Thanks!
Comment 11 Laurent Chardon 2024-07-21 13:47:27 UTC 
(In reply to Vladimir Druzenko from comment #10)

Thanks for the extra pair of eyes and for the commit!