Bug 280429 - textproc/utf8proc: 207abfe1369d1ef1d89fae73b1091b37b9060ef7 removed option to build archive
Summary: textproc/utf8proc: 207abfe1369d1ef1d89fae73b1091b37b9060ef7 removed option to...
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-24 10:05 UTC by Michael Osipov
Modified: 2024-08-15 11:10 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (diizzy)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Osipov freebsd_committer freebsd_triage 2024-07-24 10:05:21 UTC
With 207abfe1369d1ef1d89fae73b1091b37b9060ef7 the archive for libutf8proc is not built anymore with CMake, but devel/subversion{,-lts} require the archive to link into an all static executable. The should be at least an option or CMake needs to be run twice to produce the previous behavior.
Comment 1 Michael Osipov freebsd_committer freebsd_triage 2024-07-24 10:06:15 UTC
Naive fix for testing only:
diff --git a/textproc/utf8proc/Makefile b/textproc/utf8proc/Makefile
index 05bb4bbf8fd4..cc23d0111060 100644
--- a/textproc/utf8proc/Makefile
+++ b/textproc/utf8proc/Makefile
@@ -1,5 +1,6 @@
 PORTNAME=  utf8proc
 DISTVERSION=   2.9.0
+PORTREVISION=  1
 CATEGORIES=    textproc devel
 MASTER_SITES=  https://github.com/JuliaStrings/${PORTNAME}/releases/download/v${DISTVERSION}/

@@ -13,12 +14,10 @@ LICENSE_FILE=   ${WRKSRC}/LICENSE.md
 USES=      cmake
 USE_LDCONFIG=  yes

-CMAKE_ON=  BUILD_SHARED_LIBS
+CMAKE_ON=  BUILD_STATIC_LIBS

 PLIST_FILES=   include/utf8proc.h \
-       lib/libutf8proc.so \
-       lib/libutf8proc.so.3 \
-       lib/libutf8proc.so.3.0.0 \
+       lib/libutf8proc.a \
        libdata/pkgconfig/libutf8proc.pc
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2024-07-24 16:28:27 UTC
Hi,

CMake does not out of the box support building both shared and static libraries in one go and there's no support for it upstream or in our ports tree. I would suggest that the STATIC option is dropped as it's discouraged.

Best regards,
Daniel
Comment 3 Michael Osipov freebsd_committer freebsd_triage 2024-07-24 17:26:11 UTC
(In reply to Daniel Engberg from comment #2)

I know that CMake does not allow both at the same time. While I am inclined to drop STATIC with the Subversion packages, there are tons of other packages providing STATIC and they should go as well for consistency reasons, but that would be hardly justifiable, no?

Non-exhaustive:
$ grep -r --include=*/Makefile* -E -e 'OPTIONS.+STATIC' -l .
./archivers/brotli/Makefile
./archivers/c-blosc/Makefile
./archivers/gtar/Makefile
./astro/sextractor/Makefile
./audio/libmysofa/Makefile
./audio/libsndfile/Makefile
./audio/taglib/Makefile
./audio/wildmidi/Makefile
./benchmarks/bonnie/Makefile
./benchmarks/iperf3/Makefile
./benchmarks/nqueens/Makefile
./cad/gmsh/Makefile
./comms/svxlink/Makefile
./devel/asyncplusplus/Makefile
./devel/ccache-static/Makefile
./devel/ccache/Makefile
./devel/ccache4/Makefile
./devel/fossil/Makefile
./devel/ice37/Makefile
./devel/liborcus/Makefile
./devel/llvm-cheri/Makefile
./devel/llvm-cheriot/Makefile
./devel/llvm-devel/Makefile
./devel/llvm15/Makefile
./devel/llvm16/Makefile
./devel/llvm17/Makefile
./devel/llvm18/Makefile
./devel/omniORB/Makefile
./devel/subversion-lts/Makefile
./devel/subversion-lts/Makefile.common
./devel/subversion/Makefile
./devel/subversion/Makefile.common
./devel/tlsh/Makefile
./dns/c-ares/Makefile
./ftp/curl/Makefile
./graphics/apngasm/Makefile
./graphics/apngdis/Makefile
./lang/crystal/Makefile
./lang/gcc6-aux/Makefile
./lang/zig/Makefile
./lang/zig010/Makefile
./math/frobby/Makefile
./math/gecode/Makefile
./math/metis/Makefile
./math/parmetis/Makefile
./math/xblas/Makefile
./net-mgmt/dhcdrop/Makefile
./net-p2p/xmrig/Makefile
./net/bird2/Makefile
./net/gemserv/Makefile
./net/libsockpp/Makefile
./net/libzmq4/Makefile
./net/openmdns/Makefile
./net/pichi/Makefile
./net/rabbitmq-c/Makefile
./www/aria2/Makefile
./www/libevhtp/Makefile
./www/llhttp/Makefile
./www/mimetex/Makefile
./science/libint/Makefile
./science/libint2/Makefile
./security/dropbear/Makefile
./security/libgcrypt/Makefile
./security/libyubikey/Makefile
./security/pam_yubico/Makefile
./security/silktools/Makefile
./security/snort3/Makefile
./security/tor/Makefile
./security/ykclient/Makefile
./security/ykpers/Makefile
./shells/ast-ksh/Makefile
./shells/bash-completion/Makefile
./shells/bash-static/Makefile
./shells/bash/Makefile
./shells/bashc/Makefile
./shells/ksh/Makefile
./shells/ksh-devel/Makefile
./shells/ksh93/Makefile
./shells/pdksh/Makefile
./shells/zsh/Makefile
./sysutils/busybox/Makefile
./sysutils/cmocka/Makefile
./sysutils/env4801/Makefile
./sysutils/gpart/Makefile
./sysutils/inotify-tools/Makefile
./sysutils/tmux/Makefile
./sysutils/tmux23/Makefile
./textproc/expat2/Makefile
./textproc/libxslt/Makefile
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2024-07-24 18:28:01 UTC
Just drop it, some ports for some specific scenarios but there aren't any policies mandating static libraries and/or binaries. In general I'd say we're dropping more than adding.
Comment 5 Michael Osipov freebsd_committer freebsd_triage 2024-07-25 08:56:35 UTC
(In reply to Daniel Engberg from comment #4)

Please add your opinion to https://reviews.freebsd.org/D46096.
Comment 6 Michael Osipov freebsd_committer freebsd_triage 2024-08-15 11:10:24 UTC
As far as I understood this will not be addressed.