Created attachment 252351 [details] proposed port patch Hi, yesterday I committed some changes to src which cause virtualbox-ose-kmod to fail to compile. The fix is trivial, patch attached.
Is emulators/virtualbox-ose-legacy-kmod affected too?
(In reply to Vladimir Druzenko from comment #1) It is, I'll upload a patch shortly. I also just realized that there's a mistake in the original patch, I'll regenerate that one too.
Created attachment 252354 [details] emulators/virtualbox-ose-kmod patch
Created attachment 252355 [details] emulators/virtualbox-ose-kmod-legacy patch
Here are the two ports patches in git: https://github.com/markjdb/freebsd-ports/commits/main-virtualbox-sleepqueue/ I'm happy to push them myself if they are approved.
I don't think we need port bump. Also patch-src-VBox-Runtime-r0drv-freebsd-sleepqueue-r0drv-freebsd.h contains description (for 1st part) - IMHO better add description for 2nd part too.
(In reply to Vladimir Druzenko from comment #6) > I don't think we need port bump. The handbook says, "PORTREVISION must be increased each time a change is made to the port that changes the generated package in any way." https://docs.freebsd.org/en/books/porters-handbook/makefiles/index.html#makefile-portrevision Maybe the bump is not needed indeed, I don't know. > IMHO better add description for 2nd part too. Why? This is a routine KPI change, there is nothing interesting to document. The comment explaining the existing patch is for something much more subtle.
(In reply to Mark Johnston from comment #7) > The handbook says, "PORTREVISION must be increased each time a change is made to the port that changes the generated package in any way." I don't want to force all users to update their production systems just like that - they are not affected - all releases are not affected. Only the latest CURRENT is affected. And what's more, users can't build it before the patch, which means there is no package. > Why? This is a routine KPI change, there is nothing interesting to document. The comment explaining the existing patch is for something much more subtle. If you don't add it, it will seem like this description applies to this part of the patch too. A short phrase like "changes were made to src 1500022 that cause virtualbox-ose-kmod to not compile" is enough. My english is poor - you can probably formulate a better description. :-)
Created attachment 252357 [details] emulators/virtualbox-ose-kmod patch Updated patch to remove the revision bump and improve patch description.
Created attachment 252358 [details] emulators/virtualbox-ose-kmod-legacy patch Updated patch to remove the revision bump and improve patch description.
Approved.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=53bede4bcb3acee01ef26086c9cb5561fb7a20f1 commit 53bede4bcb3acee01ef26086c9cb5561fb7a20f1 Author: Mark Johnston <markj@FreeBSD.org> AuthorDate: 2024-07-29 13:18:10 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2024-07-29 23:57:11 +0000 emulators/virtualbox-ose-kmod: Catch up with FreeBSD KPI changes After 1500021, kick_proc0() doesn't exist. PR: 280495 Approved by: vvd (maintainer) Reported by: Michael Butler <imb@protected-networks.net> ...untime-r0drv-freebsd-sleepqueue-r0drv-freebsd.h | 35 +++++++++++++++++----- 1 file changed, 27 insertions(+), 8 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=c64a29abe541511b0875d568832d59347830d198 commit c64a29abe541511b0875d568832d59347830d198 Author: Mark Johnston <markj@FreeBSD.org> AuthorDate: 2024-07-29 17:57:13 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2024-07-29 23:57:11 +0000 emulators/virtualbox-ose-kmod-legacy: Catch up with FreeBSD KPI changes After 1500021, kick_proc0() doesn't exist. PR: 280495 Approved by: vvd (maintainer) ...untime-r0drv-freebsd-sleepqueue-r0drv-freebsd.h | 35 +++++++++++++++++----- 1 file changed, 27 insertions(+), 8 deletions(-)
(In reply to Vladimir Druzenko from comment #11) Thanks!
(In reply to Mark Johnston from comment #14) Thank you!