Bug 280532 - www/forgejo: LTS
Summary: www/forgejo: LTS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-31 11:56 UTC by Marko Cupać
Modified: 2024-09-04 21:15 UTC (History)
2 users (show)

See Also:
stb: maintainer-feedback+


Attachments
new port forgejo7 (10.20 KB, patch)
2024-09-04 10:38 UTC, Marko Cupać
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marko Cupać 2024-07-31 11:56:18 UTC
Hi,

according to:

https://forgejo.org/2024-07-release-v8-0/#release-schedule-and-long-term-support

... 7.X is LTS, supported until July of 2025, while newly released 8.0 (which is now also version in ports) will be supported for three months only, the same as the next one, 9.X.

I think it would be useful to have LTS forgejo in ports.

What would be the best way to implement it? Separate port www/forgejo-lts? Or flavor like forgejo@default and forgejo@lts? Something else? Any reasons against it?

Regards,
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2024-07-31 12:13:40 UTC
> What would be the best way to implement it?
Separate port www/forgejo-lts.
Comment 2 Stefan Bethke 2024-07-31 16:41:08 UTC
Looking at the discussions on the Forgejo matrix channel, it appears to me that 7 will only be supported marginally longer than 8.

I would suggest holding off such a second port until Forgejo has stabilized a bit more, and a real LTS release train has been established (for example, with support for at least 24 months).
Comment 3 Stefan Bethke 2024-09-02 10:11:16 UTC
I'm suggesting to close this; as maintainer, I will pick up the LTS question again once Forgejo has LTS releases.
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2024-09-02 11:25:48 UTC
Marko Cupać, if you need version 7.x, you can create a port of www/forgejo7 and become its maintainer.
Comment 5 Stefan Bethke 2024-09-02 15:30:59 UTC
I'm not opposed to having an LTS port, it's just that the discussion on the forge-chat matrix channel clearly indicated that Forgejo 7 will not receive a lot of attention from the dev team. I see that there have been frequent releases, so maybe that discussion is outdated, but given the fast pace of development of Forgejo, I would always recommend to use the latest release.

If you would like to maintain an LTS port, you're welcome to do so. If there are many people who feels this would be valuable, I would consider doing that, but right now my feeling is that most people running Forgejo are more interested in the newest release.
Comment 6 Marko Cupać 2024-09-03 11:15:13 UTC
(In reply to Stefan Bethke from comment #5)

I can't speak for other users, but regarding forgejo I'm refugee from www/gitlab@ce which is maintenance nightmare. Upgrades, or even minor version updates fail quite often.

Forgejo (currently 7 branch) has all the functionality I need. AFAIK general purpose of any LTS is to not get too much attention from dev team, while still getting enough attention from security team (meaning no new features while resolving stability and security issues).

I wouldn't mind tracking latest and shiniest if forgejo upgrades to major versions don't introduce any problems. I guess only time will tell.

I'm newbie to porting, I maintain a few simple ports where bumping revisions in Makefile, `make makesum`-ing and generating new pkg-plist is all it takes.

What do you think of the following: I copy your www/forgejo port from 7.x times, and maintain it by bumping revisions so you can concentrate on latest developments. If I run into problems I can't resolve on my own (eg. new minor version of 7.x does not compile, or it does compile but won't work etc.), I ask you for help.

Thank you in advance,
Comment 7 Stefan Bethke 2024-09-03 13:35:25 UTC
Absolutely, sounds like a great plan!
Comment 8 Vladimir Druzenko freebsd_committer freebsd_triage 2024-09-03 17:39:31 UTC
(In reply to Marko Cupać from comment #6)
You can attach port here and I'll commit it.
Don't forget update it to last release in 7.x and change MAINTAINER.
Comment 9 Marko Cupać 2024-09-04 10:38:22 UTC
Created attachment 253322 [details]
new port forgejo7

Hi,

I have attached patch for new port www/forgejo7.

I took latest www/forgejo before it got upgraded to 8.x and put few changes in Makefile:
 - DISTVERSION 7.0.8
 - me as a MAINTAINER
 - PKGNAMESUFFIX 7

Port built fine in my 14_1:x86:64 jail. Deinstalled www/forgejo (which was at 7.0.4), installed www/forgejo7 (which is at 7.0.8), everything works fine.
Comment 10 Stefan Bethke 2024-09-04 19:44:51 UTC
Comment on attachment 253322 [details]
new port forgejo7

This looks mostly fine, you should remove PKGNAMESUFFIX completely, it's only needed when the port itself is updated without a new Forgejo version.
Comment 11 Vladimir Druzenko freebsd_committer freebsd_triage 2024-09-04 19:48:22 UTC
(In reply to Stefan Bethke from comment #10)
Don't confuse PKGNAMESUFFIX with PORTREVISION.
Comment 12 Stefan Bethke 2024-09-04 19:51:43 UTC
(In reply to Vladimir Druzenko from comment #11)
You are correct, I'm confused. Of course PKGNAMESUFFIX is needed for this port. Sorry for the noise, this looks fine!
Comment 13 commit-hook freebsd_committer freebsd_triage 2024-09-04 21:13:11 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4abb8e753d4635821fa9377fde9433a4d2c5527a

commit 4abb8e753d4635821fa9377fde9433a4d2c5527a
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2024-09-04 20:53:13 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-09-04 21:12:16 +0000

    www/forgejo7: New port forgejo branch 7.x, copy from www/forgejo before update to 8.x

    Copy from www/forgejo after commit be43fb2830c94e23e0d9aa49ef9b982b0ab31e2c
    "update to 7.0.4 (fixes security vulnerabilities)".

    PR:     280532

 www/Makefile                               |  1 +
 www/forgejo7/Makefile (new)                | 87 ++++++++++++++++++++++++++++
 www/forgejo7/distinfo (new)                |  3 +
 www/forgejo7/files/app.ini.sample.in (new) | 93 ++++++++++++++++++++++++++++++
 www/forgejo7/files/forgejo.in (new)        | 65 +++++++++++++++++++++
 www/forgejo7/files/pkg-message.in (new)    | 27 +++++++++
 www/forgejo7/pkg-descr (new)               |  5 ++
 www/forgejo7/pkg-plist (new)               |  8 +++
 8 files changed, 289 insertions(+)
Comment 14 commit-hook freebsd_committer freebsd_triage 2024-09-04 21:13:17 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2aef28e7e64b47a6b35e98fe58bf11a226e4b842

commit 2aef28e7e64b47a6b35e98fe58bf11a226e4b842
Author:     Marko Cupać <marko.cupac@mimar.rs>
AuthorDate: 2024-09-04 21:01:25 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-09-04 21:12:16 +0000

    www/forgejo7: Update 7.0.4 → 7.0.8

    Branch 7.0.x is a kind of LTS - supported until July of 2025:
    https://forgejo.org/2024-07-release-v8-0/#release-schedule-and-long-term-support

    Changelogs:
    https://codeberg.org/forgejo/forgejo/src/branch/forgejo/RELEASE-NOTES.md#7-0-5
    https://codeberg.org/forgejo/forgejo/src/branch/forgejo/RELEASE-NOTES.md#7-0-6
    https://codeberg.org/forgejo/forgejo/milestone/7683
    https://codeberg.org/forgejo/forgejo/milestone/7729

     - Take maintainership.
     - Add CONFLICTS_INSTALL with www/forgejo.

    PR:     280532

 www/forgejo/Makefile  | 2 ++
 www/forgejo7/Makefile | 7 +++++--
 www/forgejo7/distinfo | 6 +++---
 3 files changed, 10 insertions(+), 5 deletions(-)
Comment 15 Vladimir Druzenko freebsd_committer freebsd_triage 2024-09-04 21:15:38 UTC
Thanks!