Created attachment 252536 [details]
Differential between net/samba419 & net/samba420

This is my first stab at getting Samba 4.20.x to run on my FreeBSD NAS machine.  The 0100* patch is a major problem, as some of the code that touches got significantly refactored recently by Samba upstream.  Some notable observations:

- 'reopen_from_procfd' was merged into 'reopen_from_fsp' in commit 32d15770da65:
  https://git.samba.org/?p=samba.git;a=commitdiff;h=32d15770da6562871d93006a2ee383d4f68bc660

- 'struct proc_fd_pattern' was removed, along w/ any code using it and replaced
  w/ hardcoded, Linux-specific /proc strings in commit 9f63fad392f3:
  https://git.samba.org/?p=samba.git;a=commitdiff;h=9f63fad392f3cff34d6a8e318e0427499170c417

- 'sys_proc_fd_path' lost its third 'size' argument due to the previous commit,
  and upstream fixed all instances of this //except// in vfs_freebsd.c.

- Libraries in samba4/private had a name change from lib*-samba4.so to lib*-private-samba.so.

That said, I came up few a few workarounds and also a few kludges (that may or may not offend someone), but, it does compile, start, and you can browse a share and open files.  Try to write to a file, however, and something in tevent goes sideways, crashes the smbd daemon, and Windows will turn around and look at you funny.  So, it's a start, and maybe someone with better debugging skills can figure out what's going on w/ tevent (I haven't exactly learned how to attach GDB to daemons that are started on the fly yet).

FWIW, my 'make config' only consists of these settings:
DOCS, SYSLOG, UTMP, GSSAPI_BUILTIN, & ZEROCONF_NONE

Haven't tested other modes (and really can't; it's just a home NAS, so no ADFS).

This is the stack trace from tevent, btw:
> [2024/08/05 22:27:43.707379,  0] ../../lib/util/fault.c:191(smb_panic_log)
>   ===============================================================
> [2024/08/05 22:27:43.707405,  0] ../../lib/util/fault.c:193(smb_panic_log)
>   PANIC (pid 42285): async open timeout in 4.20.3
> [2024/08/05 22:27:43.708899,  0] ../../lib/util/fault.c:304(log_stack_trace)
>   BACKTRACE: 20 stack frames:
>    #0 0x20c979a5ec7 <log_stack_trace+0x37> at /usr/local/lib/samba4/private/libgenrand-private-samba.so
>    #1 0x20c979a5f9e <smb_panic+0xe> at /usr/local/lib/samba4/private/libgenrand-private-samba.so
>    #2 0x20c8b141bcf <smbd_exit_server+0x1af> at /usr/local/lib/samba4/private/libsmbd-base-private-samba.so
>    #3 0x20c8b141a31 <smbd_exit_server+0x11> at /usr/local/lib/samba4/private/libsmbd-base-private-samba.so
>    #4 0x20c97246bcc <exit_server+0x1c> at /usr/local/lib/samba4/private/libsmbd-shim-private-samba.so
>    #5 0x20c8b0efac0 <delete_all_streams> at /usr/local/lib/samba4/private/libsmbd-base-private-samba.so
>    #6 0x20c9436d08f <tevent_common_invoke_timer_handler+0x18f> at /usr/local/lib/samba4/private/libtevent-private-samba.so
>    #7 0x20c9436d234 <tevent_common_loop_timer_delay+0x94> at /usr/local/lib/samba4/private/libtevent-private-samba.so
>    #8 0x20c9436aa55 <tevent_context_same_loop+0xb15> at /usr/local/lib/samba4/private/libtevent-private-samba.so
>    #9 0x20c943665fa <_tevent_loop_once+0xea> at /usr/local/lib/samba4/private/libtevent-private-samba.so
>    #10 0x20c94366882 <tevent_common_loop_wait+0x32> at /usr/local/lib/samba4/private/libtevent-private-samba.so
>    #11 0x20c8b109c73 <smbd_process+0x793> at /usr/local/lib/samba4/private/libsmbd-base-private-samba.so
>    #12 0x204683f488d <main+0x42ad> at /usr/local/sbin/smbd
>    #13 0x20c9436790e <tevent_common_invoke_fd_handler+0x9e> at /usr/local/lib/samba4/private/libtevent-private-samba.so
>    #14 0x20c9436acd4 <tevent_context_same_loop+0xd94> at /usr/local/lib/samba4/private/libtevent-private-samba.so
>    #15 0x20c943665fa <_tevent_loop_once+0xea> at /usr/local/lib/samba4/private/libtevent-private-samba.so
>    #16 0x20c94366882 <tevent_common_loop_wait+0x32> at /usr/local/lib/samba4/private/libtevent-private-samba.so
>    #17 0x204683f2e3f <main+0x285f> at /usr/local/sbin/smbd
>    #18 0x204683f1acc <main+0x14ec> at /usr/local/sbin/smbd
>    #19 0x20c9977aa6a <__libc_start1+0x12a> at /lib/libc.so.7
> [2024/08/05 22:27:43.709245,  0] ../../source3/lib/dumpcore.c:310(dump_core)
>   unable to change to %N.%P.core
>   refusing to dump core

Last thing I'll add is someone really needs to start upstreaming some of this code.  The commit msg in commit 9f63fad392f3 comes across as a tad flippant towards anything not spelled "Linux", so my worry is if non-Linux code doesn't start moving upstream, the patch maintenance burden is going to get worse, and upstream might be tempted to go all-in on Linux at some point.  Food for thought!

(In reply to Joshua Kinard from comment #1)

Forgot the diffstat:
> Makefile                                                              |   20
> distinfo                                                              |    6
> files/0022-Clean-up-UTMP-handling-code-and-add-FreeBSD-support..patch |   84 -
> files/0025-From-d9b748869a8f4018ebee302aae8246bf29f60309-Mon-Se.patch |   75 -
> files/0027-Add-VFS-module-vfs_freebsd-that-implements-FreeBSD-s.patch |   47
> files/0100-Fix-pathref-handling-for-FreeBSD-13plus.patch              |  485 ---------
> files/0100-Fix-pathref-handling-for-FreeBSD-13plus_samba42x.patch     |  508 ++++++++++
> files/0101-FreeBSD-add-fdescfs-paths-workaround.patch                 |   80 +
> files/0102-FreeBSD-vfs_freebsd-fix-sys_proc_fd_path-args.patch        |   53 +
> pkg-plist                                                             |  238 ++--
> pkg-plist.ad_dc                                                       |   22
> pkg-plist.cluster                                                     |    2
> pkg-plist.python                                                      |    4
> 13 files changed, 878 insertions(+), 746 deletions(-)

(In reply to Joshua Kinard from comment #1)
> - 'sys_proc_fd_path' lost its third 'size' argument due to the previous commit,
>   and upstream fixed all instances of this //except// in vfs_freebsd.c.

Just now realized this isn't upstream's fault.  That module got added by one of the patches in the port.  Derp.

Comment 4 Mateusz Piotrowski 2024-08-16 20:51:42 UTC

Thanks for pushing the porting effort forward, Joshua. I've not got the time to look at the patches yet but I should have some cycles soon.

Also, I'm assigning this issue to the FreeBSD Samba Team for now.

Comment 5 Mateusz Piotrowski 2024-10-16 08:27:14 UTC

It seems like Samba 4.20 is already available in TrueNAS. Perhaps we could take a look at the commit log to figure out what's needed to get it building in the FreeBSD ports.

https://github.com/truenas/samba

Thanks to mikael@ for the idea!

(In reply to Mateusz Piotrowski from comment #5)

Was it confirmed that TrueNAS has ported Samba 4.20.5 to its cut of FreeBSD 13.x, which I believe they now call TrueNAS CORE?  The tip of their git there is for TrueNAS SCALE, which I believe is their Linux-based release series now.

FWIW, I've been giving porting the existing patches another go to Samba 4.21.x, but I am running into the same problem w/ 4.20.x, where browsing, and executing all work, but creating a new file, and I assume saving, still crash the child smbd processes.  I did find and correct a number of bugs in my first attempt at the patches, especially the change to using the changed 'sys_proc_fd_path()' function, which now takes two args instead of three, and the second arg is now a struct type instead of a char buffer (the struct itself just has one member, a char buffer).

Having a hard time actually debugging smbd because gdb doesn't seem to like following child threads really well, and attaching to a spawned child thread when creating a new file hangs the smbd process up.  I can only seem to get reliable backtraces out of the parent process.  Going to try a dtrace probe later on that hopefully mimics Linux's ltrace to see if I can get a function name where things die so I can continue debugging (especially if it's a function touched by one of the patches I've mangled).

I'll post an updated patchset in a few days, regardless if I can get file creation to work.  Maybe someone else can spot the problem...

Comment 7 John Hixson 2024-12-07 02:19:06 UTC

Howdy,

I was recently made aware of this bug so I'm following up. I'd be happy to create a samba 4.20 port and maintain it if y'all are okay with that. I've got time this month to commit to it.

Comment 8 John Hixson 2024-12-08 01:54:29 UTC

I've got a samba421 port nearly ready to go. Going to do some testing and some other port cleanup, but I think it's in good shape.

Comment 9 John Hixson 2024-12-08 23:04:19 UTC

Hah! I spoke too soon. I suppose I should have actually read this bug ;-) Everything is ported over with the exception of the 0100-Fix-pathref-handling-for-FreeBSD-13plus.patch patch. I'm currently wrapping my head around this issue so that I can get this fixed. I will post an update once I'm there.

Comment 10 Mateusz Piotrowski 2024-12-12 15:51:19 UTC

(In reply to John Hixson from comment #8)
Hey John, thanks a lot for the update! Just to be clear, are you working on 4.20 or 4.21?

Comment 11 John Hixson 2024-12-13 00:30:57 UTC

(In reply to Mateusz Piotrowski from comment #10)

I am working on 4.21.

Comment 12 Michael Osipov 2024-12-20 12:06:53 UTC

Please note that there is https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281262 now...

Comment 13 Mateusz Piotrowski 2025-01-03 19:59:50 UTC

(In reply to John Hixson from comment #11)
Great! Thank you for the effort.

Any update on 4.20/4.21 samba build on FreeBSD 13.*, 
I would like to work at the samba side of the things as per the need.

Thanks.

Comment 15 Xavier Beaudouin 2025-01-21 14:42:07 UTC

Seem the current proposed patch fails on :
===>  Applying extra patch /usr/home/kiwi/klara-ports/net/samba420/files/0028-s3-lib-system-add-FreeBSD-proc_fd_pattern.patch with -p1
No such line 1093 in input file, ignoring
1 out of 1 hunks failed--saving rejects to source3/lib/system.c.rej
===>  FAILED Applying extra patch /usr/home/kiwi/klara-ports/net/samba420/files/0028-s3-lib-system-add-FreeBSD-proc_fd_pattern.patch with -p1
*** Error code 1

Does someone have this on some git we can work on it ?

Comment 16 Xavier Beaudouin 2025-01-23 07:53:51 UTC

(In reply to Xavier Beaudouin from comment #15)
I have fixed this part, now comming the issues with tdb, ldb...

Comment 17 Xavier Beaudouin 2025-01-23 15:27:05 UTC

Currently having something almost ready to test. Will need 4 new ports before

Comment 18 Mateusz Piotrowski 2025-01-27 18:09:25 UTC

I'm adding links to open reviews for patches adding Samba 4.20 dependencies which we do not have in the ports tree yet.

Comment 19 Michael Osipov 2025-01-27 18:13:40 UTC

(In reply to Mateusz Piotrowski from comment #18)
Do they apply to 4.21 as well?

Comment 20 Mateusz Piotrowski 2025-01-27 18:58:43 UTC

(In reply to Michael Osipov from comment #19)
I don't know, but I'd guess that Samba 4.21 requires even newer versions than 4.20.

Comment 21 Michael Osipov 2025-01-27 18:59:47 UTC

(In reply to Mateusz Piotrowski from comment #20)

This leads me back to my previous question: There is a PR for 4.21, maybe this one should be ditched for 4.21 directly?

Comment 22 Xavier Beaudouin 2025-01-28 10:30:59 UTC

Good news !
I have a port ready to land into port tree, I will push into the port tree today.

We still have time before next quartely so we can fix bugs if we spot some of them.

Kind regards

Comment 23 commit-hook 2025-01-30 14:44:39 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=29ed90005111c56cccb126f4edba998c0a90f5d6

commit 29ed90005111c56cccb126f4edba998c0a90f5d6
Author:     Xavier Beaudouin <kiwi@FreeBSD.org>
AuthorDate: 2025-01-28 10:16:31 +0000
Commit:     Xavier Beaudouin <kiwi@FreeBSD.org>
CommitDate: 2025-01-30 14:42:00 +0000

    Mk: Add Samba 4.20

    Add Samba 4.20 to Uses/samba.mk and bsd.default-versions.mk.

    PR:             280533
    Approved by:    samba (0mp, kiwi)
    Sponsored by:   Klara, Inc.
    Co-authored-by: Mateusz Piotrowski <0mp@FreeBSD.org>

 Mk/Uses/samba.mk           | 4 +++-
 Mk/bsd.default-versions.mk | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

Comment 24 commit-hook 2025-01-30 14:44:42 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=17ce87864be8150900baa87af7d175c53a906ed9

commit 17ce87864be8150900baa87af7d175c53a906ed9
Author:     Joshua Kinard <freebsd@kumba.dev>
AuthorDate: 2025-01-28 10:07:16 +0000
Commit:     Xavier Beaudouin <kiwi@FreeBSD.org>
CommitDate: 2025-01-30 14:42:00 +0000

    net/samba420: Update 4.20

    Changelog:      https://wiki.samba.org/index.php/Release_Planning_for_Samba_4.20

    PR:             280533
    Sponsored by:   Klara, Inc.
    Approved by:    0mp (mentor)
    Approved by:    samba (0mp, kiwi)
    Co-authored-by: Xavier Beaudouin <kiwi@FreeBSD.org>

 net/Makefile                                       |   1 +
 net/samba420/Makefile                              |  27 +-
 net/samba420/distinfo                              |   6 +-
 ...MP-handling-code-and-add-FreeBSD-support..patch |  84 ++--
 ...869a8f4018ebee302aae8246bf29f60309-Mon-Se.patch |  75 ++-
 ...ule-vfs_freebsd-that-implements-FreeBSD-s.patch |  47 +-
 ...s3-lib-system-add-FreeBSD-proc_fd_pattern.patch | 100 ++--
 ...athref-handling-for-FreeBSD-13plus.patch (gone) | 182 --------
 ...andling-for-FreeBSD-13plus_samba42x.patch (new) | 508 +++++++++++++++++++++
 ...reeBSD-add-fdescfs-paths-workaround.patch (new) |  71 +++
 ...s_freebsd-fix-sys_proc_fd_path-args.patch (new) |  53 +++
 net/samba420/pkg-plist                             | 243 +++++-----
 net/samba420/pkg-plist.ad_dc                       |  22 +-
 net/samba420/pkg-plist.cluster                     |   2 +-
 net/samba420/pkg-plist.python                      |   7 +-
 15 files changed, 913 insertions(+), 515 deletions(-)

Comment 25 commit-hook 2025-01-30 14:44:44 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8736a24d16ec753dd6034baa14724e51b6d25081

commit 8736a24d16ec753dd6034baa14724e51b6d25081
Author:     Xavier Beaudouin <kiwi@FreeBSD.org>
AuthorDate: 2025-01-28 09:56:40 +0000
Commit:     Xavier Beaudouin <kiwi@FreeBSD.org>
CommitDate: 2025-01-30 14:42:00 +0000

    net/samba420: Repocopy from net/samba419

    PR:             280533
    Sponsored by:   Klara, Inc.
    Approved by:    0mp (mentor)
    Approved by:    samba (0mp, kiwi)

 net/samba420/Makefile (new)                        |   705 +
 net/samba420/distinfo (new)                        |     3 +
 ...ify-modules-build-and-config-genera.patch (new) |   292 +
 ...-script-to-run-under-FreeBSD-with-i.patch (new) |    35 +
 ...prototype-warnings-in-kadm5-admin.h.patch (new) |    32 +
 ...-has-different-semantics-than-on-Li.patch (new) |    38 +
 ...jemalloc.h-if-ENABLE_JEMALLOC-is-se.patch (new) |    26 +
 ...ss_-modules-into-PAMMODULESDIR-path.patch (new) |    32 +
 ...s-a-default-backlog-size-for-the-li.patch (new) |   105 +
 ...around-usage-of-Linux-specific-m-fl.patch (new) |   111 +
 ...nfig-checks-fail-if-the-warning-is-.patch (new) |    39 +
 ...kgconfigdir-to-specify-alternative-.patch (new) |    54 +
 ...by-port-location-of-the-XML-catalog.patch (new) |    28 +
 ...raries-according-to-the-FreeBSD-spe.patch (new) |    29 +
 ...sg-parameter-to-CHECK_LIB-so-it-can.patch (new) |    70 +
 ...able-CTDB-tests-failing-on-FreeBSD-.patch (new) |    77 +
 ...-class-to-trck-down-DB-locking-code.patch (new) |   132 +
 ...ttribute_compare-a-stable-comparisi.patch (new) |    29 +
 ...en-available-to-generate-random-tal.patch (new) |    49 +
 ...-option-that-allows-to-choose-alter.patch (new) |    65 +
 ...0b920e60e14846987ae1d2d7dca4-Mon-Se.patch (new) |   544 +
 ...n-r336017-and-r342928-wrongfuly-ret.patch (new) |    35 +
 ...ings-in-the-nfs_quota-debug-message.patch (new) |    36 +
 ...dling-code-and-add-FreeBSD-support..patch (new) |   340 +
 ...-test-function-into-vfstest-to-test.patch (new) |   121 +
 ...-provisioning-code-by-iXsystems-Inc.patch (new) |   367 +
 ...4018ebee302aae8246bf29f60309-Mon-Se.patch (new) |   101 +
 ...bility-option-to-the-vfs_streams_xa.patch (new) |   335 +
 ...s_freebsd-that-implements-FreeBSD-s.patch (new) |   932 ++
 .../0028-Fix-rl_completion_func_t.patch (new)      |    32 +
 ...-system-add-FreeBSD-proc_fd_pattern.patch (new) |   149 +
 ...fsacl-fix-get-set-ACL-on-FreeBSD-13.patch (new) |   164 +
 ...pathref-handling-for-FreeBSD-13plus.patch (new) |   182 +
 net/samba420/files/README.FreeBSD.in (new)         |    94 +
 net/samba420/files/man/ctdb-script.options.5 (new) |   558 +
 net/samba420/files/man/ctdb-statistics.7 (new)     |   550 +
 net/samba420/files/man/ctdb-tunables.7 (new)       |   406 +
 net/samba420/files/man/ctdb.1 (new)                |  1526 ++
 net/samba420/files/man/ctdb.7 (new)                |   783 ++
 net/samba420/files/man/ctdb.conf.5 (new)           |   359 +
 net/samba420/files/man/ctdb.sysconfig.5 (new)      |   139 +
 net/samba420/files/man/ctdb_diagnostics.1 (new)    |    79 +
 net/samba420/files/man/ctdbd.1 (new)               |    83 +
 net/samba420/files/man/ctdbd_wrapper.1 (new)       |    63 +
 net/samba420/files/man/dbwrap_tool.1 (new)         |   329 +
 net/samba420/files/man/gentest.1 (new)             |   133 +
 net/samba420/files/man/ldb.3 (new)                 |   427 +
 net/samba420/files/man/ldbadd.1 (new)              |    78 +
 net/samba420/files/man/ldbdel.1 (new)              |    80 +
 net/samba420/files/man/ldbedit.1 (new)             |   111 +
 net/samba420/files/man/ldbmodify.1 (new)           |    73 +
 net/samba420/files/man/ldbrename.1 (new)           |    81 +
 net/samba420/files/man/ldbsearch.1 (new)           |    91 +
 net/samba420/files/man/libsmbclient.7 (new)        |    94 +
 net/samba420/files/man/lmhosts.5 (new)             |   123 +
 net/samba420/files/man/locktest.1 (new)            |   137 +
 net/samba420/files/man/log2pcap.1 (new)            |   124 +
 net/samba420/files/man/ltdbtool.1 (new)            |   256 +
 net/samba420/files/man/masktest.1 (new)            |   113 +
 net/samba420/files/man/mdfind.1 (new)              |   166 +
 net/samba420/files/man/mdsearch.1 (new)            |   357 +
 net/samba420/files/man/mvxattr.1 (new)             |    84 +
 net/samba420/files/man/ndrdump.1 (new)             |    84 +
 net/samba420/files/man/nmblookup.1 (new)           |   341 +
 net/samba420/files/man/nmblookup4.1 (new)          |   157 +
 net/samba420/files/man/ntlm_auth.1 (new)           |   458 +
 net/samba420/files/man/ntlm_auth4.1 (new)          |   233 +
 net/samba420/files/man/oLschema2ldif.1 (new)       |    74 +
 net/samba420/files/man/onnode.1 (new)              |   218 +
 net/samba420/files/man/pam_winbind.conf.5 (new)    |   161 +
 net/samba420/files/man/ping_pong.1 (new)           |   122 +
 net/samba420/files/man/profiles.1 (new)            |   136 +
 net/samba420/files/man/regdiff.1 (new)             |    87 +
 net/samba420/files/man/regpatch.1 (new)            |    81 +
 net/samba420/files/man/regshell.1 (new)            |   177 +
 net/samba420/files/man/regtree.1 (new)             |    89 +
 net/samba420/files/man/rpcclient.1 (new)           |  1961 +++
 net/samba420/files/man/samba-gpupdate.8 (new)      |   122 +
 net/samba420/files/man/samba.7 (new)               |   254 +
 net/samba420/files/man/sharesec.1 (new)            |   364 +
 net/samba420/files/man/smb.conf.5 (new)            | 13994 +++++++++++++++++++
 net/samba420/files/man/smbcacls.1 (new)            |  1044 ++
 net/samba420/files/man/smbclient.1 (new)           |  1253 ++
 net/samba420/files/man/smbcontrol.1 (new)          |   343 +
 net/samba420/files/man/smbcquotas.1 (new)          |   440 +
 net/samba420/files/man/smbget.1 (new)              |   197 +
 net/samba420/files/man/smbgetrc.5 (new)            |   100 +
 net/samba420/files/man/smbpasswd.5 (new)           |   175 +
 net/samba420/files/man/smbstatus.1 (new)           |   186 +
 net/samba420/files/man/smbtar.1 (new)              |   163 +
 net/samba420/files/man/smbtorture.1 (new)          |   362 +
 net/samba420/files/man/smbtree.1 (new)             |   252 +
 net/samba420/files/man/talloc.3 (new)              |   683 +
 net/samba420/files/man/tdbbackup.8 (new)           |   129 +
 net/samba420/files/man/tdbdump.8 (new)             |    72 +
 net/samba420/files/man/tdbrestore.8 (new)          |    54 +
 net/samba420/files/man/tdbtool.8 (new)             |   170 +
 net/samba420/files/man/testparm.1 (new)            |   194 +
 net/samba420/files/man/traffic_learner.7 (new)     |   128 +
 net/samba420/files/man/traffic_replay.7 (new)      |   380 +
 net/samba420/files/man/vfs_freebsd.8 (new)         |   204 +
 net/samba420/files/man/wbinfo.1 (new)              |   490 +
 .../files/patch-examples_pdb_wscript__build (new)  |    11 +
 net/samba420/files/patch-lib_ldb_wscript (new)     |    61 +
 net/samba420/files/patch-lib_talloc_wscript (new)  |    11 +
 .../files/patch-lib_util_wscript__build (new)      |    11 +
 net/samba420/files/patch-source3_lib_util.c (new)  |    14 +
 .../files/patch-source3_librpc_crypto_gse.c (new)  |    16 +
 ...source3_modules_vfs__virusfilter__utils.c (new) |    36 +
 ...tch-source3_registry_tests_test__regfio.c (new) |    10 +
 .../patch-source3_winbindd_wscript__build (new)    |    11 +
 .../files/patch-source3_wscript__build (new)       |    44 +
 net/samba420/files/pkg-message.in (new)            |    31 +
 net/samba420/files/samba_server.in (new)           |   253 +
 net/samba420/pkg-descr (new)                       |     6 +
 net/samba420/pkg-plist (new)                       |   467 +
 net/samba420/pkg-plist.ad_dc (new)                 |   180 +
 net/samba420/pkg-plist.cluster (new)               |    76 +
 net/samba420/pkg-plist.python (new)                |   508 +
 119 files changed, 40664 insertions(+)

Comment 26 commit-hook 2025-01-30 14:44:46 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=af6e6829b3d3acca6d1a12ce8ca994c7b39336e8

commit af6e6829b3d3acca6d1a12ce8ca994c7b39336e8
Author:     Xavier Beaudouin <kiwi@FreeBSD.org>
AuthorDate: 2025-01-28 09:48:04 +0000
Commit:     Xavier Beaudouin <kiwi@FreeBSD.org>
CommitDate: 2025-01-30 14:41:59 +0000

    devel/tevent016: Update to 0.16.1

    Also hook it to the build.

    PR:             280533
    Sponsored by:   Klara, Inc.
    Approved by:    0mp (mentor)
    Approved by:    samba (0mp, kiwi)
    Differential Revision:  https://reviews.freebsd.org/D48658

 devel/Makefile           | 1 +
 devel/tevent016/Makefile | 6 +++---
 devel/tevent016/distinfo | 6 +++---
 3 files changed, 7 insertions(+), 6 deletions(-)

Comment 27 commit-hook 2025-01-30 14:44:48 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=00b64ce160e6b4f2dc878bb27640ded614b4c7a9

commit 00b64ce160e6b4f2dc878bb27640ded614b4c7a9
Author:     Xavier Beaudouin <kiwi@FreeBSD.org>
AuthorDate: 2025-01-28 09:19:34 +0000
Commit:     Xavier Beaudouin <kiwi@FreeBSD.org>
CommitDate: 2025-01-30 14:41:57 +0000

    database/ldb29: LDAP-Like embedded database

    ldb is a LDAP-like embedded database.

    ldb provides a fast database with an LDAP-like API designed to be used
    within an application.

    In some ways it can be seen as a intermediate solution between key-value
    pair databases and a real LDAP database.

    This port is needed for Samba 4.20.

    This commit is just a repocopy. I will update the port to the correct
    version and connect it to the build in the next commit.

    PR:             280533
    Sponsored by:   Klara, Inc.
    Approved by:    0mp (mentor)
    Approved by:    samba (0mp, kiwi)
    Differential Revision:  https://reviews.freebsd.org/D48656

 databases/ldb29/Makefile (new)                     | 146 +++++++
 databases/ldb29/distinfo (new)                     |   3 +
 databases/ldb29/files/man/ldb.3 (new)              | 427 +++++++++++++++++++++
 databases/ldb29/files/man/ldbadd.1 (new)           |  78 ++++
 databases/ldb29/files/man/ldbdel.1 (new)           |  80 ++++
 databases/ldb29/files/man/ldbedit.1 (new)          | 111 ++++++
 databases/ldb29/files/man/ldbmodify.1 (new)        |  73 ++++
 databases/ldb29/files/man/ldbrename.1 (new)        |  81 ++++
 databases/ldb29/files/man/ldbsearch.1 (new)        |  91 +++++
 ...ch-buildtools_wafsamba_samba__autoconf.py (new) |  50 +++
 ...tch-buildtools_wafsamba_samba__install.py (new) |  11 +
 .../files/patch-buildtools_wafsamba_wscript (new)  |  22 ++
 .../ldb29/files/patch-include_ldb__module.h (new)  |  15 +
 .../patch-ldb_key_value__ldb_kv_cache.c (new)      |  13 +
 .../ldb29/files/patch-lib_replace_replace.c (new)  |  20 +
 .../ldb29/files/patch-lib_replace_wscript (new)    |  11 +
 databases/ldb29/files/patch-wscript (new)          |  40 ++
 databases/ldb29/pkg-descr (new)                    |   7 +
 18 files changed, 1279 insertions(+)

Comment 28 commit-hook 2025-01-30 14:44:50 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ee2f3dc4d8777c5af399cc73803b51d832ab5bf4

commit ee2f3dc4d8777c5af399cc73803b51d832ab5bf4
Author:     Xavier Beaudouin <kiwi@FreeBSD.org>
AuthorDate: 2025-01-28 09:05:24 +0000
Commit:     Xavier Beaudouin <kiwi@FreeBSD.org>
CommitDate: 2025-01-30 14:41:57 +0000

    databases/tdb1410: Update to 1.4.10

    Also hook it to the build.

    PR:             280533
    Sponsored by:   Klara, Inc.
    Approved by:    0mp (mentor)
    Approved by:    samba (0mp, kiwi)
    Differential Revision:  https://reviews.freebsd.org/D48655

 databases/Makefile         | 1 +
 databases/tdb1410/Makefile | 2 +-
 databases/tdb1410/distinfo | 6 +++---
 3 files changed, 5 insertions(+), 4 deletions(-)

Comment 29 commit-hook 2025-01-30 14:44:52 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=88f648d07d3c059903aee189b7e0703c37a7d04d

commit 88f648d07d3c059903aee189b7e0703c37a7d04d
Author:     Xavier Beaudouin <kiwi@FreeBSD.org>
AuthorDate: 2025-01-28 09:39:01 +0000
Commit:     Xavier Beaudouin <kiwi@FreeBSD.org>
CommitDate: 2025-01-30 14:41:59 +0000

    devel/tevent016: Talloc based event loop library

    tevent is a simple library that can handle the main event loop for an
    application. It supports three kinds of events: timed events, file
    descriptors becoming readable or writable and signals.

    Talloc is used for memory management, both internally and for private
    data provided by users of the library.

    This port is needed for Samba 4.20

    This commit is just a repocopy. I will update the port to the correct
    version and connect it to the build in the next commit.

    PR:             280533
    Sponsored by:   Klara, Inc.
    Approved by:    0mp (mentor)
    Approved by:    samba (0mp, kiwi)
    Differential Revision:  https://reviews.freebsd.org/D48658

 devel/tevent016/Makefile (new)                     | 75 ++++++++++++++++++++++
 devel/tevent016/distinfo (new)                     |  3 +
 ...ch-buildtools_wafsamba_samba__autoconf.py (new) | 35 ++++++++++
 ...tch-buildtools_wafsamba_samba__install.py (new) | 11 ++++
 .../files/patch-buildtools_wafsamba_wscript (new)  | 15 +++++
 .../files/patch-lib_replace_wscript (new)          | 11 ++++
 devel/tevent016/files/patch-wscript (new)          | 11 ++++
 devel/tevent016/pkg-descr (new)                    |  6 ++
 devel/tevent016/pkg-plist (new)                    |  7 ++
 9 files changed, 174 insertions(+)

Comment 30 commit-hook 2025-01-30 14:44:54 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=cc1cc2ba1a7c7e9449130b9fc24b144e641e0e09

commit cc1cc2ba1a7c7e9449130b9fc24b144e641e0e09
Author:     Xavier Beaudouin <kiwi@FreeBSD.org>
AuthorDate: 2025-01-28 09:36:32 +0000
Commit:     Xavier Beaudouin <kiwi@FreeBSD.org>
CommitDate: 2025-01-30 14:41:59 +0000

    devel/talloc242: Update to 2.4.2

    Also hook it to the build.

    PR:             280533
    Sponsored by:   Klara, Inc.
    Approved by:    0mp (mentor)
    Approved by:    samba (0mp, kiwi)
    Differential Revision:  https://reviews.freebsd.org/D48657

 devel/Makefile           | 1 +
 devel/talloc242/Makefile | 2 +-
 devel/talloc242/distinfo | 6 +++---
 3 files changed, 5 insertions(+), 4 deletions(-)

Comment 31 commit-hook 2025-01-30 14:44:56 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9b1dcbb8c6ad29778807e16c6225e634d059e6b9

commit 9b1dcbb8c6ad29778807e16c6225e634d059e6b9
Author:     Xavier Beaudouin <kiwi@FreeBSD.org>
AuthorDate: 2025-01-28 09:32:36 +0000
Commit:     Xavier Beaudouin <kiwi@FreeBSD.org>
CommitDate: 2025-01-30 14:41:58 +0000

    devel/talloc242: Hierarchical pool based memory allocator

    A hierarchical pool based memory allocator with destructors. It uses
    reference counting to determine when memory should be freed.

    This port is needed for Samba 4.20

    This commit is just a repocopy. I will update the port to the correct
    version and connect it to the build in the next commit.

    PR:             280533
    Sponsored by:   Klara, Inc.
    Approved by:    0mp (mentor)
    Approved by:    samba (0mp, kiwi)
    Differential Revision:  https://reviews.freebsd.org/D48657

 devel/talloc242/Makefile (new)                     |  71 +++
 devel/talloc242/distinfo (new)                     |   3 +
 ...ch-buildtools_wafsamba_samba__autoconf.py (new) |  35 ++
 ...tch-buildtools_wafsamba_samba__install.py (new) |  11 +
 .../files/patch-buildtools_wafsamba_wscript (new)  |  15 +
 .../files/patch-lib_replace_wscript (new)          |  11 +
 devel/talloc242/files/patch-talloc.c (new)         |  20 +
 devel/talloc242/files/patch-wscript (new)          |  18 +
 devel/talloc242/files/talloc.3 (new)               | 677 +++++++++++++++++++++
 devel/talloc242/pkg-descr (new)                    |   2 +
 devel/talloc242/pkg-plist (new)                    |  10 +
 11 files changed, 873 insertions(+)

Comment 32 commit-hook 2025-01-30 14:44:58 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=297bf657af8b6e454a8f42c66a273d9824e1dafd

commit 297bf657af8b6e454a8f42c66a273d9824e1dafd
Author:     Xavier Beaudouin <kiwi@FreeBSD.org>
AuthorDate: 2025-01-28 08:57:36 +0000
Commit:     Xavier Beaudouin <kiwi@FreeBSD.org>
CommitDate: 2025-01-30 14:41:56 +0000

    databases/tdb1410: Trivial Database for Samba 4.20

    TDB is a Trivial Database. In concept, it is very much like GDBM, and
    BSD's DB except that it allows multiple simultaneous writers and uses
    locking internally to keep writers from trampling on each other. TDB is
    also extremely small.

    This port is need for the Samba 4.20.

    Repo copy of databases/tdb, I will commit update to 1.4.10 in next
    commit.

    PR:             280533
    Sponsored by:   Klara, Inc.
    Approved by:    0mp (mentor)
    Approved by:    samba (0mp, kiwi)

 databases/tdb1410/Makefile (new)                   |  73 +++++++++
 databases/tdb1410/distinfo (new)                   |   3 +
 ...ch-buildtools_wafsamba_samba__autoconf.py (new) |  35 +++++
 ...tch-buildtools_wafsamba_samba__install.py (new) |  11 ++
 .../files/patch-buildtools_wafsamba_wscript (new)  |  15 ++
 .../tdb1410/files/patch-lib_replace_wscript (new)  |  11 ++
 databases/tdb1410/files/patch-wscript (new)        |  11 ++
 databases/tdb1410/files/tdbbackup.8 (new)          | 129 ++++++++++++++++
 databases/tdb1410/files/tdbdump.8 (new)            |  72 +++++++++
 databases/tdb1410/files/tdbrestore.8 (new)         |  54 +++++++
 databases/tdb1410/files/tdbtool.8 (new)            | 170 +++++++++++++++++++++
 databases/tdb1410/pkg-descr (new)                  |   4 +
 databases/tdb1410/pkg-plist (new)                  |  14 ++
 13 files changed, 602 insertions(+)

Comment 33 commit-hook 2025-01-30 14:45:00 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7edf338be26071678aff562c543da1530eb6ab8f

commit 7edf338be26071678aff562c543da1530eb6ab8f
Author:     Xavier Beaudouin <kiwi@FreeBSD.org>
AuthorDate: 2025-01-28 09:26:39 +0000
Commit:     Xavier Beaudouin <kiwi@FreeBSD.org>
CommitDate: 2025-01-30 14:41:58 +0000

    databases/ldb29: Update to 2.9.2

    Also hook it to build.

    PR:             280533
    Sponsored by:   Klara, Inc.
    Approved by:    0mp (mentor)
    Approved by:    samba (0mp, kiwi)
    Differential Revision:  https://reviews.freebsd.org/D48656

 databases/Makefile       | 1 +
 databases/ldb29/Makefile | 6 +++---
 databases/ldb29/distinfo | 6 +++---
 3 files changed, 7 insertions(+), 6 deletions(-)

Comment 34 Xavier Beaudouin 2025-01-30 15:48:43 UTC

Port (and related ports) has been committed. Thanks !

Comment 35 Michael Osipov 2025-01-30 15:49:40 UTC

I will try to test the work in our AD setup in the next couple of weeks. Thanks for the effort.

Comment 36 Mateusz Piotrowski 2025-01-30 16:39:35 UTC

(In reply to Michael Osipov from comment #35)

Thank you, Michael!

Hi,

did anybody find what to do with

PANIC (pid 42285): async open timeout in 4.20.3

I see this panic often.

Comment 38 Mateusz Piotrowski 2025-02-06 17:23:10 UTC

(In reply to Denis Shaposhnikov from comment #37)

Let's open a new PR for that so that it easier to track. Could you do that?

(In reply to Mateusz Piotrowski from comment #38)
> Let's open a new PR for that so that it easier to track. Could you do that?

Created https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=284623

Comment 40 Mateusz Piotrowski 2025-02-06 19:10:08 UTC

(In reply to Denis Shaposhnikov from comment #39)
Thanks!