Bug 280581 - multimedia/plexmediaserver-plexpass: Update to 1.40.5.8796
Summary: multimedia/plexmediaserver-plexpass: Update to 1.40.5.8796
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL: https://forums.plex.tv/t/plex-media-s...
Keywords: easy
Depends on:
Blocks:
 
Reported: 2024-08-02 22:51 UTC by Ben Shertenlieb
Modified: 2024-08-06 16:28 UTC (History)
1 user (show)

See Also:
b.shertenlieb: maintainer-feedback+


Attachments
diff file for update to 1.40.5.8796 (1.42 KB, patch)
2024-08-02 22:51 UTC, Ben Shertenlieb
b.shertenlieb: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Shertenlieb 2024-08-02 22:51:01 UTC
Created attachment 252470 [details]
diff file for update to 1.40.5.8796

multimedia/plexmediaserver-plexpass: Update to 1.40.5.8796

 * New release from Plex.tv

  Changelog:

   https://forums.plex.tv/t/plex-media-server/30447/634

    NEW:
     (Log) Reduced the number of log messages generated when
      starting playback on an NVIDIA device.
     (Windows) noautorestart command line parameter added which
      prevents PMS from restarting after an auto update.

    FIXES:
     (Analysis) Preview thumbnail generation would not run on
      newly added media regardless if the preference was set.
     (QNAP) PMS might not start in all cases after QTS/QuTS
      restart.
     (View State Sync) Item plays could be duplicated when state
      synced from service.
     (Windows 64bit) Not all files were removed on uninstall.
     Plex Media Server could crash when falling back to SW encoding.

  QA:

   portlint OK (0 fatal errors)
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-04 02:01:07 UTC
Update multimedia/plexmediaserver-plexpass, but not update mater port multimedia/plexmediaserver… Maybe update both?
Comment 2 Ben Shertenlieb 2024-08-04 12:58:56 UTC
(In reply to Vladimir Druzenko from comment #1

Because the master port, multimedia/plexmediaserver is already updated to the latest version available from Plex.tv for the non-plexpass version...

I am not sure if you understand the release model of Plex... The plexpass version is (sort of) a beta... Plexpass users pay for access to early releases as well as certain parts, things that nonpaying users don't, like a DVR function among others... The plexpass version usually has a few releases before one is promoted and released to everyone...

I don't know who it was, someone much smarter than me, that decided which version was going to be the master or the slave with respect to the other in the ports system, but it has been that was long before I took over the maintenance of both and you are the first person to question it since I started...
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-04 22:01:31 UTC
(In reply to Ben Shertenlieb from comment #2)
You are right - I'm not familiar with this software.

I got warning make stage-qa:
/!\ plexmediaserver-plexpass-1.40.5.8796: Makefile warnings, please consider fixing /!\

Please set LICENSE for this port

Also error:
====> Running Q/A tests (stage-qa)
Error: /usr/local/share/plexmediaserver-plexpass/Resources/Python/lib/python2.7/site-packages/simplejson/_speedups.so is linked to /usr/local/lib/libsqlite3.so from databases/sqlite3 but it is not declared as a dependency
Warning: you need USES+=sqlite
Comment 4 Ben Shertenlieb 2024-08-06 01:21:18 UTC
(In reply to Vladimir Druzenko from comment #3)

I am currently trying to connect with a Plex.tv developer through the Plex forum to find out about the linked libraries... I am not an employee or have any affiliation with Plex.tv... As far as I know sqlite in not needed... I've been running a Plex server for years and have never needed to install sqlite... As soon as I get an answer from someone there, I don't have a clue what to do about it... The program builds and runs fine as is...

As for the license, do I need to have it listed in both master and slave ports or can I just list it in in the master to cover both???

Thank you for your input!!!
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-06 02:57:28 UTC
(In reply to Ben Shertenlieb from comment #4)
Maybe it's old unused library for python 2.7.

> As for the license, do I need to have it listed in both master and slave ports or can I just list it in in the master to cover both???
If you set LICENSE in master port and licenses for slave ports are same then you don't need to set LICENSE in slave ports.
Comment 6 Ben Shertenlieb 2024-08-06 13:35:11 UTC
(In reply to Vladimir Druzenko from comment #5)


I received the following answer from a Plex developer regarding the linked libraries:

---cut
Plex Media Server has no mandatory userspace dependency packages whatsoever, and that is highly unlikely to change. On Linux, the server doesn’t even depend on the system libc (it packages its own); on FreeBSD, since the libc is an inextricable component of the OS, it depends on that and nothing else. All other userspace libraries that are required by the server are either included as part of the package or are downloaded at runtime.

You can see libsqlite3.so is present in the lib directory below the root of the tarball. Whichever tool is producing that warning is giving you an incorrect path; the library will not be loaded from /usr/local/lib, but instead from the lib directory within the PMS installation. This is controlled by the DT_RUNPATH entry in the .dynamic sections of the libraries and executables in the tarball (see readelf -d [file]).

Hopefully this clears things up for you a bit.
--- cut


As for the license they are the same between both versions... As such, I will try to ferret out the details and hopefully include it during the next update to the master port...

I hope this clears up any triage question you have, and this update will be committed shortly...

Thank you!!!
Comment 7 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-06 15:47:22 UTC
(In reply to Ben Shertenlieb from comment #6)
It is bad practice to use your own copies of libraries - they may contain unfixed vulnerabilities. The same libraries in ports are fixed much faster.
But for binary software it is very difficult to do better - the current version may be linked to an old version of the library with an incompatible ABI.

Committing your patch.
Comment 8 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-06 15:54:23 UTC
Just released 1.40.5. 8829: https://forums.plex.tv/t/plex-media-server/30447/635

Plex Media Server 1.40.5. 8829 is now available to Plex Pass users in the Beta update channel.

NEW:
    (Log) Reduced the number of log messages generated when starting playback on an NVIDIA device. (PM-1417)
    (Windows) noautorestart command line parameter added which prevents PMS from restarting after an auto update (PM-1305)

FIXES:
    (Analysis) Preview thumbnail generation would not run on newly added media regardless if the preference was set (PM-1782)
    (Lyrics) Sidecar lyrics would fail to load (PM-1865)
    (QNAP) PMS might not start in all cases after QTS/QuTS restart.
    (View State Sync) Item plays could be duplicated when state synced from service.
    (Windows 64bit) Not all files were removed on uninstall (PM-1632)
    Plex Media Server could crash when falling back to SW encoding. (#15026)
Comment 9 commit-hook freebsd_committer freebsd_triage 2024-08-06 15:54:32 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8fd2a8891d53df6f7686ec8648fc0200d7bf6422

commit 8fd2a8891d53df6f7686ec8648fc0200d7bf6422
Author:     Ben Shertenlieb <b.shertenlieb@yahoo.com>
AuthorDate: 2024-08-06 15:51:09 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-08-06 15:51:09 +0000

    multimedia/plexmediaserver-plexpass: Update 1.40.4.8679 → 1.40.5.8796

    Changelogs:
    https://forums.plex.tv/t/plex-media-server/30447/633
    https://forums.plex.tv/t/plex-media-server/30447/634

    PR:     280581

 multimedia/plexmediaserver-plexpass/Makefile | 4 ++--
 multimedia/plexmediaserver-plexpass/distinfo | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)
Comment 10 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-06 15:56:00 UTC
Thanks.
Comment 11 Ben Shertenlieb 2024-08-06 16:28:52 UTC
(In reply to Vladimir Druzenko from comment #10)

Thank you!!!