Bug 280593 - net/s3m: Update to 0.10.0
Summary: net/s3m: Update to 0.10.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Zsolt Udvari
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-03 16:54 UTC by nbari
Modified: 2024-08-07 06:49 UTC (History)
1 user (show)

See Also:
nbari: maintainer-feedback+


Attachments
s3m 0.10.0 patch (53.29 KB, patch)
2024-08-03 16:54 UTC, nbari
no flags Details | Diff
s3m 0.10.0 patch (52.65 KB, patch)
2024-08-07 05:53 UTC, nbari
nbari: maintainer-approval+
Details | Diff
s3m 0.10.0 patch (58.77 KB, patch)
2024-08-07 05:58 UTC, nbari
nbari: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nbari 2024-08-03 16:54:48 UTC
Created attachment 252482 [details]
s3m 0.10.0 patch

Added Compression support -x/--compress (using zstd)
Comment 1 Zsolt Udvari freebsd_committer freebsd_triage 2024-08-06 12:49:05 UTC
Why did you add NOT_FOR_ARCHS? Doesn't build on i386?
Comment 2 nbari 2024-08-06 18:11:26 UTC
I started to get these emails https://pkg-status.freebsd.org/beefy19/data/140i386-quarterly/80e6e5da266d/logs/s3m-0.9.4_1.log, also when testing with poudriere couldn't make it compile with i386
Comment 3 Zsolt Udvari freebsd_committer freebsd_triage 2024-08-06 18:40:31 UTC
Ah, understand.
Could you please test this comment (and check the thread)?
https://github.com/briansmith/ring/issues/1999#issuecomment-2151011318

If it doesn't work a better solution into Makefile is here (mentioned in github-thread):
https://cgit.freebsd.org/ports/tree/lang/gleam/Makefile#n13
Comment 4 nbari 2024-08-07 05:53:00 UTC
Created attachment 252580 [details]
s3m 0.10.0 patch

Hi, updated patch, Indeed I get this error when compiling for i386:

error[E0080]: evaluation of constant value failed
  --> /wrkdirs/usr/ports/net/s3m/work/s3m-0.10.0/cargo-crates/ring-0.17.8/src/cpu/intel.rs:28:9
   |
28 |         assert!(cfg!(target_feature = "sse") && cfg!(target_feature = "sse2"));
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the evaluated program panicked at 'assertion failed: cfg!(target_feature = "sse") && cfg!(target_feature = "sse2")', /wrkdirs/usr/ports/net/s3m/work/s3m-0.10.0/cargo-crates/ring-0.17.8/src/cpu/intel.rs:28:9
Comment 5 nbari 2024-08-07 05:58:57 UTC
Created attachment 252581 [details]
s3m 0.10.0 patch

Added missing Makefile.crates
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-08-07 06:49:23 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=41c2c60a98268436930ef330743582de85d69995

commit 41c2c60a98268436930ef330743582de85d69995
Author:     nbari <nbari@tequila.io>
AuthorDate: 2024-08-07 06:44:54 +0000
Commit:     Zsolt Udvari <uzsolt@FreeBSD.org>
CommitDate: 2024-08-07 06:44:54 +0000

    net/s3m: update to 0.10.0

    Switch to DISTVERSION.
    Use Makefile.crates.
    Add BROKEN_i386.

    PR:             280593
    Approved by:    submitter is maintainer

 net/s3m/Makefile              | 276 +++-----------------------------
 net/s3m/Makefile.crates (new) | 259 ++++++++++++++++++++++++++++++
 net/s3m/distinfo              | 364 ++++++++++++++++++++++--------------------
 3 files changed, 468 insertions(+), 431 deletions(-)
Comment 7 Zsolt Udvari freebsd_committer freebsd_triage 2024-08-07 06:49:53 UTC
Committed, thanks!