Created attachment 252510 [details] delete knot3-lib After much effort I was able to make this port absolete. This patches removes it from the ports tree. @committer, for clarity -and because I cannot set BLOCK/DEPEND on PR's I didn't open- I crosspost the order of execution: step 1: PR 277332: dns/knot3 - add options / - prepare to replace knot3-lib step 2: PR 277540: dns/knot-resolver - fix rc scripts - abandon use of knot3-lib - upgrade to current version step 3: PR XXXXXX: dns/knot3-lib (this PR) - delete absolete knot3-lib port
Note that this patch is not complete since it does not remove the entry in dns/Makefile. No need to update a new patch though.
Committed, Thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=8d0a20fc0979c502ff1e5c0aaeb943051bd56b7d commit 8d0a20fc0979c502ff1e5c0aaeb943051bd56b7d Author: Leo Vandewoestijne <freebsd@dns.company> AuthorDate: 2024-08-08 14:42:51 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2024-08-08 15:07:42 +0000 dns/knot3-lib: Remove port The port was a dependency of dns/knot3 that took a while to remove since the port needed some work done in 277332 and 277540 PR: 280626 MOVED | 1 + dns/Makefile | 1 - dns/knot3-lib/Makefile (gone) | 12 ------ dns/knot3-lib/pkg-descr (gone) | 2 - dns/knot3-lib/pkg-plist (gone) | 84 ------------------------------------------ 5 files changed, 1 insertion(+), 99 deletions(-)
Hi Leo, I deleted knot3-lib but now make index fails for knot-resolver. > step 2: PR 277540: dns/knot-resolver > - fix rc scripts > - abandon use of knot3-lib ^^^^ I don't see this part in the patch in bug# 277540 > - upgrade to current version
Created attachment 252612 [details] Fix Makefile: all references of knot3-lib to knot3
(In reply to Michael Grimm from comment #5) Sorry, no 'git --diff' patch
Created attachment 252614 [details] Fix dns/knot-resolver/Makefile Hope that patch is ok with Leo. Poudriere compiles dns/knot-resolver with this patch, and knot-resolver works as expected
(In reply to Michael Grimm from comment #7) Done. Thanks Michael.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=b7fcdc240b32182ed5d8a8ffbd8de076c7817129 commit b7fcdc240b32182ed5d8a8ffbd8de076c7817129 Author: Fernando Apesteguía <fernape@FreeBSD.org> AuthorDate: 2024-08-09 11:04:04 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2024-08-09 11:15:49 +0000 dns/knot3-lib: Remove port The port is superseded by knot3-lib. Consumer has been modified accordingly. PR: 280626 MOVED | 1 + dns/Makefile | 1 - dns/knot3-lib/Makefile (gone) | 12 ------ dns/knot3-lib/pkg-descr (gone) | 2 - dns/knot3-lib/pkg-plist (gone) | 84 ------------------------------------------ 5 files changed, 1 insertion(+), 99 deletions(-)