Bug 280653 - ftp/curl: 8.9.1 leaks SIGPIPE
Summary: ftp/curl: 8.9.1 leaks SIGPIPE
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-06 10:50 UTC by Rafe
Modified: 2024-08-31 09:10 UTC (History)
6 users (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments
patch from upstream commit fe9baa1 (256 bytes, patch)
2024-08-06 10:50 UTC, Rafe
no flags Details | Diff
Alternative patch to Makefile (1.46 KB, patch)
2024-08-06 17:17 UTC, Rafe
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rafe 2024-08-06 10:50:22 UTC
Created attachment 252544 [details]
patch from upstream commit fe9baa1

See https://github.com/curl/curl/issues/14344 for the issue reported upstream. 

This is a problem for some ports that rely on libcurl, such as net-p2p/transmission (see bug #280644), which consistently crashes due to the bug. While the issue was fixed upstream in commit fe9baa1, upstream has no immediate plans for a bugfix release, necessitating a patch here. The attached patch is from upstream.
Comment 1 Anton Saietskii 2024-08-06 11:25:23 UTC
I'd like to suggest using PATCHSITES syntax sugar [0] for upstream commit [1].

[0]: https://github.com/curl/curl/commit/3eec5afbd0b6377eca893c392569b2faf094d970
[1]: https://docs.freebsd.org/en/books/porters-handbook/makefiles/#porting-patchfiles
Comment 2 Anton Saietskii 2024-08-06 11:26:05 UTC
(In reply to Anton Saietskii from comment #1)
Whoops, mixed up links, consider 0 as 1 and 1 as 0.
Comment 3 Rafe 2024-08-06 17:17:08 UTC
Created attachment 252567 [details]
Alternative patch to Makefile

An alternative patch that relies on PATCHSITES and PATCH_FILES.
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-08-15 11:56:55 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=73d53fec20e010a33757af558db532d30c3a085b

commit 73d53fec20e010a33757af558db532d30c3a085b
Author:     Rafe <mondo.debater_0q@icloud.com>
AuthorDate: 2024-08-15 09:47:18 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2024-08-15 11:53:54 +0000

    ftp/curl: Fix SIGPIPE initialization

    - Bump PORTREVISION for package change

    PR:             280653
    Obtained from:  https://github.com/curl/curl/commit/3eec5afbd0b6377eca893c392569b2faf094d970

 ftp/curl/Makefile | 4 ++++
 ftp/curl/distinfo | 4 +++-
 2 files changed, 7 insertions(+), 1 deletion(-)
Comment 5 Po-Chuan Hsieh freebsd_committer freebsd_triage 2024-08-15 12:08:42 UTC
Committed. Thanks!
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-08-31 09:10:59 UTC
A commit in branch 2024Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e9f5d5cff998811f461ea1b3289eccc45e10eb22

commit e9f5d5cff998811f461ea1b3289eccc45e10eb22
Author:     Rafe <mondo.debater_0q@icloud.com>
AuthorDate: 2024-08-15 09:47:18 +0000
Commit:     Mathieu Arnold <mat@FreeBSD.org>
CommitDate: 2024-08-31 09:09:29 +0000

    ftp/curl: Fix SIGPIPE initialization

    - Bump PORTREVISION for package change

    PR:             280653
    Obtained from:  https://github.com/curl/curl/commit/3eec5afbd0b6377eca893c392569b2faf094d970

    (cherry picked from commit 73d53fec20e010a33757af558db532d30c3a085b)

 ftp/curl/Makefile | 4 ++++
 ftp/curl/distinfo | 4 +++-
 2 files changed, 7 insertions(+), 1 deletion(-)