Bug 280660 - www/tgpt: Fix Makefile
Summary: www/tgpt: Fix Makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-06 12:48 UTC by Yusuf Yaman
Modified: 2024-08-06 15:37 UTC (History)
3 users (show)

See Also:


Attachments
www/tgpt (1.70 KB, patch)
2024-08-06 12:48 UTC, Yusuf Yaman
nxjoseph: maintainer-approval+
Details | Diff
poudriere testport log (38.00 KB, text/plain)
2024-08-06 12:49 UTC, Yusuf Yaman
no flags Details
portlint log (12 bytes, text/plain)
2024-08-06 12:49 UTC, Yusuf Yaman
no flags Details
www/tgpt (1.39 KB, patch)
2024-08-06 13:34 UTC, Yusuf Yaman
nxjoseph: maintainer-approval+
Details | Diff
poudriere testport log (38.17 KB, text/plain)
2024-08-06 14:17 UTC, Yusuf Yaman
no flags Details
portlint log (12 bytes, text/plain)
2024-08-06 14:18 UTC, Yusuf Yaman
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuf Yaman 2024-08-06 12:48:12 UTC
www/tgpt: Fix Makefile

* Remove unneeded line: LICENSE_FILE because LICENSE is already known by ports framework.
* Fix USES by adding: modules and removing GO_PKGNAME.
* Add GH_PROJECT.
* Remove output argument from GO_BUILDFLAGS as it does nothing.
Comment 1 Yusuf Yaman 2024-08-06 12:48:59 UTC
Created attachment 252551 [details]
www/tgpt
Comment 2 Yusuf Yaman 2024-08-06 12:49:14 UTC
Created attachment 252552 [details]
poudriere testport log
Comment 3 Yusuf Yaman 2024-08-06 12:49:24 UTC
Created attachment 252553 [details]
portlint log
Comment 4 Zsolt Udvari freebsd_committer freebsd_triage 2024-08-06 13:12:46 UTC
(In reply to Yusuf Yaman from comment #0)
https://docs.freebsd.org/en/books/porters-handbook/book/#licenses-license :

When the software provides the license file, use this:

LICENSE=	LGPL21+
LICENSE_FILE=	${WRKSRC}/COPYING


GH_PROJECT: the github-uses set it to PORTNAME, see table 5. (https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github) (and try "make -V GH_PROJECT").
Comment 5 Yusuf Yaman 2024-08-06 13:16:09 UTC
(In reply to Zsolt Udvari from comment #4)

along with either LICENSE_FILE or LICENSE_TEXT. LICENSE_DISTFILES and LICENSE_GROUPS can also be set, but are not required.

I understood that it is not required, am i wrong?

About GH_PROJECT, ok so I should remove it and it will use PORTNAME by default, thanks.
Comment 6 Yusuf Yaman 2024-08-06 13:17:03 UTC
> along with either LICENSE_FILE or LICENSE_TEXT. LICENSE_DISTFILES and
> LICENSE_GROUPS can also be set, but are not required.

> I understood that it is not required, am i wrong?

Oh, sorry. I understood it right now.
Comment 7 Yusuf Yaman 2024-08-06 13:34:17 UTC
Created attachment 252555 [details]
www/tgpt
Comment 8 Yusuf Yaman 2024-08-06 14:17:56 UTC
Created attachment 252556 [details]
poudriere testport log
Comment 9 Yusuf Yaman 2024-08-06 14:18:10 UTC
Created attachment 252557 [details]
portlint log
Comment 10 commit-hook freebsd_committer freebsd_triage 2024-08-06 15:24:27 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=00cf029670f1536cd94ad8eaa0c86f183b51285e

commit 00cf029670f1536cd94ad8eaa0c86f183b51285e
Author:     Yusuf Yaman <nxjoseph@protonmail.com>
AuthorDate: 2024-08-06 15:15:04 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-08-06 15:22:54 +0000

    www/tgpt: Fix Makefile

    * Fix USES by adding: modules and removing GO_PKGNAME.
    * Remove output argument from GO_BUILDFLAGS as it does nothing.

    PR:     280660
    MFH:    2024Q3

 www/tgpt/Makefile | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
Comment 11 commit-hook freebsd_committer freebsd_triage 2024-08-06 15:27:28 UTC
A commit in branch 2024Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=68f15c5a986862dd5c88fdd09d40bb4a72525f5d

commit 68f15c5a986862dd5c88fdd09d40bb4a72525f5d
Author:     Yusuf Yaman <nxjoseph@protonmail.com>
AuthorDate: 2024-08-06 15:15:04 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-08-06 15:26:30 +0000

    www/tgpt: Fix Makefile

    * Fix USES by adding: modules and removing GO_PKGNAME.
    * Remove output argument from GO_BUILDFLAGS as it does nothing.

    PR:     280660
    MFH:    2024Q3
    (cherry picked from commit 00cf029670f1536cd94ad8eaa0c86f183b51285e)

 www/tgpt/Makefile | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
Comment 12 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-06 15:36:20 UTC
Thanks.
Comment 13 Yusuf Yaman 2024-08-06 15:37:30 UTC
(In reply to Vladimir Druzenko from comment #12)
You are welcome, very thanks for giving a look to my port requests.