Bug 280675 - textproc/aspell: fix build with clang 19
Summary: textproc/aspell: fix build with clang 19
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: FreeBSD Office Team
URL:
Keywords:
Depends on:
Blocks: 280562
  Show dependency treegraph
 
Reported: 2024-08-07 18:21 UTC by Dimitry Andric
Modified: 2024-08-07 19:21 UTC (History)
1 user (show)

See Also:
fluffy: maintainer-feedback+


Attachments
textproc/aspell: fix build with clang 19 (2.34 KB, patch)
2024-08-07 18:21 UTC, Dimitry Andric
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2024-08-07 18:21:10 UTC
With clang 19 and gcc 15, textproc/aspell fails to compile, with errors
similar to:

    In file included from modules/speller/default/readonly_ws.cpp:51:
    modules/speller/default/vector_hash-t.hpp:186:43: error: no member named 'e' in 'VectorHashTable<Parms>'
      186 |     for (iterator i = begin(); i != this->e; ++i, ++this->_size);
          |                                     ~~~~  ^
    modules/speller/default/vector_hash-t.hpp:186:59: error: no member named '_size' in 'VectorHashTable<Parms>'; did you mean 'size_'?
      186 |     for (iterator i = begin(); i != this->e; ++i, ++this->_size);
          |                                                           ^~~~~
          |                                                           size_
    modules/speller/default/vector_hash.hpp:182:17: note: 'size_' declared here
      182 |     size_type   size_;
          |                 ^

Upstream commit <https://github.com/GNUAspell/aspell/commit/ee6cbb1>
fixes this this, so add it as a PATCHFILES entry in the Makefile, until
the next version of aspell is released.
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2024-08-07 18:21:40 UTC
Created attachment 252596 [details]
textproc/aspell: fix build with clang 19
Comment 2 Dima Panov freebsd_committer freebsd_triage 2024-08-07 18:29:18 UTC
Ship it!
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-08-07 19:13:46 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=24ae74c0e2045c689b20b4e336e9ca9912fdb270

commit 24ae74c0e2045c689b20b4e336e9ca9912fdb270
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-08-07 18:19:32 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2024-08-07 19:07:16 +0000

    textproc/aspell: fix build with clang 19

    With clang 19 and gcc 15, textproc/aspell fails to compile, with errors
    similar to:

        In file included from modules/speller/default/readonly_ws.cpp:51:
        modules/speller/default/vector_hash-t.hpp:186:43: error: no member named 'e' in 'VectorHashTable<Parms>'
          186 |     for (iterator i = begin(); i != this->e; ++i, ++this->_size);
              |                                     ~~~~  ^
        modules/speller/default/vector_hash-t.hpp:186:59: error: no member named '_size' in 'VectorHashTable<Parms>'; did you mean 'size_'?
          186 |     for (iterator i = begin(); i != this->e; ++i, ++this->_size);
              |                                                           ^~~~~
              |                                                           size_
        modules/speller/default/vector_hash.hpp:182:17: note: 'size_' declared here
          182 |     size_type   size_;
              |                 ^

    Upstream commit <https://github.com/GNUAspell/aspell/commit/ee6cbb1>
    fixes this this, so add it as a PATCHFILES entry in the Makefile, until
    the next version of aspell is released.

    PR:             280675
    Approved by:    fluffy (maintainer)
    MFH:            2024Q3

 textproc/aspell/Makefile | 3 +++
 textproc/aspell/distinfo | 4 +++-
 2 files changed, 6 insertions(+), 1 deletion(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-08-07 19:19:47 UTC
A commit in branch 2024Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7d7460f1dcc6b9fef9bc08993e78fff5f08a97ec

commit 7d7460f1dcc6b9fef9bc08993e78fff5f08a97ec
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-08-07 18:19:32 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2024-08-07 19:17:00 +0000

    textproc/aspell: fix build with clang 19

    With clang 19 and gcc 15, textproc/aspell fails to compile, with errors
    similar to:

        In file included from modules/speller/default/readonly_ws.cpp:51:
        modules/speller/default/vector_hash-t.hpp:186:43: error: no member named 'e' in 'VectorHashTable<Parms>'
          186 |     for (iterator i = begin(); i != this->e; ++i, ++this->_size);
              |                                     ~~~~  ^
        modules/speller/default/vector_hash-t.hpp:186:59: error: no member named '_size' in 'VectorHashTable<Parms>'; did you mean 'size_'?
          186 |     for (iterator i = begin(); i != this->e; ++i, ++this->_size);
              |                                                           ^~~~~
              |                                                           size_
        modules/speller/default/vector_hash.hpp:182:17: note: 'size_' declared here
          182 |     size_type   size_;
              |                 ^

    Upstream commit <https://github.com/GNUAspell/aspell/commit/ee6cbb1>
    fixes this this, so add it as a PATCHFILES entry in the Makefile, until
    the next version of aspell is released.

    PR:             280675
    Approved by:    fluffy (maintainer)
    MFH:            2024Q3

    (cherry picked from commit 24ae74c0e2045c689b20b4e336e9ca9912fdb270)

 textproc/aspell/Makefile | 3 +++
 textproc/aspell/distinfo | 4 +++-
 2 files changed, 6 insertions(+), 1 deletion(-)