Bug 280688 - dns/knot-resolver: upgrade to 5.7.4
Summary: dns/knot-resolver: upgrade to 5.7.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL: https://www.knot-resolver.cz/2024-07-...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-08 16:20 UTC by Leo Vandewoestijne
Modified: 2024-08-19 14:11 UTC (History)
2 users (show)

See Also:


Attachments
knot-resolver (906 bytes, patch)
2024-08-08 16:20 UTC, Leo Vandewoestijne
freebsd: maintainer-approval+
Details | Diff
knot-resolver (923 bytes, patch)
2024-08-19 11:55 UTC, Leo Vandewoestijne
freebsd: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Vandewoestijne 2024-08-08 16:20:40 UTC
Created attachment 252610 [details]
knot-resolver

In the midst of all the simultanious changes to the different Knot ports, there was also a simple version upgrade.
This patch updates the knot-resolver port to 5.7.4

Tested in poudriere, all fine.
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-08 16:46:21 UTC
Remove:
LIB_DEPENDS=    libdnssec.so:dns/knot3-lib \
                libknot.so:dns/knot3-lib \
                libzscanner.so:dns/knot3-lib
?
Comment 2 Leo Vandewoestijne 2024-08-12 09:01:05 UTC
It's a mystery to me why it took a portrevision to have those lines corrected as per https://cgit.freebsd.org/ports/commit/?id=04151eb383f77b748e9d6fc08a89fd669938b1fa
Must have been my mistake.

Could you try again - same patch against the current (revised) port ..?
Comment 3 Michael Grimm 2024-08-12 10:23:27 UTC
(In reply to Leo Vandewoestijne from comment #2)

Actually everything is clean now, see PR 280626, no more patches needed.

And I have tested knot3 and knot-resolver successfully.

Thanks for makeing knot3-lib obsolete.
Comment 4 Leo Vandewoestijne 2024-08-19 11:55:37 UTC
Created attachment 252913 [details]
knot-resolver

And in the meanwhile there was a PORTREVISION 2 (because protobuf had changes).

This patch to upgrade to 5.7.4 - basically identical to the initial.

And meant be applied against the current state of 5.7.3

Tested succesfull in poudriere.
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-08-19 14:11:01 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=353f214f6e703086ea38b31a8f46ca956f1eee48

commit 353f214f6e703086ea38b31a8f46ca956f1eee48
Author:     Leo Vandewoestijne <freebsd@dns.company>
AuthorDate: 2024-08-19 14:06:52 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-08-19 14:06:52 +0000

    dns/knot-resolver: Upgrade 5.7.3 → 5.7.4

    Changelog:
      Security
        reduce buffering of transmitted data, especially TCP-based in
        userspace Also expose some of the new tweaks in lua:
            (require 'ffi').C.the_worker.engine.net.tcp.user_timeout = 1000
            (require 'ffi').C.the_worker.engine.net.listen_{tcp,udp}_buflens.{snd,rcv}
      Improvements
        add the fresh DNSSEC root key "KSK-2024" already, Key ID 38696
        (!1556)
      Incompatible changes
        libknot 3.0.x support is dropped (!1558) Upstream last maintained
        3.0.x in spring 2022.
    https://www.knot-resolver.cz/2024-07-23-knot-resolver-5.7.4.html

    PR:     280688

 dns/knot-resolver/Makefile | 3 +--
 dns/knot-resolver/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 5 deletions(-)
Comment 6 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-19 14:11:37 UTC
Thanks.