Bug 280734 - [NEW PORT] graphics/ximaging: Image Viewer and Browser for Unix/X11
Summary: [NEW PORT] graphics/ximaging: Image Viewer and Browser for Unix/X11
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-10 16:27 UTC by Cédric Orlat
Modified: 2024-08-12 13:22 UTC (History)
1 user (show)

See Also:

Attachments
git format-patch origin/main (3.24 KB, patch)
2024-08-10 16:27 UTC, Cédric Orlat 		no flags Details | Diff
git format-patch origin/main - revised (2.97 KB, patch)
2024-08-11 16:53 UTC, Cédric Orlat 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cédric Orlat 2024-08-10 16:27:51 UTC 
Created attachment 252658 [details]
git format-patch origin/main

This port is an image viewer/browser that use the Motif toolkit, it is developed by the same developer of x11-wm/emwm, therefore it is well integrated with it but work great in any graphical environment. The compatibility with others architectures than amd64 is probable but not tested --- written in C ANSI.
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-10 19:35:18 UTC 
1. Alphabetically sort records:
LIB_DEPENDS+=	libtiff.so:graphics/tiff libpng16.so:graphics/png
USES=		tar:xz motif jpeg
USE_XORG=	xt xinerama x11
=>
LIB_DEPENDS=	libpng16.so:graphics/png \
                libtiff.so:graphics/tiff
USES=		jpeg motif tar:xz
USE_XORG=	x11 xinerama xt

2. Not needed "+": LIB_DEPENDS+= => LIB_DEPENDS=

3. CATEGORIES=deskutils, why not graphics?

4. Try to replace DISTNAME=ximaging-src-${DISTVERSION} with DISTVERSIONPREFIX=src-

5.
${INSTALL_PROGRAM} ${WRKSRC}/src/ximaging ${STAGEDIR}${PREFIX}/bin/ximaging
=>
${INSTALL_PROGRAM} ${WRKSRC}/src/${PORTNAME} ${STAGEDIR}${PREFIX}/bin

${INSTALL_MAN} ${WRKSRC}/src/ximaging.1 ${STAGEDIR}${PREFIX}/share/man/man1/ximaging.1
=>
${INSTALL_MAN} ${WRKSRC}/src/${PORTNAME}.1 ${STAGEDIR}${PREFIX}/share/man/man1

6. Less than 6 lines in pkg-plist recommended to replace with PLIST_FILES in Makefile:
PLIST_FILES= bin/ximaging \
             etc/X11/app-defaults/XImaging \
             share/man/man1/ximaging.1.gz
Comment 2 Cédric Orlat 2024-08-11 16:53:49 UTC 
Created attachment 252690 [details]
git format-patch origin/main - revised

Hello changes made as requested.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-08-12 13:22:39 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e67c2017f6fe368918062b1be695768f4da119f1

commit e67c2017f6fe368918062b1be695768f4da119f1
Author:     Cédric Orlat <corlat@ermaion.com>
AuthorDate: 2024-08-12 13:17:39 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-08-12 13:17:39 +0000

    graphics/ximaging: New port: Image Viewer and Browser for Unix/X11

    This port is an image viewer/browser that use the Motif toolkit, it is
    developed by the same developer of x11-wm/emwm, therefore it is well
    integrated with it but work great in any graphical environment. The
    compatibility with others architectures than amd64 is probable but not
    tested - written in C ANSI.

    PR:     280734

 graphics/Makefile                 |  1 +
 graphics/ximaging/Makefile (new)  | 31 +++++++++++++++++++++++++++++++
 graphics/ximaging/distinfo (new)  |  3 +++
 graphics/ximaging/pkg-descr (new) | 14 ++++++++++++++
 4 files changed, 49 insertions(+)
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-12 13:22:57 UTC 
Thanks.