Bug 280748 - games/libretro-shaders-slang: Simplify port
Summary: games/libretro-shaders-slang: Simplify port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-11 09:19 UTC by Daniel Engberg
Modified: 2024-08-15 23:20 UTC (History)
2 users (show)

See Also:
bsdcode: maintainer-feedback+


Attachments
Patch for libretro-shaders-slang (938 bytes, patch)
2024-08-11 09:19 UTC, Daniel Engberg
no flags Details | Diff
update games/libretro-shaders-slang (5.80 KB, patch)
2024-08-11 12:18 UTC, Stefan Schlosser
bsdcode: maintainer-approval+
Details | Diff
update games/libretro-shaders-slang (5.78 KB, patch)
2024-08-11 16:37 UTC, Stefan Schlosser
bsdcode: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-08-11 09:19:33 UTC
Created attachment 252677 [details]
Patch for libretro-shaders-slang

Just make a bit more readable what's going on and while at it add NO_BUILD to port and add parentheses to match Porters Handbook
Comment 1 Stefan Schlosser 2024-08-11 12:18:56 UTC
Created attachment 252682 [details]
update games/libretro-shaders-slang

Thanks! I applied portclippy suggestions to your changes and updated to g20240809 while there.
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-11 13:43:03 UTC
Why not keep README.md as option for find in COPYTREE_SHARE instead of separate RM:
	(cd ${WRKSRC} && ${COPYTREE_SHARE} . ${STAGEDIR}${DATADIR} \
		-a ! -regex ^./README.md)
?
Comment 3 Stefan Schlosser 2024-08-11 16:37:39 UTC
Created attachment 252689 [details]
update games/libretro-shaders-slang

Right, I was too quick. Readd "! -regex ^./README.md".
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-12 00:35:46 UTC
I'll commit if Daniel doesn't mind.
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-08-15 23:18:18 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=092a9e9d974f49e797f26820fe9e828858c12717

commit 092a9e9d974f49e797f26820fe9e828858c12717
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-08-15 23:13:25 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-08-15 23:13:25 +0000

    games/libretro-shaders-slang: Update g20240804 → g20240809, Simplify port

    PR:             280748
    Approved by:    Stefan Schlosser <bsdcode@disroot.org> (maintainer)

 games/libretro-shaders-slang/Makefile  | 13 ++++++++-----
 games/libretro-shaders-slang/distinfo  |  6 +++---
 games/libretro-shaders-slang/pkg-plist | 17 +++++++++++++++++
 3 files changed, 28 insertions(+), 8 deletions(-)