Bug 280764 - emulators/86Box: add support for aarch64 and improvements to configuration file
Summary: emulators/86Box: add support for aarch64 and improvements to configuration file
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm64 Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-12 00:30 UTC by gatekeeper
Modified: 2024-08-12 14:01 UTC (History)
1 user (show)

See Also:

Attachments
git patch (2.29 KB, patch)
2024-08-12 00:30 UTC, gatekeeper 		no flags Details | Diff
git patch (2.29 KB, patch)
2024-08-12 00:53 UTC, gatekeeper 		no flags Details | Diff
git patch (2.47 KB, patch)
2024-08-12 08:59 UTC, gatekeeper 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description gatekeeper 2024-08-12 00:30:06 UTC 
Created attachment 252700 [details]
git patch

* Adds support for aarch64
* Sets the configuration to ~/.config/86Box.cfg when running from desktop shortcut
* Makes this behavior explicit in pkg-message
Comment 1 gatekeeper 2024-08-12 00:53:26 UTC 
Created attachment 252701 [details]
git patch

re-uploading the patch, as something went wrong before...
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-12 01:51:32 UTC 
Don't add anything after .include <bsd.port.mk>
Use this:
.include <bsd.port.pre.mk>
.if ${ARCH} == "aarch64"
CMAKE_ON+=	NEW_DYNAREC
.endif
.include <bsd.port.post.mk>

And remove .include <bsd.port.mk>

But in your case better use:
CMAKE_ON+=		${CMAKE_ON_${ARCH}}
CMAKE_ON_aarch64=	NEW_DYNAREC

After ".endif" and before SUB_FILES.
Comment 3 gatekeeper 2024-08-12 08:59:26 UTC 
Created attachment 252704 [details]
git patch

I see - your proposal is much much cleaner than what I wrote before.
New patch reflects these changes.
Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-08-12 13:55:43 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=465c31f9b51d509db686cd8dffca54b498839a04

commit 465c31f9b51d509db686cd8dffca54b498839a04
Author:     gatekeeper <tiago.gasiba@gmail.com>
AuthorDate: 2024-08-12 13:49:40 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-08-12 13:50:52 +0000

    emulators/86Box: add support for aarch64 and improvements to configuration file

    * Add support for aarch64
    * Set the configuration to ~/.config/86Box.cfg when running from desktop shortcut
    * Make this behavior explicit in pkg-message

    PR:     280764

 emulators/86Box/Makefile    | 9 ++++++---
 emulators/86Box/pkg-message | 9 ++++++---
 2 files changed, 12 insertions(+), 6 deletions(-)
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-12 14:01:11 UTC 
Thanks.