Created attachment 252712 [details] [PATCH] devel/pcsc-lite: update 2.2.2 → 2.3.0
Why did you move plist entries?
(In reply to Gleb Popov from comment #1) Look like sort.
Yes, exactly: I've just sorted the plist (`M-x sort-lines`). I also often sort and format Makefiles' entries according to 'portclippy --strict' recommendations to make all the Makefiles look uniform, just as intended by official coding style. I believe and think it helps a lot when working with so many of them every day, as one can be sure where to put/edit this or that entry. Other than that I have little to no interest in making my own changes just for my own style or view. Few occurrences of this are limited to pkg-descr files only anyway.
(In reply to Älven from comment #3) > Yes, exactly: I've just sorted the plist (`M-x sort-lines`). This naive sorting does not take %%SUBSTITUTIONS%% into account, unfortunately. I have the code that sorts plists correctly, but it is a part of bigger piece of software and can't be used standalone (ports-mgmt/hs-panopticum). Maybe I will extract that functionality into a separate subcommand one day. For now please restore the ordering in the plist.
I think sorting has meaning only for humans when reading/editing pkg-plists by hand in their original form. Where and how can one see/use them after %%SUBSTITUTIONS%%? Anyway, why do you ask me to change anything in my patch instead of just changing/excluding from pushing the parts you don't like for some reason? It looks as you just like to give me orders what to do. No one would be pleased by this.
(In reply to Älven from comment #5) > I think sorting has meaning only for humans when reading/editing pkg-plists by hand in their original form. Where and how can one see/use them after %%SUBSTITUTIONS%%? After substitutions are removed the plist would be out of order. > It looks as you just like to give me orders what to do. No one would be pleased by this. I don't see how sentence starting with "please" can be an order. I just asked you to do that so that it is a bit easier for me to push your change. Of course I can do that myself if you feel it is too hard for you. But since we touched this topic maybe you can explain why did you open PRs saying "foo/bar: Update to x.y.z", set me as assignee and did not provide any patch? This looked more like an order to me. IIRC, for some ports I wasn't even a maintainer, so that action was strange.
> After substitutions are removed the plist would be out of order. I know. I asked about when (if) it does matter. > I don't see how sentence starting with "please" can be an order. It highly depends on intonation it is said with. Remember Gandalf been greeted "Good morning!" by the hobbits saying it with intonation actually meaning "Go away!"… I may be wrong presuming your bad intentions, still it's a matter of willing/unwilling of cooperation: How would you like your own patches be treated: would you prefer them being slightly corrected with little to no work for committer/maintainer or to be asked for rework "just to realize and fix your own mistakes by yourself"? I'm for minimizing any communications when they are of no high importance/urgency. It's not about actual difficulty of reworking the patch (it's still less work for the committer, working with git via lightning-fast magit/shell by hotkeys, than for submitter, unable to submit patches directly via git and having to use web form in a snail-slow web browser by a mouse), but about whether or not you like to help me with this, or prefer to make me do my own homework, even as little one as this.
(In reply to Älven from comment #7) > How would you like your own patches be treated: would you prefer them being slightly corrected with little to no work for committer/maintainer or to be asked for rework "just to realize and fix your own mistakes by yourself"? The latter, unless I have too little understanding of what I'm doing and the reviewer has much deeper knowledge of the problem. > but about whether or not you like to help me with this, or prefer to make me do my own homework You already made your judgement on this in the initial comment and I have no interest in arguing. I will amend the plist myself.
> why did you open PRs saying "foo/bar: Update to x.y.z", set me as assignee and did not provide any patch? Sorry in advance if something in my PRs made you think anything bad: I didn't and don't want to rule/order any people, neither here nor anywhere else. Just can't guess what bad may be with asking for update without a patch. People can't always make patches by themselves every time they need something updated, so they have to ask/remember of an update. Nothing wrong with it. The title "foo/bar: Update to x.y.z" is just a standard boilerplate used ubiquitously here, nothing bad either. Setting you as assignee is done not by me but by some bugzilla automation script. Anyway, I'm never asking people for anything here, I'm just creating ticket in system, and it assigns the task (not the order, why even think of it this way??) to the people, putted themselves in charge for the program in question. I'm working with the machine, not the people. So no intentions ever presumed about any people by me. This is the same way I treat any tasks being assigned to me: they are given by the machine, not the people, so it in no way an order, but just a task. I don't feel obliged by it in any way, but just informed. And I expect everyone think this way (why other)? Still I much more often do provide patches than not :) > for some ports I wasn't even a maintainer, so that action was strange This is something strange for me too: how it could be? I may guess only you may be indirectly assigned as a member of the @haskell group when it is stated as a maintainer. I'm open to investigating these cases, would you like to point at them.
> the reviewer has much deeper knowledge of the problem Insisting on rework without even actually sharing any knowledge is not actually a homework but just "shut up and do as I said" thing. I still don't know why do someone may need plist being sorted after, not before any substitutions. I like to learn and may even do homework, just give me that knowledge to learn. > You already made your judgement on this in the initial comment I'm sad being misunderstood or even upset on by the people without me wishing anything bad to them. I'm also afraid of them being angry on me. I may have some reasonable negative upfront expectations of them after been forced to shut up here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=278000#c13 And if your "please" was not like these ones https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=278000#c17 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=278000#c22 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=278000#c23 then you may be a good person and I was wrong about you. Sorry then. May hope you actually is not like them.
One more simple thing forgotten: there is nothing special with neither you nor other maintainers whom I am asking/sending patches too often. I just like functional languages (elixir/haskell/lisp/other) in general, so would like them not to go to oblivion, so trying to keep their Makefiles up to date in first priority. :) I may not to bother you with this if you would not like it.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=4c04b4155dcdb6ac873a7e296bf401420583569b commit 4c04b4155dcdb6ac873a7e296bf401420583569b Author: Älven <alster@vinterdalen.se> AuthorDate: 2024-08-14 11:03:21 +0000 Commit: Gleb Popov <arrowd@FreeBSD.org> CommitDate: 2024-08-14 11:22:04 +0000 devel/pcsc-lite: Update to 2.3.0 PR: 280779 Sponsored by: Serenity Cybersecurity, LLC (testing) devel/pcsc-lite/Makefile | 5 +++-- devel/pcsc-lite/distinfo | 6 +++--- devel/pcsc-lite/pkg-plist | 1 + 3 files changed, 7 insertions(+), 5 deletions(-)
Pushed, thanks!
Thank you too! :) I may try to prepare patches for your programs according to what you may like.