Bug 280835 - math/libRmath: update 4.3.1 → 4.4.1
Summary: math/libRmath: update 4.3.1 → 4.4.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Zsolt Udvari
URL: https://cran.r-project.org/doc/manual...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-15 18:50 UTC by Älven
Modified: 2024-09-02 19:29 UTC (History)
2 users (show)

See Also:

Attachments
[PATCH] math/libRmath: update 4.3.1 → 4.4.1 (1.78 KB, patch)
2024-08-15 18:50 UTC, Älven 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Älven 2024-08-15 18:50:05 UTC 
Created attachment 252782 [details]
[PATCH] math/libRmath: update 4.3.1 → 4.4.1
Comment 1 Zsolt Udvari freebsd_committer freebsd_triage 2024-08-23 18:39:44 UTC 
(In reply to Älven from comment #0)
Why did you set maintainer-approval flag to danfe@? As I see this port has no maintainer.
Comment 2 Älven 2024-08-24 08:59:03 UTC 
(In reply to Zsolt Udvari from comment #1)
My mistake. It wasn't intentional. I likely was distracted and copy-pasted the field value from wrong place. Sorry for any inconvenience.
BTW, whose approval should I ask for in such cases?
Comment 3 Zsolt Udvari freebsd_committer freebsd_triage 2024-08-24 17:20:39 UTC 
Okay, no problem.
If the port's "maintainer" is ports@freebsd.org means the port has no maintainer. In this case doesn't need approval.
If you want you can be its maintainer: overwrite the maintainer's email in Makefile.
Comment 4 Älven 2024-08-24 19:49:45 UTC 
I remembered why exactly I asked @danfe about approval: it was because I found him to be the maintainer of lang/algol68g - the only port dependent on libRmath, so as it may concern him anyway, and I also filed a patch for the algol68 [0] also for @danfe. So I thought he may likely review both patches at once.

About maintainership: I found it interesting and thinking about to agree on it, thank you for the proposal. I just not fully understand R ecosystem, so not sure how good a maintainer I could be for this port. At least I may promise to keep it uptodate.

[0] See bug #280836
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-09-02 18:31:22 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=610b0b17a155207450f0acc47c2a546d672f2bef

commit 610b0b17a155207450f0acc47c2a546d672f2bef
Author:     Älven <alster@vinterdalen.se>
AuthorDate: 2024-09-02 18:26:14 +0000
Commit:     Zsolt Udvari <uzsolt@FreeBSD.org>
CommitDate: 2024-09-02 18:30:49 +0000

    math/libRmath: Update to 4.4.1

    Add LICENSE_FILE.
    Submitter takes maintainership.

    PR:             280835

 math/libRmath/Makefile | 7 ++++---
 math/libRmath/distinfo | 6 +++---
 2 files changed, 7 insertions(+), 6 deletions(-)
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-09-02 18:41:27 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=84ecbeb0a6c008e0daccee1d537d53936236dbf2

commit 84ecbeb0a6c008e0daccee1d537d53936236dbf2
Author:     Älven <alster@vinterdalen.se>
AuthorDate: 2024-09-02 18:39:08 +0000
Commit:     Zsolt Udvari <uzsolt@FreeBSD.org>
CommitDate: 2024-09-02 18:39:08 +0000

    lang/algol68g: bump PORTREVISION after libRmath update

    PR:             280835

 lang/algol68g/Makefile | 1 +
 1 file changed, 1 insertion(+)
Comment 7 Zsolt Udvari freebsd_committer freebsd_triage 2024-09-02 18:45:10 UTC 
Committed, thanks!
Comment 8 Älven 2024-09-02 19:29:49 UTC 
Thank you too! I will care about the port.