Created attachment 252955 [details] Patch for upgrade of port to version 6.32/04 Attached: Patch for upgrade of port to version 6.32/04 Release notes: https://root.cern/doc/v632/release-notes.html#release-6.32.04
Hi Erik, I noticed HTTP option implies WEBGUI (and ROOT7) and WEBGUI implies HTTP (and ROOT7). So if user selects one it implies another too. Maybe would be simpler merge them into one option. What do you think?
Hi Zsolt, I agree, it is a bit superfluous, but as I wrote in bug #279520, the various options provided by the port Makefile mimic those provided by the source code's CMake configuration: https://root.cern/install/build_from_source/#all-build-options I carried out testing of the various port options in order to figure out which options are implied by others, and, indeed, either HTTP or WEBGUI is redundant. Unless there is a good ports tree/robustness case for eliminating one of the two options, I would prefer keeping both options in order to mimic the source code options as closely as possible. Cheers from Erik
(In reply to Erik Jensen from comment #2) Understand, okay.
Committed, thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=cc8bdfce082a307916c49eccae06ba21ea70a397 commit cc8bdfce082a307916c49eccae06ba21ea70a397 Author: Erik Jensen <erik@tenku.dk> AuthorDate: 2024-08-25 17:52:50 +0000 Commit: Zsolt Udvari <uzsolt@FreeBSD.org> CommitDate: 2024-08-25 17:52:50 +0000 devel/root: Update to 6.32.04 The HTTP and WEBGUI option implies ROOT7 option. Changelog: https://root.cern/doc/v632/release-notes.html#release-6.32.04 PR: 280949 Approved by: submitter is maintainer devel/root/Makefile | 7 +++---- devel/root/distinfo | 6 +++--- devel/root/pkg-plist | 1 + 3 files changed, 7 insertions(+), 7 deletions(-)