Bug 280963 - lang/go-devel: Please copy into lang/go123 since go1.23.0 was released last week
Summary: lang/go-devel: Please copy into lang/go123 since go1.23.0 was released last week
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Adam Weinberger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-21 02:41 UTC by Yuri Victorovich
Modified: 2024-10-02 21:51 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (go)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2024-08-21 02:41:32 UTC 
https://github.com/golang/go/tags
Comment 1 Yonas Yanfa 2024-08-29 19:56:07 UTC 
:thumbs up:

I can't compile https://github.com/dexidp/dex with updated dependencies because ent requires go >= 1.23.0:

go: entgo.io/ent@v0.14.1 requires go >= 1.23.0 (running go 1.22.6; GOTOOLCHAIN=local)
Comment 2 Adam Weinberger freebsd_committer freebsd_triage 2024-09-08 15:38:42 UTC 
I'm going to add a go123 port. I suspect that the go team is overwhelmed at the moment.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-09-08 16:06:14 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f4b88cbec33d76136715e807763824b4fdb7bb42

commit f4b88cbec33d76136715e807763824b4fdb7bb42
Author:     Adam Weinberger <adamw@FreeBSD.org>
AuthorDate: 2024-09-08 16:02:37 +0000
Commit:     Adam Weinberger <adamw@FreeBSD.org>
CommitDate: 2024-09-08 16:02:37 +0000

    lang/go123: Add port

    Simple copy from lang/go122.

    PR:             280963
    Reported by:    yuri

 lang/go123/Makefile (new)                          | 19 ++++++++++++++++++
 lang/go123/distinfo (new)                          | 15 ++++++++++++++
 lang/go123/files/patch-src_cmd_dist_build.go (new) | 23 ++++++++++++++++++++++
 ...tch-src_cmd_go_internal_modload_vendor.go (new) | 11 +++++++++++
 4 files changed, 68 insertions(+)
Comment 4 Adam Weinberger freebsd_committer freebsd_triage 2024-09-08 16:10:43 UTC 
I've committed go123. I'm assigning this PR to myself in case there's fallout.
Comment 5 Adam Weinberger freebsd_committer freebsd_triage 2024-09-30 11:44:05 UTC 
I've heard nothing, so I'm closing out this PR.
Comment 6 Yonas Yanfa 2024-09-30 12:29:35 UTC 
(In reply to Adam Weinberger from comment #5)

Can we make 1.23 the default version?

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281773
Comment 7 Adam Weinberger freebsd_committer freebsd_triage 2024-10-02 21:51:11 UTC 
(In reply to Yonas Yanfa from comment #6)

Probably not, but it's worth considering making go122 the default. There's probably no reason to keep go120 and go121 around.

That said, I am not formally part of the go team. I added this port because the go team appeared to be busy with other projects. I'm not comfortable changing the default, but it's good to have this on their radar.