Bug 281023 - emulators/ares: update to 139.20240823
Summary: emulators/ares: update to 139.20240823
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-24 09:15 UTC by Stefan Schlosser
Modified: 2024-08-24 15:00 UTC (History)
1 user (show)

See Also:


Attachments
update to 139.20240823 (7.48 KB, patch)
2024-08-24 09:15 UTC, Stefan Schlosser
bsdcode: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Schlosser 2024-08-24 09:15:54 UTC
Created attachment 253050 [details]
update to 139.20240823

The most notable change to the port is my inclusion of an inofficial patch to control the behaviour of hotkey execution in the emulator. This patch is behind the HOTKEYS option, disabled by default. This patch won't be accepted upstream with its current scope.

Currently hotkeys share the binding space with regular game inputs. This can be problematic for gamepad-only users who want to bind some hotkey functions (screenshots, save state, load state, quit emulator, etc...) to gamepad buttons but who don't have enough unassigned buttons left on the gamepad. The patch prevents the execution of hotkey actions unless the emulator is paused. This way users can assign many hotkey actions to gamepad buttons and access them with pausing the emulator.

The patch affects two sourcefiles, but because it's a very small patch I decided to put it in one port patch. If the patch should be split up (one patch per changed sourcefile) I will do it.


Commit changes:
https://github.com/ares-emulator/ares/compare/a76847d..3cd82c8

Port changes:
  * add HOTKEYS option, disabled by default
  * remove upstreamed 'unbreak i386 build' patch
  * use SUB_LIST to update recommended librashader version in pkg-message
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-24 13:57:26 UTC
doas isn't in base - use su instead.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-08-24 14:28:42 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9e6023ac0e0df4813dabe10f49023cb6343f0289

commit 9e6023ac0e0df4813dabe10f49023cb6343f0289
Author:     Stefan Schlosser <bsdcode@disroot.org>
AuthorDate: 2024-08-24 14:21:38 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-08-24 14:27:00 +0000

    emulators/ares: update 139.20240809 → 139.20240823

    The most notable change to the port is my inclusion of an inofficial
    patch to control the behaviour of hotkey execution in the emulator.
    This patch is behind the HOTKEYS option, disabled by default.
    This patch won't be accepted upstream with its current scope.

    Currently hotkeys share the binding space with regular game inputs.
    This can be problematic for gamepad-only users who want to bind some
    hotkey functions (screenshots, save state, load state, quit emulator,
    etc...) to gamepad buttons but who don't have enough unassigned buttons
    left on the gamepad. The patch prevents the execution of hotkey actions
    unless the emulator is paused. This way users can assign many hotkey
    actions to gamepad buttons and access them with pausing the emulator.

    Commit changes:
    https://github.com/ares-emulator/ares/compare/a76847d..3cd82c8

    Port changes:
     * add HOTKEYS option, disabled by default
     * remove upstreamed 'unbreak i386 build' patch
     * use SUB_LIST to update recommended librashader version in pkg-message
     * replace 'doas' with 'su' in pkg-message - 'doas' is not in base

    PR:     281023

 emulators/ares/Makefile                        | 12 ++++++---
 emulators/ares/distinfo                        |  6 ++---
 emulators/ares/files/extra-patch-hotkeys (new) | 35 ++++++++++++++++++++++++++
 emulators/ares/files/patch-nall_GNUmakefile    | 11 +-------
 emulators/ares/files/pkg-message.in            | 21 ++++++++++------
 5 files changed, 60 insertions(+), 25 deletions(-)
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-24 14:28:53 UTC
Thanks.
Comment 4 Stefan Schlosser 2024-08-24 14:43:12 UTC
Thanks for the recommendation. But it should be

su root -c 'pkg install rust-nightly'

instead of

su pkg install rust-nightly

(and the cp part also of course).
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-24 14:58:34 UTC
(In reply to Stefan Schlosser from comment #4)
You are right.
I'll fix it now.
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-08-24 15:00:46 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a7274daa5fbba3baca1e58c9647b30c781e02e95

commit a7274daa5fbba3baca1e58c9647b30c781e02e95
Author:     Stefan Schlosser <bsdcode@disroot.org>
AuthorDate: 2024-08-24 14:59:24 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-08-24 14:59:24 +0000

    emulators/ares: fix 'su' usage in pkg-message

    PR:     281023
    Fixes:  9e6023ac0e0d (update 139.20240809 → 139.20240823)

 emulators/ares/files/pkg-message.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)