Abandonware for over a decade and decoding is supported by FFmpeg so point users to that?
I guess we can live without an encoder in the ports tree, we should still support decoding. grep shows the following ports have at least an optional dependency on audio/musepack: audio/aqualung audio/cmus audio/gstreamer1-plugins-musepack audio/moc audio/musicpd audio/sdl_audiolib multimedia/qmmp-qt5 multimedia/qmmp-qt6 multimedia/vlc I've tested musicpd and vlc. Both can play .mpc files without musepack installed, probably through ffmpeg as you've mentioned. From my side it's OK to remove the port. I guess we should test if all mentioned ports support decoding through ffmpeg and/or ask the maintainers if they object to the removal.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=0fb54007da9c6a17aae7801280ddbe17777a5bad commit 0fb54007da9c6a17aae7801280ddbe17777a5bad Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2024-08-25 07:59:14 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2024-08-25 08:17:30 +0000 multimedia/gstreamer1-plugins*: Remove Musepack library support Remove support for Musepack audio library PR: 281025 Mk/Uses/gstreamer.mk | 5 +---- audio/Makefile | 1 - audio/gstreamer1-plugins-musepack/Makefile (gone) | 15 --------------- audio/gstreamer1-plugins-musepack/pkg-plist (gone) | 1 - multimedia/gstreamer1-plugins-all/Makefile | 2 +- multimedia/gstreamer1-plugins-bad/Makefile | 2 +- multimedia/gstreamer1-plugins/Makefile | 2 +- multimedia/gstreamer1-plugins/Makefile.common | 1 - 8 files changed, 4 insertions(+), 25 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=71b14d6e9c6387133e66737808ebf5d995bc003c commit 71b14d6e9c6387133e66737808ebf5d995bc003c Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2024-08-25 07:49:48 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2024-08-25 08:17:29 +0000 audio/pacpl: Remove Musepack support Remove support for Musepack audio format PR: 281025 Approved by: portmgr (blanket) audio/pacpl/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=84fff01c2bc85436abd72107fe9e62d7cbc2e6d5 commit 84fff01c2bc85436abd72107fe9e62d7cbc2e6d5 Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2024-08-25 07:45:51 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2024-08-25 08:17:29 +0000 audio/musicpd: Remove Musepack library support Remove support for Musepack audio library PR: 281025 Approved by: portmgr (blanket) audio/musicpd/Makefile | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=b0c642e4be4a475727c84a031e2996092eba8efe commit b0c642e4be4a475727c84a031e2996092eba8efe Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2024-08-25 07:43:09 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2024-08-25 08:17:28 +0000 www/libresonic-standalone: Remove Musepack support Remove support for Musepack audio format PR: 281025 Approved by: portmgr (blanket) www/libresonic-standalone/Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3a8abe8e843f618618f83c0dd29a757a078d452e commit 3a8abe8e843f618618f83c0dd29a757a078d452e Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2024-08-25 07:52:27 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2024-08-25 08:17:30 +0000 multimedia/qmmp-qt5: Remove Musepack library support Remove support for Musepack audio library PR: 281025 Approved by: portmgr (blanket) multimedia/qmmp-qt5/Makefile | 10 ++++------ multimedia/qmmp-qt5/pkg-plist | 1 - 2 files changed, 4 insertions(+), 7 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=ba75486d2f523d22bf202a8eace3d8f3f570aeb4 commit ba75486d2f523d22bf202a8eace3d8f3f570aeb4 Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2024-08-25 07:57:26 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2024-08-25 08:17:30 +0000 audio/aqualung: Remove Musepack library support Remove support for Musepack audio library PR: 281025 Approved by: portmgr (blanket) audio/aqualung/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=21f8bcc7e899e8b7e4115933e6e6871e6cca371a commit 21f8bcc7e899e8b7e4115933e6e6871e6cca371a Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2024-08-25 07:48:31 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2024-08-25 08:17:29 +0000 audio/cmus: Remove Musepack library support Remove support for Musepack audio library PR: 281025 Approved by: portmgr (blanket) audio/cmus/Makefile | 5 +---- audio/cmus/pkg-plist | 1 - 2 files changed, 1 insertion(+), 5 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=ef22fc43fe8f66f9a5ad0f84c7dc1de7571bef71 commit ef22fc43fe8f66f9a5ad0f84c7dc1de7571bef71 Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2024-08-25 07:44:18 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2024-08-25 08:17:28 +0000 audio/sdl_audiolib: Remove Musepack library support Remove support for Musepack audio library PR: 281025 Approved by: portmgr (blanket) audio/sdl_audiolib/Makefile | 9 +++------ audio/sdl_audiolib/pkg-plist | 1 - 2 files changed, 3 insertions(+), 7 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=bc7255b18f0b895686033ef55d5b7b2871b185fe commit bc7255b18f0b895686033ef55d5b7b2871b185fe Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2024-08-25 07:47:05 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2024-08-25 08:17:29 +0000 audio/moc: Remove Musepack library support Remove support for Musepack audio library PR: 281025 Approved by: portmgr (blanket) audio/moc/Makefile | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=dccaeeb9fd7aebfec8f621ad609896b4315d2193 commit dccaeeb9fd7aebfec8f621ad609896b4315d2193 Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2024-08-25 07:44:59 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2024-08-25 08:17:29 +0000 audio/abcde: Remove Musepack support Remove support for Musepack audio format PR: 281025 Approved by: portmgr (blanket) audio/abcde/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=15b6cac8699f9ba9919293be5a7f9ebbb87d43f3 commit 15b6cac8699f9ba9919293be5a7f9ebbb87d43f3 Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2024-08-25 07:28:49 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2024-08-25 08:17:28 +0000 www/subsonic-standalone: Remove Musepack support and fix APE_DESC Remove support for Musepack audio format and adjust APE_DESC PR: 281025 Approved by: portmgr (blanket) www/subsonic-standalone/Makefile | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=6547f8d615b859ab2f671323cf571bfc7507ed42 commit 6547f8d615b859ab2f671323cf571bfc7507ed42 Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2024-08-25 07:55:09 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2024-08-25 08:17:30 +0000 multimedia/vlc: Remove Musepack library support Remove support for Musepack audio library PR: 281025 multimedia/vlc/Makefile | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=5803e45518340765ac6fed563660171ff27903cd commit 5803e45518340765ac6fed563660171ff27903cd Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2024-08-25 07:51:29 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2024-08-25 08:17:29 +0000 multimedia/qmmp-qt6: Remove Musepack library support Remove support for Musepack audio library PR: 281025 Approved by: portmgr (blanket) multimedia/qmmp-qt6/Makefile | 10 ++++------ multimedia/qmmp-qt6/pkg-plist | 1 - 2 files changed, 4 insertions(+), 7 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=f5d113d4acc4b868fd3b963c808fb496d37d6283 commit f5d113d4acc4b868fd3b963c808fb496d37d6283 Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2024-08-25 07:25:17 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2024-08-25 08:17:28 +0000 audio/musepack: Deprecate and set expiration date to 2024-09-30 No development in over a decade and never got traction, decoding is supported by FFmpeg however there's no encoding support. For encoding consider alternative formats such as Opus, AAC, xHE-AAC or legacy audio formats such as MP3 and Ogg Vorbis. PR: 281025 Reviewed by: Stefan Ehmann <shoesoft@gmx.net> (maintainer) audio/musepack/Makefile | 3 +++ 1 file changed, 3 insertions(+)
Committed, thanks!
(In reply to Daniel Engberg from comment #0) Despite being abandonware, some ppl may still use it. TBH, I doubt that removing anything is right decision as long as it builds fine.
You can still use FFmpeg for decoding and it's (the encoder) already removed in most repos or not packaged at all. https://repology.org/project/musepack/versions
(In reply to Daniel Engberg from comment #18) Pardonne moi, but I don't care about other systems, I care about FreeBSD only. I'd also don't consider 'everybody else removed that' as a decent rationale — I consider that as our strength. I may be wrong, but this is my vision: 1. Does software build? (Yes?) 2. Does software work? (Yes?) 3. Is there a direct replacement? (Modern implementation of format itself. No?) 4. Does software require significant effort to support? (No?)
(In reply to Anton Saietskii from comment #19) I'd rather see that we're being proactive about maintenance, we already have a lot of ports failing to build, being abandoned upstream etc. Most if not all committers are volunteers with all that entails including time and interest so any proactive maintenance is more than welcome. See https://portsfallout.com/fallout?env=140amd64-default for example Again, it's not like your Musepack media will go lost and Poudriere supports overlays.
(In reply to commit-hook from comment #7) Why has it become "best practice" to NOT involve the MAINTAINERS of changes, or "impending doom" regarding their ports? Why would so much as a "heads up" not be warranted for these changes -- especially sweeping changes? In this case, there is NOT a direct replacement. So why do YOU get to make the final decision on what's best for OUR ports? In this case, there is NOT a one-size-fits-all solution. This is NOT the best way to deal with this situation. Please reverse these commits. --Chris
(In reply to Chris Hutchinson from comment #21) Care to read comment #2 ?
(In reply to Daniel Engberg from comment #22) I already did. > From my side it's OK to remove the port. I guess we should test if > all mentioned ports support decoding through ffmpeg and/or ask the > maintainers if they object to the removal. I agree with this > and/or ask the maintainers if they object to the removal. 100%. But never received anything directly. I only noticed any of this because I'm subscribed to the commit list. So I'm not sure what your intended point was. --Chris
We have "blanket commits" for one of many reasons (including this) and documentation is public. As for your port... https://github.com/jeremyevans/aqualung/commit/0ecc6721d5078c0bc9cae771d485c8d676443c23 (over a year ago by now)
(In reply to Daniel Engberg from comment #24) > We have "blanket commits" for one of many reasons (including this) > and documentation is public. Of course you do. Your tasks would be nearly impossible w/o it. My *only* argument is that affected MAINTAINERs should (must) be included. Otherwise, what's the point of maintaining the port, if not included in (proposed) changes to it? How is this an unreasonable policy? --Chris
I'm also very much against removing working software from the ports tree based solely on "did not get traction" or stalled development nonsense, so long as there are no outstanding build or run-time issues with it, i.e. real problems, which were not demonstrated in this case. I see people getting upset and raged about this, to an extent leaving FreeBSD. This gives us very bad PR and is plain wrong attitude to the ports users out there. I also do not see the rush to remove PCM support from various ports rather than simply disabling it, in case someone steps in to maintain `audio/musepack' during the grace period.
I've contacted upstream regarding the project's current status and received a prompt reply from one of the maintainers, Shy Keidar: > I have updated the musepack.net homepage with some text regarding project > status. > > Some notes: a stable audio format is not a "legacy format" or "legacy > software" just due to the fact that it hasn't received further development. > People still use MP3 (1991), AAC (1997), Musepack (1997), Vorbis (2002) > encoders and decoders, through various libraries. All of these audio > formats are widely supported and well-regarded. Musepack's advantages and > differentiating factors have been demonstrated throughout the years, and > many people still regard it as a high quality alternative and use it > regularly. > > Personally, removing the encoder of an audio format just because it > hasn't received updates in a long time doesn't make sense to me. Anyone > can contribute necessary updates if needed. So it's well alive and maintained, deprecation is undue and should be reverted. Stefan, do you agree? If you no longer have resources to maintain the port, I can pick it up (although it seemingly doesn't require much maintenance, which is another indication of good software that shouldn't be removed for non-technical reasons).
(In reply to Alexey Dokuchaev from comment #27) That statement seems rather odd given that there have been no development in decades, most if not all distributions carries quite a bit of patches and none have been upstreamed for years. That would be a very good starting point though... https://gitlab.archlinux.org/archlinux/packaging/packages/musepack https://sources.debian.org/patches/libmpc/2:0.1~r495-2/ https://src.fedoraproject.org/rpms/libmpcdec/tree/rawhide https://gitweb.gentoo.org/repo/gentoo.git/tree/media-sound/musepack-tools/files https://github.com/openbsd/ports/tree/master/audio/musepack/patches https://build.opensuse.org/package/show/multimedia:libs/musepack
(In reply to Alexey Dokuchaev from comment #27) I think we all agree that the decoding support should remain in ports. I was surprised that musepack support was removed from several ports without any indication that tests were performed if these ports support musepack decoding via other libraries (ffmpeg). Meanwhile at least one port (bug #281614) definitely does not support decoding trough ffmpeg. Now the port uses a bundled version of mpcdec. I'm not a huge fan of bundled libraries. I don't have a strong opinion if we need a musepack encoder in ports. Daniel's list of distros requiring patches is not a convincing argument. It rather shows that arch, debian, fedora, gentoo, openbsd and opensuse don't think it's abandonware. If the answer two the following questions is no, there's probably no reason to bring it back: Did the change break musepack support in any of the affected ports? Are there FreeBSD users that still use musepack for encoding?
(In reply to Stefan Ehmann from comment #29) Just to shed some light on the emulators/mednafen port and bug #281614: emulators/mednafen has always build its own bundled copy of musepack. It was just with my patch to upgrade to version 1.32.1 where I have unbundled most dependencies which are available in the ports tree and as a result audio/musepack got added as a dependency to the emulators/mednafen port.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=b959949b6ce709c37fa5f6ab9f360916f7c00fa4 commit b959949b6ce709c37fa5f6ab9f360916f7c00fa4 Author: Alexey Dokuchaev <danfe@FreeBSD.org> AuthorDate: 2024-09-29 20:51:04 +0000 Commit: Alexey Dokuchaev <danfe@FreeBSD.org> CommitDate: 2024-09-29 20:51:04 +0000 audio/musepack: drop hard-set EXPIRATION_DATE for the time being The port's controversial deprecation status is under dispute and currently being discussed among interested parties. PR: 281025 audio/musepack/Makefile | 1 - 1 file changed, 1 deletion(-)