Bug 281071 - sysutils/fusefs-s3fs quits with SIGABORT on run
Summary: sysutils/fusefs-s3fs quits with SIGABORT on run
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on: 285261
Blocks:
  Show dependency treegraph
 
Reported: 2024-08-25 22:10 UTC by Brett Rickman
Modified: 2025-03-08 20:45 UTC (History)
2 users (show)

See Also:
vvd: maintainer-feedback-
vvd: merge-quarterly+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brett Rickman 2024-08-25 22:10:10 UTC
The currently releases version of this utility immediately aborts on execution. 

This appears to be caused by certain calls to sysconf do not return expected values.

Its been fixed upstream in the release, but won't be available until a version after 1.94. 

The patch below can be applied to the port to correct this:

root@freebsd:/usr/ports/sysutils/fusefs-s3fs # cat files/patch-src_s3fs__util.cpp 
--- src/s3fs_util.cpp.orig      2024-08-25 21:19:25 UTC
+++ src/s3fs_util.cpp
@@ -65,6 +65,7 @@ void init_sysconf_vars()
     // there is no hard limit on the size of the buffer needed to
     // store all the groups returned.
 
+    errno = 0;
     long res = sysconf(_SC_GETPW_R_SIZE_MAX);
     if(0 > res){
         if (errno != 0){
@@ -75,6 +76,7 @@ void init_sysconf_vars()
     }
     max_password_size = res;
 
+    errno = 0;
     res = sysconf(_SC_GETGR_R_SIZE_MAX);
     if(0 > res) {
         if (errno != 0) {

Please let me know next steps. I'll be happy to update the port if needed.
Comment 1 Ivo Marino 2024-11-30 08:18:36 UTC
as reported by upstream a fixed release is available, see https://github.com/s3fs-fuse/s3fs-fuse/issues/2514#issuecomment-2508649212 thanks
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2025-03-08 19:17:09 UTC
Since the port is broken without this update, it is not necessary to wait 2 weeks for the maintainer timeout, especially considering that the maintainer has not committed anything to the ports for a year and a half.
Comment 3 Ivo Marino 2025-03-08 19:52:42 UTC
(In reply to Vladimir Druzenko from comment #2)
Moved over to rclone which is a valid alternative to mount S3 fuse
Comment 4 commit-hook freebsd_committer freebsd_triage 2025-03-08 20:40:52 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e26ad835aecd0ffb22bc9f3dec51e097e7138a1a

commit e26ad835aecd0ffb22bc9f3dec51e097e7138a1a
Author:     Rafael Grether <devnull@apt322.org>
AuthorDate: 2025-03-08 20:25:31 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-03-08 20:25:31 +0000

    filesystems/s3fs: Update 1.92 → 1.95, unbreak - fix coredump

    Changelogs:
    https://github.com/s3fs-fuse/s3fs-fuse/releases/tag/v1.93
    https://github.com/s3fs-fuse/s3fs-fuse/releases/tag/v1.94
    https://github.com/s3fs-fuse/s3fs-fuse/releases/tag/v1.95

    Improve port:
    - remove GNU_CONFIGURE_MANPREFIX;
    - pet portclippy;
    - improve description.

    PR:             285261 281071
    Approved by:    dmgk (maintainer, timeout > 6 months, implicit - unbreak)
    MFH:            2025Q1

 filesystems/s3fs/Makefile                              |  7 ++-----
 filesystems/s3fs/distinfo                              |  6 +++---
 filesystems/s3fs/files/patch-test_mknod__test.c (gone) | 13 -------------
 filesystems/s3fs/pkg-descr                             |  5 +++--
 4 files changed, 8 insertions(+), 23 deletions(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2025-03-08 20:43:54 UTC
A commit in branch 2025Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=36ce604a8ee4d921ca8aff0bbb83e3a209fa3905

commit 36ce604a8ee4d921ca8aff0bbb83e3a209fa3905
Author:     Rafael Grether <devnull@apt322.org>
AuthorDate: 2025-03-08 20:25:31 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-03-08 20:43:11 +0000

    filesystems/s3fs: Update 1.92 → 1.95, unbreak - fix coredump

    Changelogs:
    https://github.com/s3fs-fuse/s3fs-fuse/releases/tag/v1.93
    https://github.com/s3fs-fuse/s3fs-fuse/releases/tag/v1.94
    https://github.com/s3fs-fuse/s3fs-fuse/releases/tag/v1.95

    Improve port:
    - remove GNU_CONFIGURE_MANPREFIX;
    - pet portclippy;
    - improve description.

    PR:             285261 281071
    Approved by:    dmgk (maintainer, timeout > 6 months, implicit - unbreak)
    MFH:            2025Q1

    (cherry picked from commit e26ad835aecd0ffb22bc9f3dec51e097e7138a1a)

 filesystems/s3fs/Makefile                              |  7 ++-----
 filesystems/s3fs/distinfo                              |  6 +++---
 filesystems/s3fs/files/patch-test_mknod__test.c (gone) | 13 -------------
 filesystems/s3fs/pkg-descr                             |  5 +++--
 4 files changed, 8 insertions(+), 23 deletions(-)