Bug 281124 - net/kea: update patch for building with libc++ 19
Summary: net/kea: update patch for building with libc++ 19
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-29 11:42 UTC by Dimitry Andric
Modified: 2024-08-29 19:56 UTC (History)
1 user (show)

See Also:
apevnev: maintainer-feedback+


Attachments
net/kea: update patch for building with libc++ 19 (1.97 KB, patch)
2024-08-29 11:42 UTC, Dimitry Andric
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2024-08-29 11:42:28 UTC
This is a follow-up for bug 280696.

In https://gitlab.isc.org/isc-projects/kea/-/merge_requests/2410,
Francis Dupont noted there were some errors in the unit tests.

These were due to mistakes on my side, so I now made sure all the unit
tests pass (they silently require GoogleTest!), and updated the upstream
merge request. I hope this goes in soon, but it all seems to take a long
time.
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2024-08-29 11:42:50 UTC
Created attachment 253161 [details]
net/kea: update patch for building with libc++ 19
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-08-29 18:30:37 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f3bf83db98662c18e96e4d6175751c8f38c3e14a

commit f3bf83db98662c18e96e4d6175751c8f38c3e14a
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-08-29 08:44:30 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2024-08-29 18:28:19 +0000

    net/kea: update patch for building with libc++ 19

    In https://gitlab.isc.org/isc-projects/kea/-/merge_requests/2410,
    Francis Dupont noted there were some errors in the unit tests.

    These were due to mistakes on my side, so I now made sure all the unit
    tests pass (they silently require GoogleTest!), and updated the upstream
    merge request. I hope this goes in soon, but it all seems to take a long
    time.

    PR:             281124
    Approved by:    apevnev@me.com (maintainer)
    MFH:            2024Q3

 net/kea/files/patch-src_lib_dns_name.cc | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-08-29 19:01:41 UTC
A commit in branch 2024Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5dc0fd9c632c59a024873badffad031113a4527d

commit 5dc0fd9c632c59a024873badffad031113a4527d
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-08-29 08:44:30 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2024-08-29 19:00:50 +0000

    net/kea: update patch for building with libc++ 19

    In https://gitlab.isc.org/isc-projects/kea/-/merge_requests/2410,
    Francis Dupont noted there were some errors in the unit tests.

    These were due to mistakes on my side, so I now made sure all the unit
    tests pass (they silently require GoogleTest!), and updated the upstream
    merge request. I hope this goes in soon, but it all seems to take a long
    time.

    PR:             281124
    Approved by:    apevnev@me.com (maintainer)
    MFH:            2024Q3

    (cherry picked from commit f3bf83db98662c18e96e4d6175751c8f38c3e14a)

 net/kea/files/patch-src_lib_dns_name.cc | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)