Bug 281166 - net-p2p/namecoin: remove dependency on expired graphics/svg2png
Summary: net-p2p/namecoin: remove dependency on expired graphics/svg2png
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-31 15:54 UTC by Chad Jacob Milios
Modified: 2024-09-14 00:16 UTC (History)
3 users (show)

See Also:
milios: maintainer-feedback+


Attachments
git diff net-p2p/namecoin (2.24 KB, patch)
2024-08-31 15:54 UTC, Chad Jacob Milios
milios: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chad Jacob Milios 2024-08-31 15:54:13 UTC
Created attachment 253218 [details]
git diff net-p2p/namecoin

Remove build dependency on graphics/svg2png
Remove svg icon from GitHub download
Add same png icon from Same.Name
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2024-09-01 01:43:09 UTC
If you are maintainer then set maintainer-approval for patch and maintainer-feedback for this PR.
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2024-09-01 06:16:25 UTC
Can you please also update it so we're not shipping a ~1½ year old version?
Comment 3 Chad Jacob Milios 2024-09-01 13:15:05 UTC
(In reply to Daniel Engberg from comment #2)

A bona fide update is truly on its way. This version is good in production and its worth committing this port update separately.

The recent versions throughout this past year actually have in my opinion been rather sketchy of reliability and somewhat questionable of security. I considered submitting -devel port(s) but opted it wasnt worth more clutter what with this already being a trio with its slave ports.
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2024-09-13 17:15:11 UTC
Move lines:
MASTER_SITES+= https://same.name/static/:icon
DISTFILES+=    namecoin128.c99d628dd26b.png:icon
EXTRACT_ONLY=  ${DISTFILE_DEFAULT}
after CATEGORIES.
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-09-13 19:46:14 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=253130fe8be07170105cb971966e46ac01578cf9

commit 253130fe8be07170105cb971966e46ac01578cf9
Author:     Chad Jacob Milios <milios@ccsys.com>
AuthorDate: 2024-09-13 19:18:16 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-09-13 19:19:48 +0000

    net-p2p/namecoin: Remove dependency on expired graphics/svg2png

    - Remove build dependency on graphics/svg2png
    - Remove svg icon from GitHub download
    - Add same png icon from Same.Name

    PR:     281166

 net-p2p/namecoin/Makefile | 15 ++++++---------
 net-p2p/namecoin/distinfo |  6 +++---
 2 files changed, 9 insertions(+), 12 deletions(-)
Comment 6 Vladimir Druzenko freebsd_committer freebsd_triage 2024-09-13 19:47:42 UTC
Thanks.

But port need improvements - portclippy show several warnings, there are libs in LIB_DEPENDS which not linked.
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-09-14 00:16:36 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d61b0dfce60812a0bed188ede981439aae701b50

commit d61b0dfce60812a0bed188ede981439aae701b50
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2024-09-14 00:09:42 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-09-14 00:15:08 +0000

    net-p2p/namecoin: Replace CP with INSTALL_DATA

    PR:             281166
    Reported by:    makc (via email)
    Fixes:          253130fe8be0 (Remove dependency on expired graphics/svg2png)

 net-p2p/namecoin/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)