Bug 281216 - lang/emilua: Update to 0.10.1
Summary: lang/emilua: Update to 0.10.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL: https://docs.emilua.org/api/0.10/chan...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-03 03:25 UTC by Valter Nazianzeno
Modified: 2024-09-03 22:59 UTC (History)
3 users (show)

See Also:


Attachments
Diff for 0.10.1 (29.90 KB, patch)
2024-09-03 03:25 UTC, Valter Nazianzeno
manipuladordedados: maintainer-approval+
Details | Diff
[FIXED] Diff for 0.10.1 (30.18 KB, patch)
2024-09-03 20:45 UTC, Valter Nazianzeno
manipuladordedados: maintainer-approval+
Details | Diff
[FIXED] Diff for 0.10.1 (30.25 KB, patch)
2024-09-03 22:11 UTC, Valter Nazianzeno
manipuladordedados: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Valter Nazianzeno 2024-09-03 03:25:02 UTC
Created attachment 253282 [details]
Diff for 0.10.1
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2024-09-03 19:13:24 UTC
Don't need:
IGNORE_FreeBSD_12=     not supported by Emilua
12.x reached EoL 9 months ago.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-09-03 19:19:58 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=94796bd4796b8817d30e438cba9cf93f6bdcf5c2

commit 94796bd4796b8817d30e438cba9cf93f6bdcf5c2
Author:     Valter Nazianzeno <manipuladordedados@gmail.com>
AuthorDate: 2024-09-03 19:13:46 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-09-03 19:13:46 +0000

    lang/emilua: Update 0.9.0 → 0.10.1

    Changelog:      https://docs.emilua.org/api/0.10/changelog.html
    PR:             281216

 lang/emilua/Makefile                               |  10 +-
 lang/emilua/distinfo                               |   6 +-
 .../files/patch-subprojects_asio_meson.build       |  17 +-
 .../files/patch-test_builtin__modules1.cpp (new)   |  16 +
 lang/emilua/pkg-plist                              | 632 +--------------------
 5 files changed, 26 insertions(+), 655 deletions(-)
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2024-09-03 19:23:56 UTC
Thanks.
Comment 4 Chad Jacob Milios 2024-09-03 19:38:44 UTC
I came here just to say the error message was confusing:

===>  emilua-0.10.1 not supported by Emilua.
*** Error code 1

by the way i commented out the IGNORE line just to see if it would build and this built fine for me on 13.3-RELEASE-p5. i havent used it yet however. maybe fbsd13 support is worth testing out again with this port update?

i hardly ever used lua and was only just now thinking of trying this out so i wouldnt know how to begin and really put it thru its paces. i'd be happy to test this v0.10.1 on fbsd/amd64 v13.3 further with guidance or suggestion
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2024-09-03 20:00:22 UTC
(In reply to Chad Jacob Milios from comment #4)
Remove "IGNORE_FreeBSD_13=	not supported by Emilua" and try to build again.
Or better update to 14.1. :-)
Comment 6 Valter Nazianzeno 2024-09-03 20:45:31 UTC
Created attachment 253308 [details]
[FIXED] Diff for 0.10.1
Comment 7 Chad Jacob Milios 2024-09-03 20:48:37 UTC
(In reply to Vladimir Druzenko from comment #5)

i'm sayin i already did that and it builds just fine on my 13.3-RELEASE-p5/amd64.

not only does it build, i have since successfully run a "Hello World" without dumping core

however, that exhausts the full extent of my Lua prowess. i am out of my depth to go so far as to say "it works" since i have no prior experience with this package to compare nor any ambitious Lua project to test. i am not at all familiar with Emilua or its set of features but as far as i know this sure LGTM
Comment 8 Vladimir Druzenko freebsd_committer freebsd_triage 2024-09-03 21:23:57 UTC
(In reply to Valter Nazianzeno from comment #6)
Build fine on 13.3 amd64 for me too.
I suggest to remove "IGNORE_FreeBSD_13=	not supported by Emilua" too.
Comment 9 Valter Nazianzeno 2024-09-03 22:11:44 UTC
Created attachment 253312 [details]
[FIXED] Diff for 0.10.1
Comment 10 Valter Nazianzeno 2024-09-03 22:13:13 UTC
(In reply to Chad Jacob Milios from comment #7)

Thank you for taking the time to test the program! Here is a test example code designed for the latest version of the software.
https://pastebin.com/jxd3XsiS

(In reply to Vladimir Druzenko from comment #8)

Thanks.
Comment 11 Chad Jacob Milios 2024-09-03 22:19:29 UTC
(In reply to Valter Nazianzeno from comment #10)

jedi@rick:~ % uname -a
FreeBSD rick.lab.us.org 13.3-RELEASE-p5 FreeBSD 13.3-RELEASE-p5 releng/13.3-n257446-f5a50714b4c9 NUOS amd64

jedi@rick:~ % emilua jxd3XsiS.lua 
ec22d2ca662ba4904e0962bd36b7eec265101a5160ce118d354a98107579df6dcf39133fe93b37b5c388619717b6db8572e10498631b42325949e5f25480fe74

jedi@rick:~ % echo $?
0

LGTM! Thank you for your work and guidance
Comment 12 Valter Nazianzeno 2024-09-03 22:25:49 UTC
I believe this commit restored support for FreeBSD 13:
https://gitlab.com/emilua/emilua/-/commit/8e7bf38a7d0080af54f1f5b1fd29468dba7f708b

clearenv() is exclusive to FreeBSD 14.
Comment 13 commit-hook freebsd_committer freebsd_triage 2024-09-03 22:59:23 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0ea4707a5e8e1a4beaaec820cd3a0991b590fe3a

commit 0ea4707a5e8e1a4beaaec820cd3a0991b590fe3a
Author:     Valter Nazianzeno <manipuladordedados@gmail.com>
AuthorDate: 2024-09-03 22:56:03 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-09-03 22:56:03 +0000

    lang/emilua: Remove IGNORE_FreeBSD_13

    Port build and work without errors on 13.3

    PR:             281216
    Tested by:      Chad Jacob Milios <milios@ccsys.com>

 lang/emilua/Makefile | 2 --
 1 file changed, 2 deletions(-)
Comment 14 Vladimir Druzenko freebsd_committer freebsd_triage 2024-09-03 22:59:43 UTC
Committed, thanks!