Bug 281228 - devel/rhtvision: Fails to build with GCC 14: error: implicit declaration of function 'strcmp' [-Wimplicit-function-declaration]
Summary: devel/rhtvision: Fails to build with GCC 14: error: implicit declaration of f...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Lorenzo Salvadore
URL: https://pkg-status.freebsd.org/gohan0...
Keywords:
Depends on:
Blocks: 281091
  Show dependency tree / graph
 
Reported: 2024-09-03 12:55 UTC by Lorenzo Salvadore
Modified: 2024-09-05 14:04 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lorenzo Salvadore freebsd_committer freebsd_triage 2024-09-03 12:55:20 UTC 
Build fails with GCC 14. This blocks GCC_DEFAULT update to GCC 14.

gcc14  -I../include        -O2 -pipe  -I/usr/local/include -fstack-protector-strong -Wl,-rpath=/usr/local/lib/gcc14 -fno-strict-aliasing  -c ../compat/getopt.c -o ../makes/obj/getopt.o
../compat/getopt.c: In function 'CLY_getopt_internal':
../compat/getopt.c:412:34: error: implicit declaration of function 'strcmp' [-Wimplicit-function-declaration]
  412 |       if (CLY_optind != argc && !strcmp (argv[CLY_optind], "--"))

Full log: https://pkg-status.freebsd.org/gohan04/data/140amd64-default-foo/2024-08-29_19h57m48s/logs/errors/rhtvision-2.2.1.1_11.log

Useful link: https://gcc.gnu.org/gcc-14/porting_to.html
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-09-05 14:02:13 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1a36157435bcbe92f76d28ca3a7ce85fa2925bc9

commit 1a36157435bcbe92f76d28ca3a7ce85fa2925bc9
Author:     Lorenzo Salvadore <salvadore@FreeBSD.org>
AuthorDate: 2024-09-05 10:08:25 +0000
Commit:     Lorenzo Salvadore <salvadore@FreeBSD.org>
CommitDate: 2024-09-05 14:00:57 +0000

    devel/rhtvision: Fix build with GCC 14

    GCC 14 has transformed some warnings into errors: revert them to simple
    warnings.

    PR:             281228
    Reported by:    exp-run (antoine)

 devel/rhtvision/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)