Bug 281241 - multimedia/xanim: Fails to build with GCC 14: error: type of 'blks' defaults to 'int' [-Wimplicit-int]
Summary: multimedia/xanim: Fails to build with GCC 14: error: type of 'blks' defaults ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dirk Meyer
URL: https://pkg-status.freebsd.org/gohan0...
Keywords:
Depends on:
Blocks: 281091
  Show dependency tree / graph
 
Reported: 2024-09-03 13:48 UTC by Lorenzo Salvadore
Modified: 2024-09-04 16:41 UTC (History)
1 user (show)

See Also:
dinoex: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lorenzo Salvadore freebsd_committer freebsd_triage 2024-09-03 13:48:52 UTC 
Build fails with GCC 14. This blocks GCC_DEFAULT update to GCC 14.

gcc14  -O2 -pipe  -fstack-protector-strong -Wl,-rpath=/usr/local/lib/gcc14 -fno-strict-aliasing      -I/usr/local/include/X11  -I.    -I/usr/local/include    -DCSRG_BASED  -DFUNCPROTO=15 -DNARROWPROTO     -DXSHM -DXMBUF     		-DXA_DLL -DXA_PRINT -DXA_DLL_PATH=\"/usr/local/lib/X11/xanim\"   -DXA_GSM -DXA_LINUX_AUDIO -DXA_PETUNIA -DXA_KPCD  -c xa_color.c -o xa_color.o
xa_color.c: In function 'YUV2x2_Blk_Func':
xa_color.c:2607:7: error: type of 'blks' defaults to 'int' [-Wimplicit-int]
 2607 | void *YUV2x2_Blk_Func(image_type,blks,dith_flag)
      |       ^~~~~~~~~~~~~~~
*** [xa_color.o] Error code 1

make: stopped in /wrkdirs/usr/ports/multimedia/xanim/work/xanim2920
1 error

make: stopped in /wrkdirs/usr/ports/multimedia/xanim/work/xanim2920
*** Error code 1

Stop.
make: stopped in /usr/ports/multimedia/xanim
=>> Cleaning up wrkdir

Full log: https://pkg-status.freebsd.org/gohan04/data/140amd64-default-foo/2024-08-29_19h57m48s/logs/errors/xanim-2.92.0_11.log

Useful link: https://gcc.gnu.org/gcc-14/porting_to.html
Comment 1 Dirk Meyer freebsd_committer freebsd_triage 2024-09-03 19:58:05 UTC 
will be fixed
build of gcc14 will take a few days.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-09-04 16:41:31 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d5debff4b735a93924b68212e6b960533c613016

commit d5debff4b735a93924b68212e6b960533c613016
Author:     Dirk Meyer <dinoex@FreeBSD.org>
AuthorDate: 2024-09-04 16:40:36 +0000
Commit:     Dirk Meyer <dinoex@FreeBSD.org>
CommitDate: 2024-09-04 16:40:36 +0000

    multimedia/xanim: fix build with gcc14

    cleanup MASTER_SITES
    cleanup pkg-descr
    reformat patches
    PR: 281241

 multimedia/xanim/Makefile                     | 11 +++----
 multimedia/xanim/files/patch-Imakefile        | 18 +++++-----
 multimedia/xanim/files/patch-xa_audio.h       |  6 ++--
 multimedia/xanim/files/patch-xa_color.c (new) | 10 ++++++
 multimedia/xanim/files/patch-xa_fli.c (new)   | 11 +++++++
 multimedia/xanim/files/patch-xa_g72x.c (new)  | 11 +++++++
 multimedia/xanim/files/patch-xa_input.c       |  8 ++---
 multimedia/xanim/files/patch-xa_vid_codec.c   | 18 +++++++---
 multimedia/xanim/pkg-descr                    | 47 ++++-----------------------
 9 files changed, 72 insertions(+), 68 deletions(-)