Bug 281299 - devel/root: Fix runtime issues related to LLVM modulemaps
Summary: devel/root: Fix runtime issues related to LLVM modulemaps
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Nuno Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-05 16:57 UTC by Erik Jensen
Modified: 2024-09-14 13:36 UTC (History)
2 users (show)

See Also:


Attachments
Port patch to fix runtime issues (9.98 KB, patch)
2024-09-05 16:57 UTC, Erik Jensen
erik: maintainer-approval+
Details | Diff
Port patch to fix runtime issues (372.59 KB, patch)
2024-09-05 17:03 UTC, Erik Jensen
erik: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Jensen 2024-09-05 16:57:44 UTC
Created attachment 253356 [details]
Port patch to fix runtime issues

ROOT has been building fine on recent versions, but runtime has turned out to be fragile.

The attached patch fixes the issue and should be more robust in the future.
Comment 1 Erik Jensen 2024-09-05 17:03:22 UTC
Created attachment 253357 [details]
Port patch to fix runtime issues

I overlooked some files which should have been marked for deletion in the previous attachment. This has been fixed in the current attachment.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-09-14 13:32:19 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5407a6cd3ef3d18158197c2d5269bfb8033578b0

commit 5407a6cd3ef3d18158197c2d5269bfb8033578b0
Author:     Erik Jensen <erik@tenku.dk>
AuthorDate: 2024-09-14 13:30:34 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2024-09-14 13:31:39 +0000

    devel/root: Fix runtime issues related to LLVM modulemaps

    ROOT has been building fine on recent versions, but runtime has turned
    out to be fragile.

    PR:             281299

 devel/root/Makefile                                |   21 +-
 devel/root/distinfo                                |    2 +-
 ...ib_Interpreter_Interpreter.cpp.15aarch64 (gone) |   11 -
 ...ng-include-cling-std__fbsd13.2.modulemap (gone) | 1097 ----------
 ...ng-include-cling-std__fbsd13.3.modulemap (gone) | 2072 -------------------
 ...ng-include-cling-std__fbsd14.0.modulemap (gone) | 1729 ----------------
 ...ng-include-cling-std__fbsd14.1.modulemap (gone) |    1 -
 ...ng-include-cling-std__fbsd15.0.modulemap (gone) | 2094 --------------------
 .../files/patch-cmake_modules_SetUpFreeBSD.cmake   |    2 +-
 .../files/patch-core_clingutils_CMakeLists.txt     |   27 +-
 ...interpreter_cling_lib_Interpreter_CIFactory.cpp |   24 +-
 ...terpreter_cling_lib_Interpreter_Interpreter.cpp |   27 +-
 devel/root/pkg-plist                               |    3 +-
 13 files changed, 49 insertions(+), 7061 deletions(-)
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2024-09-14 13:36:33 UTC
Hello!

Nice work on port cleanup.

Build tested OK:

(amd64)
main-n272139-967b3685a44e
14.1-p4
13.3-p6

(i386)
14.1-p4

Will do aarch64 tests later and reopen PR if corrections are needed.

Committed, thank you!