Bug 281326 - devel/upp: Fails to build with freetype2 2.13.3
Summary: devel/upp: Fails to build with freetype2 2.13.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks: 281316
  Show dependency tree / graph
 
Reported: 2024-09-07 05:09 UTC by Daniel Engberg
Modified: 2024-09-17 19:00 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (m.sund)

Attachments
Proposed patch (1.35 KB, patch)
2024-09-07 22:54 UTC, lightside 		lightside: maintainer-approval? (m.sund)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-09-07 05:09:46 UTC 
https://pdr2.bofh.network/data/141-diizzy/2024-09-06_00h03m58s/logs/errors/upp-15260_2.log

Given that it's been "unmaintained" for quite some time and outdated I'm leaning towards removing the port unless someone respons and updates it.
Comment 1 lightside 2024-09-07 22:54:45 UTC 
Created attachment 253411 [details]
Proposed patch

Hello.

The attached patch file may fix build error for uppsrc/Draw/FontFc.cpp file. Please check it.
Based on following upstream commit:
Draw: Workaround for backwards incompatibility of FT_Outline
https://github.com/ultimatepp/ultimatepp/commit/68139e354876013046aac0d1699d7b61ce055d53
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2024-09-14 08:05:16 UTC 
Hi,

This fixes the build on my end, thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-09-17 18:59:57 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bd21b799f5d2ca90452b2c4279d2621968cb8b8f

commit bd21b799f5d2ca90452b2c4279d2621968cb8b8f
Author:     lightside <lightside@gmx.com>
AuthorDate: 2024-09-17 18:50:07 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-09-17 18:50:12 +0000

    devel/upp: Fix build with freetype2 2.13.3

    Based on upstream commit 68139e354876013046aac0d1699d7b61ce055d53

    Reference:
    https://github.com/ultimatepp/ultimatepp/commit/68139e354876013046aac0d1699d7b61ce055d53

    PR:             281326
    Approved by:    portmgr (blanket, build fix)

 devel/upp/Makefile                                 |  2 +-
 devel/upp/files/patch-uppsrc_Draw_FontFc.cpp (new) | 28 ++++++++++++++++++++++
 2 files changed, 29 insertions(+), 1 deletion(-)
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2024-09-17 19:00:59 UTC 
Committed, thanks for the patch!