Created attachment 253394 [details] update to 0.4.0 Changes: https://github.com/SnowflakePowered/librashader/releases/tag/librashader-v0.4.0
Really depends on rust-nightly? Would the basic rust not be good?
(In reply to Zsolt Udvari from comment #1) > Really depends on rust-nightly? Would the basic rust not be good? Unfortunately it does depend on features only present in rust-nightly. Upstream is tracking its requirements for building with stable rust in https://github.com/SnowflakePowered/librashader/issues/55. Still not there yet...
(In reply to Stefan Schlosser from comment #2) Okay, thanks!
Upstream has just released a bugfix release 0.4.1. I would like to update my patch to this version. Will provide an updated patch soon.
Created attachment 253434 [details] update to 0.4.1 Changes: https://github.com/SnowflakePowered/librashader/releases/tag/librashader-v0.4.0 https://github.com/SnowflakePowered/librashader/releases/tag/librashader-v0.4.1 I have updated to 0.4.1. The difference between 0.4.0 and 0.4.1 is solely in librashader itself, the cargo dependencies stay the same.
The emulators/ares port doesn't build with new librashader: Compiling ares/a26/controller/controller.cpp ... In file included from ../ruby/ruby.cpp:31: In file included from ../ruby/video/video.cpp:10: In file included from ../ruby/video/glx.cpp:1: In file included from ../ruby/video/opengl/opengl.hpp:21: /usr/local/include/librashader/librashader_ld.h:1458:9: error: assigning to 'PFN_libra_gl_filter_chain_get_param' (aka '_libra_error *(*)(_filter_chain_gl *const *, const char *, float *)') from incompatible type 'libra_error_t (libra_gl _filter_chain_t *, const char *, float *)' (aka '_libra_error *(_filter_chain_gl **, const char *, float *)'): type mismatch at 1st parameter ('const libra_gl_filter_chain_t *' (aka '_filter_chain_gl *const *') vs 'libra_gl_filter_chain_ t *' (aka '_filter_chain_gl **')) 1458 | __librashader__noop_gl_filter_chain_get_param; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. gmake[1]: *** [../ruby/GNUmakefile:134: obj/ruby.o] Error 1 gmake[1]: *** Waiting for unfinished jobs.... gmake[1]: Leaving directory '/wrkdirs/usr/ports/emulators/ares/work/ares-140/desktop-ui' gmake: *** [GNUmakefile:4: all] Error 2 Could you please check?
Ah sorry, that's what I get for not properly testing the dependent port... I'm currently investigating the problem and will report back soon.
Created attachment 253539 [details] update to 0.4.1 I opened a PR upstream for this problem: https://github.com/SnowflakePowered/librashader/pull/118 My updated patch uses this PR commit. Compilation of emulators/ares is successful with my new patch.
According to the recent comments from upstream in the mentioned PR, there is a little bit more to sort out before we can continue updating the port confidently.
Upstream will revert the change which caused the incompatibility between the function signatures. It was not intended. So there's probably a new bugfix release 0.4.2 around the corner. We should wait for this bugfix.
Created attachment 253553 [details] update to 0.4.2 Changes: https://github.com/SnowflakePowered/librashader/releases/tag/librashader-v0.4.0 https://github.com/SnowflakePowered/librashader/releases/tag/librashader-v0.4.1 https://github.com/SnowflakePowered/librashader/releases/tag/librashader-v0.4.2 Build of emulators/ares is successful with it.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=9f032e6cbf0b1374fd5e3038322b15697789efce commit 9f032e6cbf0b1374fd5e3038322b15697789efce Author: Stefan Schlosser <bsdcode@disroot.org> AuthorDate: 2024-09-14 11:52:33 +0000 Commit: Zsolt Udvari <uzsolt@FreeBSD.org> CommitDate: 2024-09-14 11:53:51 +0000 devel/librashader: Update to 0.4.2 Changes: https://github.com/SnowflakePowered/librashader/releases/tag/librashader-v0.4.0 https://github.com/SnowflakePowered/librashader/releases/tag/librashader-v0.4.1 https://github.com/SnowflakePowered/librashader/releases/tag/librashader-v0.4.2 PR: 281331 Approved by: submitter is maintainer devel/librashader/Makefile | 2 +- devel/librashader/Makefile.crates | 76 +++++++++--------- devel/librashader/distinfo | 158 ++++++++++++++++++++------------------ 3 files changed, 127 insertions(+), 109 deletions(-)
Thanks for your work! Committed, thanks!