Bug 281383 - net-p2p/ethash: compilation fix
Summary: net-p2p/ethash: compilation fix
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Muhammad Moinur Rahman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-09 06:55 UTC by Mark Evenson
Modified: 2024-09-13 05:02 UTC (History)
2 users (show)

See Also:
vvd: maintainer-feedback? (bofh)


Attachments
Find the byteorder(9) cpp definitions under FreeBSD (584 bytes, patch)
2024-09-09 06:55 UTC, Mark Evenson
no flags Details | Diff
[Rev 2] ethhash cpp definitions for FreeBSD (538 bytes, patch)
2024-09-09 06:57 UTC, Mark Evenson
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Evenson 2024-09-09 06:55:03 UTC
Created attachment 253447 [details]
Find the byteorder(9) cpp definitions under FreeBSD

Slight correction to finding the bswap{32,64} routines with RELEASE-14.1.
Comment 1 Mark Evenson 2024-09-09 06:57:27 UTC
Created attachment 253448 [details]
[Rev 2] ethhash cpp definitions for FreeBSD
Comment 2 Mark Evenson 2024-09-09 06:58:39 UTC
Comment on attachment 253447 [details]
Find the byteorder(9) cpp definitions under FreeBSD

[Rev 1] 

Too optimistic: no other BSD than Free has been tested.
Comment 3 Mark Evenson 2024-09-09 06:59:25 UTC
Comment on attachment 253447 [details]
Find the byteorder(9) cpp definitions under FreeBSD

[Rev 1]
Comment 4 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2024-09-12 13:51:25 UTC
This is actually not the exact way of submitting a patch. The patch should be in respect to the ports tree and not the dist itself. Additionally the patch should be in contrast to head and not any other branches. For this case it should be like:

# cd /usr/ports/net-p2p/ethash
# make patch
# cp work/ethash-1.0.1/lib/ethash/endianness.hpp{,.orig}
# $EDITOR work/ethash-1.0.1/lib/ethash/endianness.hpp
# make makepatch
# git add .
# git commit
# git format-patch -1 HEAD

However I am taking care of this and no need to submit another patch for now.
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-09-12 15:11:08 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bae28b2eaf9d16d662e3a81b036b5731c66ae642

commit bae28b2eaf9d16d662e3a81b036b5731c66ae642
Author:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
AuthorDate: 2024-09-12 13:51:36 +0000
Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
CommitDate: 2024-09-12 15:09:46 +0000

    net-p2p/ethash: Fix build on HEAD

    PR:             281383
    Reported by:    evenson.not.org@gmail.com

 net-p2p/ethash/files/patch-lib_ethash_endianness.hpp | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)
Comment 6 Mark Evenson 2024-09-13 05:02:34 UTC
(In reply to Muhammad Moinur Rahman from comment #4)
Thanks for the clear instructions for submitting patches to port.  I will follow next time!