Clang 19 is more strict about errors in member functions, which results in: /wrkdirs/usr/ports/math/dune-common/work/dune-common-df65b1282ea89ad40d2cb6565983f7e633ccce31/dune/common/parallel/remoteindices.hh:936:58: error: reference to non-static member function must be called 936 | return localIndex_==ri.localIndex_ && attribute_==ri.attribute; | ~~~^~~~~~~~~ This is a typo, which has been fixed by upstream in <https://gitlab.dune-project.org/core/dune-common/-/commit/d36ce92a18>.
Created attachment 253479 [details] math/dune-common: fix build with clang 19
Thanks for the patch. Approved, please commit it.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=30248bf4ec840a773c7f7977df69a10c4b531336 commit 30248bf4ec840a773c7f7977df69a10c4b531336 Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2024-09-10 09:29:49 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2024-09-10 19:46:22 +0000 math/dune-common: fix build with clang 19 Clang 19 is more strict about errors in member functions, which results in: /wrkdirs/usr/ports/math/dune-common/work/dune-common-df65b1282ea89ad40d2cb6565983f7e633ccce31/dune/common/parallel/remoteindices.hh:936:58: error: reference to non-static member function must be called 936 | return localIndex_==ri.localIndex_ && attribute_==ri.attribute; | ~~~^~~~~~~~~ This is a typo, which has been fixed by upstream in <https://gitlab.dune-project.org/core/dune-common/-/commit/d36ce92a18>. PR: 281412 Approved by: yuri (maintainer) MFH: 2024Q3 math/dune-common/Makefile | 3 +++ math/dune-common/distinfo | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-)
A commit in branch 2024Q3 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=600d36196cdeb85cd97ee71ff5b9f9caf93e236d commit 600d36196cdeb85cd97ee71ff5b9f9caf93e236d Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2024-09-10 09:29:49 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2024-09-10 19:49:01 +0000 math/dune-common: fix build with clang 19 Clang 19 is more strict about errors in member functions, which results in: /wrkdirs/usr/ports/math/dune-common/work/dune-common-df65b1282ea89ad40d2cb6565983f7e633ccce31/dune/common/parallel/remoteindices.hh:936:58: error: reference to non-static member function must be called 936 | return localIndex_==ri.localIndex_ && attribute_==ri.attribute; | ~~~^~~~~~~~~ This is a typo, which has been fixed by upstream in <https://gitlab.dune-project.org/core/dune-common/-/commit/d36ce92a18>. PR: 281412 Approved by: yuri (maintainer) MFH: 2024Q3 (cherry picked from commit 30248bf4ec840a773c7f7977df69a10c4b531336) math/dune-common/Makefile | 3 +++ math/dune-common/distinfo | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-)