Bug 281455 - net/krakend-ce: update 2.7.0 → 2.7.1
Summary: net/krakend-ce: update 2.7.0 → 2.7.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL: https://github.com/krakend/krakend-ce...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-12 09:53 UTC by Älven
Modified: 2024-09-27 19:58 UTC (History)
2 users (show)

See Also:
alster: maintainer-feedback+


Attachments
[PATCH] net/krakend-ce: update 2.7.0 → 2.7.1 (2.50 KB, patch)
2024-09-12 09:53 UTC, Älven
alster: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Älven 2024-09-12 09:53:11 UTC
Created attachment 253514 [details]
[PATCH] net/krakend-ce: update 2.7.0 → 2.7.1
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2024-09-24 10:20:42 UTC
Build fails on armv7 FreeBSD 14:

# github.com/krakendio/krakend-amqp/v2
vendor/github.com/krakendio/krakend-amqp/v2/consumer.go:47:20: cannot use math.MaxInt64 (untyped int constant 9223372036854775807) as int value in assignment (overflows)
vendor/github.com/krakendio/krakend-amqp/v2/producer.go:64:20: cannot use math.MaxInt64 (untyped int constant 9223372036854775807) as int value in assignment (overflows)
golang.org/x/sync/errgroup
github.com/hashicorp/golang-lru/simplelru
github.com/luraproject/lura/v2/async
# github.com/luraproject/lura/v2/async
vendor/github.com/luraproject/lura/v2/async/asyncagent.go:85:34: cannot use math.MaxInt64 (untyped int constant 9223372036854775807) as int value in assignment (overflows)

Please check.  Shall I hold the update or would you like to proceed and fix this later?
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-09-25 06:31:07 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d313252e4dda12b481a4d0fba69bd62d651344b1

commit d313252e4dda12b481a4d0fba69bd62d651344b1
Author:     Älven <alster@vinterdalen.se>
AuthorDate: 2024-09-22 10:27:46 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2024-09-25 06:29:01 +0000

    net/krakend-ce: update to 2.7.1

     - broken on armv7

    Changelog: https://github.com/krakend/krakend-ce/releases

    PR:             281455
    Event:          EuroBSDcon 2024

 net/krakend-ce/Makefile  |  3 ++-
 net/krakend-ce/distinfo  | 10 +++++-----
 net/krakend-ce/pkg-descr | 10 +++++-----
 3 files changed, 12 insertions(+), 11 deletions(-)
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2024-09-25 06:34:07 UTC
Thank you for your contribution.
Comment 4 Älven 2024-09-27 05:28:27 UTC
Thank you! Exactly what I would vote for.

P.S. May I even add armv7 to NOT_FOR_ARCHS, just as i386 and likely for the same reason?
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2024-09-27 09:27:34 UTC
(In reply to Älven from comment #4)

NOT_FOR_ARCHS is for architectures for which the code is not designed and will never work.  BROKEN is for architectures for which the code is broken, but could be fixed.  Which of the two is it?
Comment 6 Älven 2024-09-27 19:58:08 UTC
Thank you for the explanation. 

(In reply to Robert Clausecker from comment #5)
> Which of the two is it?

Don't know for sure. Likely you were right, so I won't not to change it.