Created attachment 253668 [details] zrepl-dsh2dsh-0.8.3.patch Him, this patch updates sysutils/zrepl-dsh2dsh to the latest release.
Thank you for the update. Please don't put extra blank lines into pkg-descr. The file is already over length and should not be made longer without a good reason. Is there a particular reason for the gracefulstop command? Can't you just modify the stop command to work like this? I'm not an expert on rc scripts, so maybe there's something I missed here.
(In reply to Robert Clausecker from comment #1) > The file is already over length Oops, sorry. I didn't know pkg-descr has so small limit. > Is there a particular reason for the gracefulstop command? > Can't you just modify the stop command to work like this? That's up to user. For instance I have this in /etc/rc.conf: zrepl_enable="YES" zrepl_gracefully="YES" zrepl_priority="warning" zrepl_control_group="operator" zrepl_control_mode="0750" and `service zrepl stop` does graceful stop on system shutdown. But I believe somebody else wants force stop on system shutdown and wants to `service zrepl gracefulstop && service zrepl start` for restart after config change or like that.
The recommended pkg-descr limit is ~25 lines. I understand your reasoning and will commit your patch with some light copy-editing. Also please remember to set your editor to a tab-width of 8 when editing ports Makefiles. It's all nicely aligned if you do so. I'll also go ahead and reset the commit author to what you use here on Bugzilla.
(In reply to Robert Clausecker from comment #3) > to set your editor to a tab-width of 8 Oh, I tried to find tab-width in porters handbook and no luck. But I found tab-width: 4 in bsd.port.mk. Looks like your advise conflicts with it. I'd like to know what is official recommendation for tab-width in Makefiles, 8 or 4? Right now I'm using 4.
For ports Makefiles, 8 columns is correct. bsd.port.mk is an infrastructure Makefile that doesn't follow the same formatting.
Build fails during check-plist: ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: @dir /var/run/zrepl ===> Checking for items in pkg-plist which are not in STAGEDIR ===> Error: Plist issues found. Shall I re-add this entry?
(In reply to Robert Clausecker from comment #6) > Shall I re-add this entry? No, no. I'll handle it. Thank you.
Created attachment 253720 [details] zrepl-dsh2dsh-0.8.3.patch
(In reply to Robert Clausecker from comment #6) > Shall I re-add this entry? I uploaded new patch with the fix. Also I reformated it using tab-width 8 and I removed extra empty lines from pkg-descr, so it's now < 25 lines.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=664fa9b2fe89d886243f58a81f6109063bf208ea commit 664fa9b2fe89d886243f58a81f6109063bf208ea Author: Denis Shaposhnikov <dsh@bamus.cz> AuthorDate: 2024-09-21 13:38:04 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2024-09-25 06:28:04 +0000 sysutils/zrepl-dsh2dsh: update to 0.8.3 Changelog: https://github.com/dsh2dsh/zrepl/releases/tag/v0.8.3 PR: 281591 Event: EuroBSDcon 2024 sysutils/zrepl-dsh2dsh/Makefile | 11 ++-- sysutils/zrepl-dsh2dsh/distinfo | 10 +-- sysutils/zrepl-dsh2dsh/files/zrepl.in | 116 ++++++++++++++++++++------------- sysutils/zrepl-dsh2dsh/files/zrepl.yml | 12 ---- sysutils/zrepl-dsh2dsh/pkg-descr | 8 ++- sysutils/zrepl-dsh2dsh/pkg-plist | 1 - 6 files changed, 85 insertions(+), 73 deletions(-)
Thank you for your contribution.