Bug 281625 - misc/getopt: Sunset port in favour "bundled" variant in devel/util-linux
Summary: misc/getopt: Sunset port in favour "bundled" variant in devel/util-linux
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-21 08:37 UTC by Daniel Engberg
Modified: 2024-11-03 11:58 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-09-21 08:37:12 UTC
While not a high maintenance project it hasn't been touched for 9 years while the imported version in util-linux have been maintained.

https://svn.frodo.looijaard.name/viewvc/cgi-bin/viewvc.cgi/public/getopt/trunk/?view=log

https://github.com/util-linux/util-linux/commits/master/misc-utils/getopt.c
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-10-07 14:32:23 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9c41d8407966bc8d14d3204a928508ec44444bcf

commit 9c41d8407966bc8d14d3204a928508ec44444bcf
Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2024-10-07 13:59:05 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2024-10-07 14:18:37 +0000

    misc/getopt: Mark DEPRECATED and set EXPIRATION_DATE to 2024-10-31

    PR:             281625
    Reported by:    diizzy

 misc/getopt/Makefile | 3 +++
 1 file changed, 3 insertions(+)
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2024-10-07 14:33:24 UTC
Committed. Thanks!
Comment 3 Michael Osipov freebsd_committer freebsd_triage 2024-10-12 18:47:31 UTC
I somewhat object this because util-linux has tons of utils, not only it requires more space it overrides utils in base which have a different behavior than those in base. Maybe misc/getopt would be a slave port and only install getopt from those utils?
Comment 4 Michael Osipov freebsd_committer freebsd_triage 2024-10-12 18:50:41 UTC
Some might be better off with devel/getoptions.
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2024-10-12 19:50:07 UTC
(In reply to Michael Osipov from comment #3)
It affects a very small amount of ports and util-linux is less than 1Mbyte (compressed) so size isn't really an issue. Eventually it can be turned into a subpackage but it's not ready yet so in the meanwhile just bundle it with the rest. Unless you change PATH env util-linux won't override anything in base?
Comment 6 Michael Osipov freebsd_committer freebsd_triage 2024-10-12 23:39:52 UTC
(In reply to Daniel Engberg from comment #5)

Well, most do override PATH otherwise you are stuck with things like old Heimdal in base...
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-11-02 12:11:52 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c8ace2f4ca960d3a3a0038846923efcae2f8443d

commit c8ace2f4ca960d3a3a0038846923efcae2f8443d
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-11-02 11:59:48 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-11-02 12:01:52 +0000

    */*: Switch from misc/getopt to devel/util-linux

    misc/getopt expired on 2024-10-31 so it's time to switch

    PR:             281625
    Approved by:    portmgr (blanket, build fix)

 devel/compiz-bcop/Makefile       | 4 ++--
 devel/gitflow/Makefile           | 3 ++-
 french/aster/Makefile            | 2 +-
 math/eukleides/Makefile          | 4 ++--
 net/pacemaker2/Makefile          | 2 +-
 net/pacemaker2/Makefile.common   | 6 +++---
 sysutils/password-store/Makefile | 4 ++--
 sysutils/tartarus/Makefile       | 4 ++--
 textproc/rarian/Makefile         | 6 +++---
 textproc/xmlto/Makefile          | 4 ++--
 textproc/yodl/Makefile           | 4 ++--
 x11-fonts/fontpreview/Makefile   | 4 ++--
 12 files changed, 24 insertions(+), 23 deletions(-)
Comment 8 commit-hook freebsd_committer freebsd_triage 2024-11-03 11:50:37 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=521da5fb1087f9ec846a35e0ea200088e6571b1d

commit 521da5fb1087f9ec846a35e0ea200088e6571b1d
Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2024-11-03 11:48:23 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2024-11-03 11:48:23 +0000

    */*: Change *_DEPENDS from devel/util-linux back to misc/getopt

    - Revert c8ace2f4ca960d3a3a0038846923efcae2f8443d
    - Bump PORTREVISION for dependency change

    PR:             281625, 281934
    Reference:      https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281934#c2

 devel/compiz-bcop/Makefile       | 4 ++--
 devel/gitflow/Makefile           | 4 ++--
 french/aster/Makefile            | 4 ++--
 math/eukleides/Makefile          | 4 ++--
 net/pacemaker2/Makefile          | 2 +-
 net/pacemaker2/Makefile.common   | 4 ++--
 sysutils/password-store/Makefile | 4 ++--
 sysutils/tartarus/Makefile       | 4 ++--
 textproc/rarian/Makefile         | 6 +++---
 textproc/xmlto/Makefile          | 4 ++--
 textproc/yodl/Makefile           | 4 ++--
 x11-fonts/fontpreview/Makefile   | 4 ++--
 12 files changed, 24 insertions(+), 24 deletions(-)
Comment 9 commit-hook freebsd_committer freebsd_triage 2024-11-03 11:50:38 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4ddfd281f8eb07657fd1e268fed59478a4a2ce38

commit 4ddfd281f8eb07657fd1e268fed59478a4a2ce38
Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2024-11-03 11:34:23 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2024-11-03 11:34:23 +0000

    misc/getopt: Re-add getopt 1.1.6

    PR:             281625

 MOVED                                  |  1 -
 misc/Makefile                          |  1 +
 misc/getopt/Makefile (new)             | 38 ++++++++++++++++++++++++++
 misc/getopt/distinfo (new)             |  3 +++
 misc/getopt/files/patch-Makefile (new) | 49 ++++++++++++++++++++++++++++++++++
 misc/getopt/pkg-descr (new)            | 11 ++++++++
 misc/getopt/pkg-plist (new)            | 28 +++++++++++++++++++
 7 files changed, 130 insertions(+), 1 deletion(-)
Comment 10 Po-Chuan Hsieh freebsd_committer freebsd_triage 2024-11-03 11:58:20 UTC
As I said in bug #281934 comment #2, I don't mean to remove misc/getopt.

I have made the following changes:
1. Re-added the misc/getopt port
2. Change it to use util-linux repo
3. Move all ports back to use it

That means it does not bring unnecessary dependencies from devel/util-linux to getopt's dependent ports.
It should fix all issues.