Bug 281640 - graphics/dcmtk: Actually link with shared version of libtiff and add USES= pathfix
Summary: graphics/dcmtk: Actually link with shared version of libtiff and add USES= pa...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on: 281639
Blocks:
  Show dependency treegraph
 
Reported: 2024-09-22 09:52 UTC by Daniel Engberg
Modified: 2024-10-09 19:48 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (yuri)


Attachments
Patch for dcmtk (1.09 KB, patch)
2024-09-22 09:52 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-09-22 09:52:04 UTC
Created attachment 253735 [details]
Patch for dcmtk

Port defines (lib)tiff as shared library and also refers to it in .pc file as a shared however dcmimage/libsrc compiles using static library. Adjust upstream code to link with the shared library instead. While at it add USES= pathfix to fix warning about location of installed .pc file.

Poudriere testport OK 13.3-RELEASE (amd64)
Poudriere testport OK 14.0-RELEASE (amd64)
Poudriere testport OK 14.1-RELEASE (amd64)

This change requires PR 281639 to be applied
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-10-09 19:44:32 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c76de315944078eac241ceff1ae3926678c25f23

commit c76de315944078eac241ceff1ae3926678c25f23
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-10-09 19:19:58 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-10-09 19:43:25 +0000

    graphics/dcmtk: Link with shared version of libtiff and add USES= pathfix

    Port defines (lib)tiff as dependency using the shared library and also
    refers to it in .pc file as a shared however dcmimage/libsrc compiles
    using the static library. Adjust upstream code to link with the
    shared library instead. While at it add USES= pathfix to fix warning
    about location of installed .pc file.

    PR:             281640
    Reviewed by:    yuri

 graphics/dcmtk/Makefile                                         | 3 ++-
 graphics/dcmtk/files/patch-dcmimage_libsrc_CMakeLists.txt (new) | 8 ++++++++
 2 files changed, 10 insertions(+), 1 deletion(-)
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2024-10-09 19:48:21 UTC
Committed, thanks