Created attachment 253785 [details] update to 8.0.16 Update from 1.7.4 to 8.0.16
Maintainer informed via mail
Lars Herschke, do you not like the patch or does this update break backward compatibility or something else? There is 9.1.3: https://tomee.apache.org/9.1.3/release-notes.html. Versions 1.x, 7.x and 8.x are "Discontinued".
https://tomee.apache.org/comparison.html "Jakarta EE 9.x introduces breaking changes (relocation from javax.* to jakarta.* namespace). When in doubt choose Jakarta EE 8 and TomEE 8.x"
TomEE 8 includes Tomcat 9, which is still in support.
(In reply to Lars Herschke from comment #4) You set flag "lhersch: maintainer-feedback-", but you are not the maintainer of this port… Maintainer is neu@mycontrol.de. P.S. 14 days maintainer timeout already reached - I can commit it "as is". P.P.S. Can you please attach pkg-plist.
Yes, I have set ‘maintainer-feedback -’. The description says ‘Set (-) when feedback is not provided. Add comment. Use for "maintainer timeout"’ I thought I could use this to display the maintainer timeout. If this is not the case, I have used the flag incorrectly in all my PRs so far. The pkg-plist or the diff to the old one is included in the patch.
(In reply to Lars Herschke from comment #6) > Add comment. Use for "maintainer timeout" Ok, updating with maintainer timeout.
Can you convert: post-patch: @${FIND} ${WRKSRC} -name '*.bat' -delete @${FIND} ${WRKSRC} -name '*.exe' -delete @${FIND} ${WRKSRC} -name '*.bat.original' -delete to: EXTRACT_AFTER_ARGS= --exclude *.bat \ --exclude *.bat.original \ --exclude *.exe \ --no-same-owner --no-same-permissions and test.
Also this: ${CP} -R ${WRKSRC}/* ${STAGEDIR}${TOMEE_HOME} ${FIND} ${STAGEDIR}${TOMEE_HOME} -type d -print0 | ${XARGS} -0 ${CHMOD} 755 replace with: ${CD} ${WRKSRC} && ${COPYTREE_SHARE} . ${STAGEDIR}${TOMEE_HOME} and test.
Can you attach pkg-plist as separate file? Maybe you want to create ports tomee91 and tomee100 (as a maintainer)?
Created attachment 254334 [details] update to 8.0.16 Here is a new patch with the desired changes.
Created attachment 254335 [details] pkg-plist And here is the pkg-plist file separately.
(In reply to Lars Herschke from comment #12) Thanks. "cd ${WRKSRC} && ${COPYTREE_SHARE} . ${STAGEDIR}${TOMEE_HOME}" removed +x from bin/*.sh. I returned old way: ${CP} -R ${WRKSRC}/* ${STAGEDIR}${TOMEE_HOME} ${FIND} ${STAGEDIR}${TOMEE_HOME} -type d -print0 | ${XARGS} -0 ${CHMOD} 755 Also fix warnings from portclippy - variables order only in Makefile. Build fine on live system 14.1 amd64. Waiting build in poudriere 14.1 amd64.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=7ba144789a552c7c16d3ef3fa4537f36165a84ed commit 7ba144789a552c7c16d3ef3fa4537f36165a84ed Author: Lars Herschke <lhersch@dssgmbh.de> AuthorDate: 2024-10-18 23:27:12 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2024-10-18 23:27:12 +0000 www/tomee: Update 1.7.4 → 8.0.16 Update to the latest version with keep backward compatibility: "Jakarta EE 9.x introduces breaking changes (relocation from javax.* to jakarta.* namespace). When in doubt choose Jakarta EE 8 and TomEE 8.x" Release notes for with version: https://tomee.apache.org/8.0.16/release-notes.html Replace "find -delete" with EXTRACT_AFTER_ARGS. Fix warnings from portclippy. PR: 281671 Approved by: neu@mycontrol.de (maintainer, timeout > 14 days) www/tomee/Makefile | 36 +++---- www/tomee/distinfo | 6 +- www/tomee/files/tomee.in | 31 ++++-- www/tomee/pkg-plist | 248 +++++++++++++++++++++++++++-------------------- 4 files changed, 187 insertions(+), 134 deletions(-)
Thanks.